Commit Graph
97 Commits
Author SHA1 Message Date
Nate Coraor dfdbef9d36 Reintroduce roles. Unfinished stuff: setting default user and history
permissions, user-side permissions settings on datasets, viewing
associated datasets under the role page in the admin controler (is this
even necessary?), filtering out roles by type.  I haven't addressed
tests, so the security-related functional tests will fail.  I haven't
looked at history sharing yet either.  Cleanup to remove unused methods
is needed in the admin controller.  And the admin templates are a
bit messy.
2008-10-09 17:05:57 -04:00
Greg Von Kuster 2929432b92 my message 2008-10-07 15:29:30 -04:00
Greg Von Kuster b3b6c54247 Use only 1 underlying executable ( data_source.py ) for data source tools. A new tag set is added to the data source tool configs to handle tranlsation of request param names sent by remote apps ( something like <param_trans galaxy_name="dbkey" remote_name="GENOME" missing="?" /> ). 2008-10-07 15:21:46 -04:00
Daniel Blankenberg db11727228 Resolve Merging Conflicts 2008-10-07 12:09:28 -04:00
Greg Von Kuster c05f66d5ee Treat EpiGRAPH as a data source much like ucsc table browser. 2008-10-06 13:34:51 -04:00
Guruprasad Anada 4395c31fbc Merge changeset to security 2008-09-30 15:45:25 -04:00
Guruprasad Anada 550da8f952 Modified the way biomart tool runs: output generation will be completed before exec_afer_process hook is called. 2008-09-30 15:30:57 -04:00
Greg Von Kuster 44bc594079 my message 2008-09-22 10:39:47 -04:00
Greg Von Kuster b4890c1bbb Integrate with intermine ( data source ) and epigraph ( data destination ). Receiving data from epigraph coming soon. Data is sent to epigraph using a combination of DATA_URL and REDIRECT_URL tool params. This tool creates jobs, but does not queue them for execution. 2008-09-22 10:36:34 -04:00
Nate Coraor 4edc6d6626 Spiffy new library browser interface. Also, dim datasets in your
history on which you don't have permissions.
2008-09-10 10:10:13 -04:00
Nate Coraor 3802816b69 User interface to permissions, and a bunch of changes to ensure that
both permitted_actions and groups are set appropriately on datasets.
Somewhat tested and mostly working, but needs more testing.

Greg: If a userless session has a history, if that user logs in,
the DefaultHistoryGroupAssociation for the current history as well
as the datasets in that history are supposed to be updated with the
permissions in DefaultUserGroupAssociation, but this isn't happening.
Possibly because the default permissions on userless histories create
datasets in the public group with only the DATASET_ACCESS permission
(or possibly for another reason).  What are the implications of giving
public users DATASET_MANAGE_PERMISSIONS?
2008-08-20 18:11:04 -04:00
Greg Von Kuster f50ee0fff3 Added security to libraries. Non-admin users can now only see libraries that contain datasets associated with the user's groups, and each library will only display those datasets that are associated with the user's groups. 2008-08-19 10:04:30 -04:00
Daniel Blankenberg da0b09039c Initial check in of library functionality.
The ui is Very rough, at best.

Libraries can be accessed by users through a new tool under datasources.

Libraries can be created and accessed for modification via a link on the admin page.

Currently, all library datasets are currently associated with the public group.

Tags have been defined (tables and mappings) and can be associated with a dataset or a folder, but there is currenty no interface for displaying or creating these.

Creation and editing of a library should be an admin only function, however this check is not currently present.

The creation/editing page for a dataset is currently hard coded, it should be dynamic (i.e. datatypes and dbkeys)

Brief description of a library:
A library is composed of a name, description and a root folder.
A folder is composed of a name, description, and a parent folder (none when is the root), where a folder can have many or none child folders and datasets.
A library dataset is composed of most of the same attributes as a history dataset, but it is linked via a folder_id to a folder (instead of a history_id to a history).

Ordering of the library is maintained by the 'order_id' attribute of each folder and dataset object (which is populated by the item_count attribute of a folder)
2008-08-12 16:56:26 -04:00
Greg Von Kuster 85909a2aad Eliminated Roles and all associated components from dataset security implementation. Additional testing, possible cleanup needed - see TODO comments in code. Committing so Nate can take over... 2008-08-11 09:03:34 -04:00
Daniel Blankenberg c546f50963 Properly set permissions on tools that create new datasets in their post job hooks (this is deprecated). 2008-08-06 15:41:38 -04:00
Greg Von Kuster 8d679d6541 Change C Elegans server URL to wormbase using GBrowse version 1.69. 2008-07-24 13:59:23 -04:00
Daniel Blankenberg 28b89d686f Change database schema to separate Dataset and HistoryDatasetAssociation. This is a significant change, be sure to follow the migration notes exactly.
Make sure to backup your database before updating.


Also fix a long standing bug in the async controller dealing with updating output datasets upon job completion.


Credit for database migration directions go to Greg.

*** This is a significant change, be sure to follow the migration steps below exactly and in order: ***

---------------

0. Stop Galaxy server

---------------

1. Backup database and galaxy_root/database directory

---------------

2. The current validation_error table is not being used, it is left over from Ian's work that was not made functional.  However, if we want to keep it around, we should drop the old version of the table so it will get re-created correctly when the Galaxy server is restarted:

any database - sql command(s):
------------------------------
DROP TABLE validation_error;

---------------

3. Stop server, perform svn update to get latest code, start server to create new history_dataset_association and implicitly_converted_dataset_association tables

---------------

4. Add new columns to dataset table:

postgres sql command(s):
------------------------
ALTER TABLE dataset ADD COLUMN purgable boolean DEFAULT 't';
ALTER TABLE dataset ADD COLUMN external_filename text;
ALTER TABLE dataset ADD COLUMN _extra_files_path text;

mysql sql command(s):
---------------------
ALTER TABLE dataset ADD COLUMN purgable boolean DEFAULT TRUE;
ALTER TABLE dataset ADD COLUMN external_filename text;
ALTER TABLE dataset ADD COLUMN _extra_files_path text;

sqlite sql command(s):
----------------------
ALTER TABLE dataset ADD COLUMN purgable boolean DEFAULT 0;
ALTER TABLE dataset ADD COLUMN external_filename text;
ALTER TABLE dataset ADD COLUMN _extra_files_path text;

---------------

5. Populate new columns:

postgres sql command(s):
------------------------
UPDATE
dataset
SET
external_filename = dataset_filename.filename,
_extra_files_path = dataset_filename.extra_files_path
FROM
dataset_filename
WHERE
dataset.filename_id = dataset_filename.id;

mysql or sqlite sql command(s):
-------------------------------
UPDATE
dataset,
dataset_filename
SET
dataset.external_filename = dataset_filename.filename,
dataset._extra_files_path = dataset_filename.extra_files_path
WHERE
dataset.filename_id = dataset_filename.id;

---------------

6. Populate dataset table with info from dataset_child_association table:

postgres sql command(s):
------------------------
UPDATE
dataset
SET
parent_id = dataset_child_association.parent_dataset_id
FROM
dataset_child_association
WHERE
dataset.id = dataset_child_association.child_dataset_id;

mysql or sqlite sql command(s):
-------------------------------
UPDATE
dataset,
dataset_child_association
SET
dataset.parent_id = dataset_child_association.parent_dataset_id
WHERE
dataset.id = dataset_child_association.child_dataset_id;

---------------

7. Drop dataset_child_association table:

any database - sql command(s):
------------------------------
DROP TABLE dataset_child_association;

---------------

8. Copy parts of the current dataset table to the new history_dataset_association table:

postgres sql command(s):
------------------------
INSERT INTO history_dataset_association
SELECT
id,
history_id,
id AS dataset_id,
create_time,
update_time,
hid,
name,
info,
blurb,
peek,
extension,
metadata,
parent_id,
designation,
deleted,
visible
FROM dataset
ORDER BY id;

mysql or sqlite sql command(s):
-------------------------------
INSERT INTO
history_dataset_association
(
history_id,
dataset_id,
create_time,
update_time,
hid,
name,
info,
blurb,
peek,
extension,
metadata,
parent_id,
designation,
deleted,
visible
)
SELECT
history_id,
id,
create_time,
update_time,
hid,
name,
info,
blurb,
peek,
extension,
metadata,
parent_id,
designation,
deleted,
visible
FROM
dataset
ORDER BY
id;

---------------

9. Update the nextval value of the primary key sequence in the history_dataset_association table

NOTE: THIS IS NOT NECESSARY FOR MYSQL OR SQLITE!

postgres sql command(s):
------------------------
SELECT
setval('history_dataset_association_id_seq', max(id))
FROM
history_dataset_association;

---------------

10. Update dataset table to mark dataset_associated_file dataset as deleted:

postgres sql command(s):
------------------------
UPDATE dataset
SET
deleted = 't'
WHERE
id IN
(SELECT dataset_id FROM dataset_associated_file ORDER BY dataset_id DESC);

mysql or sqlite sql command(s):
-------------------------------
UPDATE dataset
SET
deleted = TRUE
WHERE
id IN
(SELECT dataset_id FROM dataset_associated_file ORDER BY dataset_id DESC);

---------------

11. Drop the dataset_associated_file table:

any database - sql command(s):
------------------------------
DROP TABLE dataset_associated_file;

---------------

12. Alter foreign keys on job_to_input_dataset table:

postgres or sqlite sql command(s):
------------------------
ALTER TABLE
job_to_input_dataset
DROP CONSTRAINT
job_to_input_dataset_dataset_id_fkey;

ALTER TABLE
job_to_input_dataset
ADD CONSTRAINT job_to_input_dataset_dataset_id_fkey
FOREIGN KEY
(dataset_id)
REFERENCES
history_dataset_association(id);


mysql sql command(s):
-------------------------------
ALTER TABLE
job_to_input_dataset
DROP FOREIGN KEY
ix_job_to_input_dataset_dataset_id;

ALTER TABLE
job_to_input_dataset
ADD FOREIGN KEY
ix_job_to_input_dataset_dataset_id (dataset_id)
REFERENCES
history_dataset_association(id);

---------------

13. Alter foreign keys on job_to_output_dataset table:

postgres or sqlite sql command(s):
------------------------
ALTER TABLE
job_to_output_dataset
DROP CONSTRAINT
job_to_output_dataset_dataset_id_fkey;

ALTER TABLE
job_to_output_dataset
ADD CONSTRAINT
job_to_output_dataset_dataset_id_fkey
FOREIGN KEY (dataset_id)
REFERENCES history_dataset_association(id);

mysql sql command(s):
-------------------------------
ALTER TABLE
job_to_output_dataset
DROP FOREIGN KEY
ix_job_to_output_dataset_dataset_id;

ALTER TABLE
job_to_output_dataset
ADD FOREIGN KEY
ix_job_to_output_dataset_dataset_id
FOREIGN KEY (dataset_id)
REFERENCES history_dataset_association(id);

---------------

14. Eliminate columns from the dataset table previously copied to history_dataset_association:

any database - sql command(s):
------------------------------
ALTER TABLE dataset DROP COLUMN hid;
ALTER TABLE dataset DROP COLUMN history_id;
ALTER TABLE dataset DROP COLUMN name;
ALTER TABLE dataset DROP COLUMN info;
ALTER TABLE dataset DROP COLUMN blurb;
ALTER TABLE dataset DROP COLUMN peek;
ALTER TABLE dataset DROP COLUMN extension;
ALTER TABLE dataset DROP COLUMN dbkey;
ALTER TABLE dataset DROP COLUMN metadata;
ALTER TABLE dataset DROP COLUMN parent_id;
ALTER TABLE dataset DROP COLUMN designation;
ALTER TABLE dataset DROP COLUMN visible;
ALTER TABLE dataset DROP COLUMN filename_id;
2008-07-09 17:41:08 +00:00
Greg Von Kuster 666de20b4d Cleanup for fastqsolexa data type converters. We are currently supporting only the Solexa variant and will add support for other variants when the formats stabilize. 2008-06-09 20:15:04 +00:00
Greg Von Kuster 74da99d8f2 Fix a typo in Chromatin and Chromosomes exec_after_process hook. 2008-06-09 17:13:38 +00:00
Wen-Yu Chung 782d7db6be Update fastq format.
Now we only support FastqSolexa variants.
If the quality scores are presented as characters,
the integer values are obtained by their ascii code subtract 64.
2008-06-06 18:52:11 +00:00
Greg Von Kuster 04e0834500 Revert 2715. 2008-06-04 13:02:15 +00:00
Greg Von Kuster dedc7278a1 Requires config change, temporary files are now created in a configurable location - affects many tools. 2008-06-03 20:29:54 +00:00
Greg Von Kuster 1a23f9e55d Requires config modification - Add Fastq sniffer, add support for fastqsolexa data type, rename convert_fatsq2fasta tool to be fastq_to_fasta_qual, add functional tests for both fastq and fastqsolexa data types, misc code cleanup. 2008-05-29 19:12:36 +00:00
Daniel Blankenberg 11a2c767c3 Rewrite of dynamic options for select lists. There are no more 'special cases' and new filters are much easier to incorporate, as neeeded.
MAF tool interfaces now support the use of index species and all species existing in cached alignment sets.
Until main is updated and the old maf_location files can be overwritten, these symbolic links are required:
maf_index.loc -> /depot/data2/galaxy/maf_index_new.loc
maf_pairwise.loc -> /depot/data2/galaxy/maf_pairwise_new.loc
2008-05-29 17:38:46 +00:00
Greg Von Kuster 711af7a4f2 Fix for sniffing datatypes, sniff order is now retrieved from app.datatypes_registry rather than the default sniff_order list in the Registry class. 2008-05-28 21:20:15 +00:00
Greg Von Kuster 84c5c4387d Add support ( sans sniffer ) for FASTQ data type. 2008-05-27 19:25:54 +00:00
Greg Von Kuster 8f944ef045 Changed URL for communicating with elegans server. 2008-05-16 12:15:04 +00:00
Greg Von Kuster b0a4a72315 Eliminate hack in tool_runner for gbrowse. 2008-05-15 19:51:21 +00:00
Greg Von Kuster c424782fb4 More fixes for GBrowse / GMOD communication, tool now includes command line, display in GBrowse links now functional. 2008-05-15 18:46:51 +00:00
Greg Von Kuster 3f9afc5281 Fixes for GBrowse communication. 2008-05-15 13:38:31 +00:00
Greg Von Kuster 92782b4c40 Fixes for GBrowse tool. 2008-05-13 14:42:18 +00:00
Greg Von Kuster c32f87624f Added code for integration with C. Elegans / GBrowse test server. 2008-05-12 18:55:48 +00:00
Nate Coraor a7392abea5 Missed a couple tool imports of the eggs modules. 2008-04-14 21:08:45 +00:00
Greg Von Kuster af3b0669aa Eliminated all Python2.4 references, added necessary assert statements to ensure minimum version of Python 2.4. 2008-03-28 15:24:50 +00:00
Greg Von Kuster 709d2e1292 Fix for get_microbial_data tool. 2008-03-26 20:55:18 +00:00
Greg Von Kuster 749f218f08 Changed GALAXY_DATA_INDEX_DIR from an environment variable to a config entry. 2008-03-25 14:09:27 +00:00
Greg Von Kuster cd52cabd48 Eliminated hard-codes paths to locally cached data from tools, requires developers to add softlinks to development environments.
Galaxy developers should execute the following commands in their $UNIVERSE_HOME/tool-data directories:

ln -s /depot/data2/galaxy/alignseq.loc alignseq.loc
ln -s /depot/data2/galaxy/binned_scores.loc binned_scores.loc
ln -s /depot/data2/galaxy/blastdb.loc blastdb.loc
ln -s /depot/data2/galaxy/encode_datasets.loc encode_datasets.loc
ln -s /depot/data2/galaxy/liftOver.loc liftOver.loc
ln -s /depot/data2/galaxy/maf_index.loc maf_index.loc
ln -s /depot/data2/galaxy/maf_pairwise.loc maf_pairwise.loc
ln -s /depot/data2/galaxy/microbes/microbial_data.loc microbial_data.loc
ln -s /depot/data2/galaxy/phastOdds.loc phastOdds.loc
ln -s /depot/data2/galaxy/quality_scores.loc quality_scores.loc
ln -s /depot/data2/galaxy/regions.loc regions.loc
ln -s /depot/data2/galaxy/twobit.loc twobit.loc
2008-03-21 18:31:39 +00:00
Greg Von Kuster dbc9b6a403 Cleaned up data_meta filter for dynamically generated select lists. 2008-02-29 17:44:37 +00:00
Greg Von Kuster 703c916b09 Added blurb to Get ENCODE Data tools telling user data may not be current. 2008-01-14 21:39:11 +00:00
Greg Von Kuster 6d80665988 Added file_size column to dataset table, requires db schema alteration:
alter table dataset add column file_size numeric(15,0)
Also added new script update_dataset_size.py
2008-01-08 16:19:25 +00:00
Greg Von Kuster 31d1a87141 Better error handling in interval_to_bd_converter, a couple of other small tool fixes. 2008-01-07 18:49:12 +00:00
Greg Von Kuster 05df900b3d Metadata will now be set on all output datasets when getting encode data. 2008-01-03 14:12:07 +00:00
Greg Von Kuster e94d18ad63 A better way to decompress UCSC gzipped files. Added functional tests for uploading binary, zipped and gzipped files. Added temp file removal to upload when exception thrown. Eliminated an unnecessary import in subtract_query. 2007-12-20 18:49:03 +00:00
Greg Von Kuster 73507a1aa3 Fix for reading gzipped data from UCSC larger than 1 Mb in size. 2007-12-20 14:47:11 +00:00
Greg Von Kuster 737bdf23f9 Enhanced upload to handle certain binary and zip files. Cleaned up the upload config. Added 4 new data types: ab1, scf, binseq.zip and txtseq.zip. Added Regional Variation section to tool_conf.xml.main. 2007-12-14 21:07:11 +00:00
Greg Von Kuster 58afe0f9ce Cleaned up error handling, added exception handling in ucsc_tablebrowser.py 2007-12-13 15:01:45 +00:00
Greg Von Kuster d61ae1181e Bug fix in biomart - metadata will now be correctly set for biomart data. 2007-12-11 18:40:30 +00:00
Greg Von Kuster f7f7aeab26 Fixed a security flaw in upload.py. Added a unit test for get_file_peek() to data.py, along with outher cleanup. Corrected gbrowse display links in interval.py. Bug fixes in root.py where google bots were throwing exceptions. 2007-12-10 21:00:21 +00:00
Greg Von Kuster bbba08b89d Gzipped files from UCSC will now be decompressed on the fly. Also fixed a bug in biomart_filter. 2007-12-10 16:13:05 +00:00
Greg Von Kuster ab1d867915 More dynamic options cleanup. Eliminated the "tool_type" attribute, among other cleanup chores. 2007-11-30 20:08:21 +00:00