Commit Graph
1081 Commits
Author SHA1 Message Date
John Chilton dfd9839185 Fix test_job_configuration.py for job metrics PR.
Still need to go in and actually write some tests for the nested parsing that can happen.
2014-04-22 21:40:08 -05:00
John Chilton 2ec1f3e9af Merge pull request #352. 2014-04-22 21:06:03 -05:00
John Chilton 7ed40c36b5 Unit tests for job conf parsing.
Update advanced job sample to fix "bugs" discovered during testing limit parsing.
2014-04-22 20:50:18 -05:00
Dave Bouvier b8981f4659 Fix library template functional tests. Revert change to user info tests that was breaking library template tests. 2014-04-22 12:58:42 -04:00
John Chilton b5e97ea32b Workflow Editor: Merge addDataInput and replaceDataInput into common method.
Reduces some code duplication here and reduces even more code duplication downstream in dataset collections work.
2014-04-22 11:13:27 -05:00
John Chilton cdeaba1f29 Workflow Editor: Replace instead of recreate terminal on update.
This fixes at least one subtle bug related to multiple input data parameters (actually probably two bugs) because the old logic assumed there was only one connector per input terminal.

This should be more efficient, lead to some code duplication deletion in subsequent changesets, and really help dataset collections where terminals are much more complex (there are data inputs and collection inputs, and each can be mapped over by collections) - this helps manage complexity downstream.
2014-04-22 11:13:27 -05:00
John Chilton 553bbee7db Workflow Editor: Rework InputTerminal to implement/use an update method (w/tests).
This will enable replacing terminals instead of recreating them and reconnecting in subsequent changesets.
2014-04-22 11:13:27 -05:00
Dave Bouvier fa15a53890 Fix functional tests for library features. 2014-04-21 16:51:05 -04:00
Dave Bouvier 5dab91f4ba Fix functional tests for history functions. 2014-04-21 15:42:22 -04:00
John Chilton cbfa265b83 Bugfix: Workflow editor could get in invalid state when trying to preserve connections.
Workflow editor would preserve connections when a tool would update its state (for instance switching a conditional or adding repeat) - but conditional switching can result in connections being invalid (wouldn't have passed can_accept previously). Consider the following tool for instance which changes datatypes of an input based on a conditional (https://gist.github.com/jmchilton/11152628).
2014-04-21 14:27:01 -05:00
John Chilton 5caf9dd13d Workflow Editor: Improve tests related to input terminal canAccept/datatypes.
Elminate stub, create mock tree off inputs (demonstrates what server is feeding), add test for direct and subtype. Add tests for PJA changing output connection datatypes.
2014-04-21 14:27:01 -05:00
John Chilton e454c738e1 Workflow Editor: Rename can_accept to canAccept. 2014-04-21 14:27:01 -05:00
Dave Bouvier 45ff30f6e1 Fix for registering an account with custom user information when only one custom user info form is defined. Fix editing user info when custom user info forms are defined. Fix functional tests for user info. 2014-04-21 12:41:05 -04:00
Carl Eberhard 1a88077a9a Metrics: make the cache use localStorage for persistence 2014-04-21 11:37:26 -04:00
Dave Bouvier 45733dda1e Fix issue where install and test framework would hang if a repository was not found in the database. 2014-04-19 23:24:12 -04:00
John Chilton 8ece04ac0c Merge pull request #363.
Was previously declined so that pull request #370 could be resolved first - but upon actually inspecting #370 I don't think these will conflict in anyway.
2014-04-19 11:57:53 -05:00
Carl Eberhard fd5e9d2d2c QA, metrics-logger: finish tests for existing; casperjs: restore correct return value for loggedInAs 2014-04-18 15:58:29 -04:00
Carl Eberhard b7212b0f37 QA, metrics logger: test metrics post 2014-04-18 14:42:26 -04:00
Carl Eberhard 302f2109ed QA: more testing of metrics logger 2014-04-18 12:58:20 -04:00
Carl Eberhard 5739c37cbf QA: add login info to api-hda-tests.js (unable to repro failure shown on buildbot) 2014-04-18 11:02:17 -04:00
Carl Eberhard 20ccb0f620 QA: add login info to api-history-permission-tests (unable to repro failure shown on buildbot), use API to check loggedInAs 2014-04-18 10:59:35 -04:00
Carl Eberhard 510d1a879f QA: adjust HDA API test for new anon ability to create contents 2014-04-18 10:25:37 -04:00
Carl Eberhard 4f3cce5e9b merge 2014-04-18 09:57:35 -04:00
Carl Eberhard a3a02170cb QA: add qunit tests for galaxy-app-base; Fix defaults in metrics-logger tests 2014-04-18 09:56:31 -04:00
John Chilton 2bda90ec6c Add option test system environment option GALAXY_TEST_VERBOSE_ERRORS to report on dataset errors.
Implemented a while ago to aid debugging but disabled by default because it can cause sqlite locking errors. It can now be enabled as needed using GALAXY_TEST_VERBOSE_ERRORS.
2014-04-18 08:41:59 -05:00
Dave Bouvier 5bdb75aa82 Correct usage of "it's" versus "its". 2014-04-17 15:49:32 -04:00
Dave Bouvier 30bc77e7ea Fix most of the failing functional tests in test_sample_tracking.py. 2014-04-17 15:16:57 -04:00
Dave Bouvier ac68f98bbd Fix certain failing functional tests. 2014-04-16 16:13:11 -04:00
Dave Bouvier 2a8882a446 Modify test framework to account for recent UI changes. 2014-04-16 09:18:56 -04:00
Carl Eberhard e68c90329a QA: allow grunt watch on qunit tests, add stubs for metrics-logger and hda-base 2014-04-11 13:34:06 -04:00
Carl Eberhard 588f9712e2 QA: update anon API tests due to d46493c 2014-04-11 10:20:09 -04:00
Greg Von Kuster 8bce650dda Add a new tool shed mercurial utility module named hg_util.py and begin to extract hg related utility functions out of the shed_util_common.py module. Enhance the functions that display the mercurial changeset rev and hash string to display one or the other or both. Display only the rev and not the hash string on the prominent grids in the tool shed, but continue to display the hash string on admin grids. 2014-04-10 17:11:01 -04:00
John Chilton a63f4d0c13 Workflow editor backbonification - make Terminal classes into models. 2014-04-10 15:46:07 -05:00
John Chilton aaa97c62a0 Workflow editor backbonification - make Node a model. 2014-04-10 15:46:07 -05:00
John Chilton b6ad39d461 Workflow editor backbonification - add OutputTerminalView.
Add unit tests for OutputTerminalView.
2014-04-10 15:46:07 -05:00
John Chilton 0aaa9f97ce Workflow editor backbonification - add InputTerminalView.
Add unit tests for new view.
2014-04-10 15:46:06 -05:00
John Chilton ab63eec1c6 Workflow editor backbonification - add NodeView.
Including unit tests.
2014-04-10 15:46:06 -05:00
John Chilton 7b2c20cc46 Outline workflow editor tests. 2014-04-10 13:31:48 -05:00
Greg Von Kuster 9c29c424d9 Fix in the tool shed install and test framework for a recently relocated function. 2014-04-10 07:20:27 -04:00
Greg Von Kuster 27e60943bf The basis of this change set is to provide some fixes to certain Tool Shed functions for supporting changing HTTP protocols over time (ie.e, https <-> http). In doing this, I've refactored several functions and moved most of the Tool Shed <-> Galaxy URL munging functions to the Tool Shed's common_util.py module. Ive renamed the munging functions to clarify what each of them does. Several duplicate functions have been eliminated from the code as well. 2014-04-09 10:11:48 -04:00
Carl Eberhard 2187795562 QA: upgrade browser testing framework and tests to use casperjs 1.1-beta3 and phantomjs 1.9.2 2014-04-07 13:27:55 -04:00
Carl Eberhard 5245708a2f merge next-stable 2014-04-07 10:11:07 -04:00
Carl Eberhard b5b2635b0a Fix encoding/serialization of returned data from HDA create API 2014-04-07 10:10:26 -04:00
John Chilton bb9634e7ee Unit testing framework for client code.
This work is based on QUnit and tests are runnable in-browser without any external dependencies or via command-line using grunt and PhantomJS. See README.txt in `test/qunit` directory for more information on how to run tests.

A test case is defined by an HTML and JavaScript source file. The file `test-common.js` will bootstrap most of the minimal HTML needed for qunit and configure require so nearly all testing logic is isolated into test js file. An example test is included that demonstrates how to build tests using requirejs's `define` and target backbone components. Tests can target non-backbone code as well.

Sinon is included for stubbing out server interactions, etc... when testing backbone components. This seems to be a popular fallback for backbone projects not using Jasmine.
2014-04-03 16:20:59 -05:00
Greg Von Kuster ffa19b77a5 Add a new RepositoryGridFilterManager to the Tool Shed framework to support filtering the repositories displayed in the many Tool Shed grids. The current filters are CERTIFIED_LEVEL_ONE, CERTIFIED_LEVEL_ONE_SUITE and CERTIFIED_LEVEL_TWO, CERTIFIED_LEVEL_TWO_SUITE. The "level one" filters display repositories or suites that have been certified by the Tool Shed's install and test framework. The "level two" filters are not yet supported (the query enhancements are trivial, but not yet done) since no repositories in the test or main Tool Shed have been certified at this level (this level requires reviews and approvals by IUC members). When set, filters are stored in session cookies. Filters are easy to set. The Javascript event handler (e.g. checking a filter checkbox) would make a call something like: trans.app.repository_grid_filter_manager.set_filter( trans.app.repository_grid_filter_manager.filters.CERTIFIED_LEVEL_ONE ). 2014-04-02 15:18:40 -04:00
Greg Von Kuster a1c9b006e8 Really fix broken tool shed functional test. 2014-03-30 16:35:44 -04:00
John Chilton d590921b6f Add unit test for extra primary dataset collection.
Tests overridding various output properties (ext, dbkey, name, visible) with file name and galaxy.json, collecting from new_file_path versus job_working_directory, setting job output associations, and logic related to adding outputs to copied histories.
2014-03-28 18:33:03 -05:00
Carl Eberhard 5c02088a6f History/HDA API: normalize exceptions and exception codes; Fix ability to history/view a history shared with another user 2014-03-27 12:17:18 -04:00
John Chilton c0d365b386 Merged in jmchilton/galaxy-central-fork-1 (pull request #350)
Make requests dependency mandatory for testing
2014-03-26 16:22:34 -05:00
John Chilton 03303e51f2 Merged in jmchilton/galaxy-central-fork-1 (pull request #348)
Enhance workflows API to allow extracting workflow from history.
2014-03-26 16:21:15 -05:00