John Chilton
b5e97ea32b
Workflow Editor: Merge addDataInput and replaceDataInput into common method.
...
Reduces some code duplication here and reduces even more code duplication downstream in dataset collections work.
2014-04-22 11:13:27 -05:00
John Chilton
cdeaba1f29
Workflow Editor: Replace instead of recreate terminal on update.
...
This fixes at least one subtle bug related to multiple input data parameters (actually probably two bugs) because the old logic assumed there was only one connector per input terminal.
This should be more efficient, lead to some code duplication deletion in subsequent changesets, and really help dataset collections where terminals are much more complex (there are data inputs and collection inputs, and each can be mapped over by collections) - this helps manage complexity downstream.
2014-04-22 11:13:27 -05:00
John Chilton
553bbee7db
Workflow Editor: Rework InputTerminal to implement/use an update method (w/tests).
...
This will enable replacing terminals instead of recreating them and reconnecting in subsequent changesets.
2014-04-22 11:13:27 -05:00
John Chilton
cbfa265b83
Bugfix: Workflow editor could get in invalid state when trying to preserve connections.
...
Workflow editor would preserve connections when a tool would update its state (for instance switching a conditional or adding repeat) - but conditional switching can result in connections being invalid (wouldn't have passed can_accept previously). Consider the following tool for instance which changes datatypes of an input based on a conditional (https://gist.github.com/jmchilton/11152628 ).
2014-04-21 14:27:01 -05:00
John Chilton
357280ed4d
Workflow Editor: Break canAccept into smaller pieces (inputFilled and attachable).
...
Want to reuse attachable right away to fix a bug - and the smaller pieces are good refactoring to support different kinds of input types in dataset collections downstream.
2014-04-21 14:27:01 -05:00
John Chilton
e454c738e1
Workflow Editor: Rename can_accept to canAccept.
2014-04-21 14:27:01 -05:00
John Chilton
e70aecf74e
Workflow editor backbonification - reposition views to more appropriate part of file.
2014-04-10 15:46:07 -05:00
John Chilton
a63f4d0c13
Workflow editor backbonification - make Terminal classes into models.
2014-04-10 15:46:07 -05:00
John Chilton
aaa97c62a0
Workflow editor backbonification - make Node a model.
2014-04-10 15:46:07 -05:00
John Chilton
5d94853116
Workflow editor backbonification - refactor some update_field_data presentation logic into NodeView.
2014-04-10 15:46:07 -05:00
John Chilton
5d82a000ca
Workflow editor backbonification - move terminal presentation logic from NodeView to DataOutputView.
2014-04-10 15:46:07 -05:00
John Chilton
b9106b807a
Workflow editor backbonification - move terminal presentation logic from NodeView to DataInputView.
2014-04-10 15:46:07 -05:00
John Chilton
066f343a2c
Workflow editor backbonification - OutputTerminalView to Backbone.View event binding.
2014-04-10 15:46:07 -05:00
John Chilton
2a77d89a66
Workflow editor backbonification - InputTerminalView to Backbone.View event binding.
2014-04-10 15:46:07 -05:00
John Chilton
b6ad39d461
Workflow editor backbonification - add OutputTerminalView.
...
Add unit tests for OutputTerminalView.
2014-04-10 15:46:07 -05:00
John Chilton
0aaa9f97ce
Workflow editor backbonification - add InputTerminalView.
...
Add unit tests for new view.
2014-04-10 15:46:06 -05:00
John Chilton
1d85636c6a
Workflow editor backbonification - add view for output data view.
2014-04-10 15:46:06 -05:00
John Chilton
052348ed49
Workflow editor backbonification - add view for output callout.
2014-04-10 15:46:06 -05:00
John Chilton
7ab5f6a3bc
Workflow editor backbonification - add DataInputView.
2014-04-10 15:46:06 -05:00
John Chilton
ab63eec1c6
Workflow editor backbonification - add NodeView.
...
Including unit tests.
2014-04-10 15:46:06 -05:00
John Chilton
86ee4fdabf
Simplify enable_output_terminal and enable_output_terminal in workflow editor.
...
These functions were taking in a single element and then looping through it. I hope this is not some intententional jQuery pattern to change the value of 'this' I don't quite understand and is just a remnant of when some loop over inputs was on the inside of this function or some other such refactoring.
2014-04-10 13:31:48 -05:00
John Chilton
69ddb38557
Refactor interaction between workflows JS and editor JS for adding nodes.
...
Add abstraction into editor for use by galaxy.workflow.js to hide some editor details from workflow code and reduce duplication between add_node_for_tool and add_node_for_module.
2014-04-10 13:31:47 -05:00
John Chilton
9b0bbb0dab
Remove unused variable?
2014-04-10 13:31:46 -05:00
John Chilton
82e02eefa8
Eliminate code dup. in workflow editor for building input terminals.
2014-03-04 11:49:35 -06:00
John Chilton
14affd155a
Eliminate code dup. in workflow editor for building connectors.
2014-03-04 11:49:35 -06:00
John Chilton
1f9667cc19
Fix node type being sent to prebuild_node in galaxy.workflow_editor.js.
2014-03-04 11:49:35 -06:00
Jeremy Goecks
ac8d4d415e
Improve language for workflow outputs tooltip.
2013-12-13 10:00:20 -05:00
Carl Eberhard
28fb375971
UI: update to font-awesome 4.0.1 (Note: there is a new syntax and naming scheme for fa icons - names and classes have changed)
2013-10-30 10:52:28 -04:00
James Taylor
d1ab2061a0
Fix close/delete icons in workflow editor.
2013-09-17 15:18:51 -04:00
Aysam Guerler
5a05a52775
Unify parameter and url access in front end
2013-08-20 18:51:47 -04:00
Dannon Baker
d9040ccb99
Workflow Editor: Fix for last-remaining-workflow-output-unremovable. Clarify declaration (actually a bug, one was undefined, one was false).
2013-04-03 17:46:19 -04:00
Daniel Blankenberg
fce8cce834
Fix for workflow editor when a missing tool is connected to a valid tool. Javascript error would cause the 'Loading worflow editor...' modal window to spin indefinitely.
2013-01-07 11:45:26 -05:00
Jim Johnson
9d328872fc
Fix workflow_editor exceptions for multi-input when dragging
2012-10-16 11:47:57 -05:00
John Chilton
5524c060de
Initial work from JJ on enhancing the workflow editor to allow multiple input data parameters. Workflows containing such connections will now display properly, though they cannot be modified.
2012-10-16 09:13:32 -05:00
James Taylor
3118446f4e
tooltips: Replace all uses of tipsy with bootstrap style (with the same modifications for placement we previously used for tipsy). This will allow us to start using popovers
2012-07-20 16:28:23 -04:00
Dannon Baker
3ee5a84743
Fix heavy handed removal of PJAs when not using outputs.
2012-04-20 11:16:14 -04:00
Dannon Baker
67c3d95934
Workflow outputs logic rewrite. Accounts for old workflows that have no outputs defined but do use HideDatasetActions.
...
Fixes the bug where you couldnt' remove the last HideDatasetAction from a workflow in some situations.
2012-04-17 15:03:38 -04:00
Jeremy Goecks
5b2cda4a55
Create object to store Galaxy paths for use in JavaScript.
2012-04-10 19:06:24 -04:00
Dannon Baker
031b0fca6e
workflows: jquery1.5 fix, quotations.
2011-02-10 13:58:48 -05:00
Dannon Baker
b40c7e5b40
workflows: Fixed jquery 1.5 errors related to workflow saving and flagging of outputs. Repack.
2011-02-08 13:36:12 -05:00
James Taylor
17352f3de5
jquery updated to 1.5, fixed minor bugs in use of jStore and some dom manipulation in workflows (both problems in our code, not backward incompatibility). Please help test.
2011-02-06 14:42:11 -05:00
James Taylor
287dddc06f
Fixing jslint problems
2011-01-29 21:13:25 -05:00
James Taylor
761734318f
Update to jquery.event.[drag|drop] 2.0, fix panels, workflow editory, and trackster for compatibility
2011-01-29 20:51:55 -05:00
Dannon Baker
89be044152
Workflows containing tools that are not loaded will now open in the editor instead of failing on the dictionary lookup.
...
The offending nodes are marked as having an error state, and the workflow cannot be saved.
This will enable users to at least look at and try to recover a workflow by removing (and potentially replacing) the offending steps, as well as providing a better view of what's actually wrong with the workflow.
2011-01-21 15:50:21 -05:00
Dannon Baker
fb30a7db55
Fixed the javascript error on workflow saving introduced by the workflow parameter display.
2010-12-15 20:38:40 -05:00
Dannon Baker
4a92ae2b29
Primitive workflow parameter display. Doesn't do anything yet, but it gives a simple overview of what parameters have been used.
...
Fixed divide by zero that I introduced with the new color generation. D'oh.
2010-12-14 13:11:08 -05:00
Dannon Baker
9e01737db3
Packing editor.
...
Tweak to reload.
2010-11-01 17:21:47 -04:00
Dannon Baker
db8e1c8954
Cleanup of debug info.
2010-11-01 17:09:35 -04:00
Dannon Baker
5f3b33fff5
Shift management of the interaction between workflow outputs and HideDatasetActions to the front end editor.
...
This resolves the issue with multiple HideDatasetActions being created.
Existing workflows displaying multiple HideDatasetActions per step on the Run Workflow screen will persist.
These extra HideDatasetActions are harmless, but a simple edit workflow -> save will remove them.
2010-11-01 17:08:50 -04:00
Dannon Baker
5a28632683
Tweak to prevent workflow output indicator icon from getting out of sync. And repack.
2010-09-10 12:14:30 -04:00
John Chilton