John Chilton
daae4ded89
Fix two more issues with workflow form spotted in review.
...
- Missing check icon on run button.
- Sticky header div.
2020-01-30 10:07:20 -05:00
John Chilton
2ff5757d66
Cleanup based on review comments.
2020-01-30 09:41:07 -05:00
John Chilton
1dfc49ac21
Swap ternary operator to computed property in WaitButton component...
...
... per PR review comments (xref https://github.com/galaxyproject/galaxy/pull/9151/files/4fcfb7687b588819ccd0e4f0744947878fa79f72#diff-e9010db0a7029e12adf451f933077fdb )
2020-01-30 09:41:07 -05:00
John Chilton
0cca968ae0
wfrun2vue - tighter cohesion between Vue divs and Backbone divs.
...
Basically now Vue only sends through what was previously called $steps in the View. Vue doesn't touch steps and View doesn't touch anything above it now. Better abstractions!
2020-01-30 09:41:07 -05:00
John Chilton
a5d8bf7af8
wfrun2vue - rework error handling so run outer div unneeded in composite form
2020-01-30 09:41:07 -05:00
John Chilton
0653fc829a
wfrun2vue - migrate success handling to a new Vue component.
2020-01-30 09:41:06 -05:00
John Chilton
0995cd44e5
wfrun2vue - move header (title + run button) to Vue
2020-01-30 09:41:06 -05:00
John Chilton
66ed393467
wfrun2vue - refactor wf messages to Vue & b-alerts
2020-01-30 09:41:06 -05:00
John Chilton
698e1272e1
wfrun2vue - migrate main div construction to Vue.
2020-01-30 09:41:06 -05:00
John Chilton
2dc447b8d6
wfrun2vue - migrate load logic into Vue stub.
2020-01-30 09:41:06 -05:00
Dannon
79bb7fd5a1
Merge pull request #9167 from jmchilton/upload_vue_0
...
Vue-ify Upload Dialog w/small fixes
2020-01-29 10:14:46 -05:00
Dannon Baker
947b9eca5b
Merge remote-tracking branch 'upstream/dev' into idp-logout
2020-01-28 14:01:49 -05:00
Dannon Baker
13f4e1e3f1
Merge remote-tracking branch 'upstream/release_20.01' into dev
2020-01-28 13:24:09 -05:00
Dannon
8e16fcb4cc
Merge pull request #9233 from dannon/external-auth-login-refinement
...
[20.01] External auth login refinement
2020-01-28 13:22:55 -05:00
guerler
9d1368b74b
Replace custom workflow tags component with commen tags component in workflow list
2020-01-24 13:53:51 -05:00
guerler
5e140dd3fb
Refactor common tags component, use explicit and basic properties, avoid prop mutation
2020-01-24 13:33:42 -05:00
guerler
e2ea665ca5
Explicitly specify properties for workflow panel component
2020-01-24 12:28:27 -05:00
guerler
c3623896cc
Merge branch 'dev' into upload_vue_0
2020-01-24 11:46:14 -05:00
guerler
692571d4af
Restore section filter in toolshed installer
2020-01-24 11:21:34 -05:00
guerler
d40c26dedb
Verify that no duplicate entries have been added to the workflow list
2020-01-24 11:21:34 -05:00
guerler
107887721d
Fix select field style
2020-01-24 11:21:34 -05:00
guerler
7458377a00
Remove legacy output option markup in workflow panel template
2020-01-24 11:21:34 -05:00
guerler
e2b204a1bd
Strip legacy helpers for workflow editor config, use side panel component
2020-01-24 11:21:34 -05:00
guerler
cb4f55d490
Add right workflow editor panel component
2020-01-24 11:21:34 -05:00
guerler
a99e5388c2
Use workflow update endpoint to rename workflow
2020-01-24 11:21:34 -05:00
guerler
d7b7acefff
Iterate editor attribute template in workflow editor, import tags
2020-01-24 11:21:34 -05:00
guerler
739f252ea0
Create vue template draft from right panel markup in editor mako
2020-01-24 11:21:34 -05:00
guerler
d6e57948e4
Add workflow details panel vue component
2020-01-24 11:21:34 -05:00
John Chilton
3176c6770b
Modify language for composite upload request.
...
xref https://github.com/galaxyproject/galaxy/pull/9167#pullrequestreview-346759554
2020-01-22 12:20:58 -05:00
guerler
06e74d6ad0
Merge branch 'dev' into generalize_side_panel
2020-01-22 12:20:10 -05:00
John Chilton
224a92aaa2
Allow Select2 dropdown width to exceed parent DOM width.
...
Seems to work for all components using it.
xref https://github.com/galaxyproject/galaxy/pull/9167#issuecomment-577283724
2020-01-22 12:20:04 -05:00
John Chilton
80d36f4c1a
Fix upload tab ids for Selenium tests.
2020-01-22 12:15:35 -05:00
John Chilton
9268fd42a6
Merge _uploadFtp functionality between collection and default uploads.
2020-01-22 12:15:35 -05:00
John Chilton
388b722607
Fix off by one error in lazy-limited.js
2020-01-22 12:15:35 -05:00
John Chilton
6cae6307e5
Eliminate lazy-limited differents between regular and collection upload.
...
- Let the components just think about this abstractly and move the logic into the common base class.
- Add tests!
2020-01-22 12:15:35 -05:00
John Chilton
58ea8b3804
Eliminate more duplication between default and collection rows.
2020-01-22 12:15:35 -05:00
John Chilton
5edf3a4ebf
Refactor upload collection/default row handling to share status handling.
...
Removes some divergence.
2020-01-22 12:15:35 -05:00
John Chilton
dfdc8f636c
Add unit tests for UploadModal.
2020-01-22 12:15:35 -05:00
John Chilton
7cb827857e
More unit tests for upload stuff.
2020-01-22 12:15:35 -05:00
John Chilton
69f2c2363a
Rebase into Default.vue commit.
2020-01-22 12:15:35 -05:00
John Chilton
5807e13ec7
Migrate upload default-view to new Default.vue.
...
Rework a lot of Collection.vue into shared mixin. There was a lot of duplication in there (all my fault).
2020-01-22 12:15:35 -05:00
John Chilton
7bcfbf2474
Migrate upload rules-input-view to RulesInput.vue.
2020-01-22 12:15:35 -05:00
John Chilton
19d4e14035
Progress on upload unit testing.
2020-01-22 12:15:35 -05:00
John Chilton
1199e36ef1
Migrate upload collection-view into new Collection.vue
2020-01-22 12:15:34 -05:00
John Chilton
8373c090f4
Migrate upload composite-view to new Composite.vue
...
Fill out Select2.js as part of that.
2020-01-22 12:15:34 -05:00
John Chilton
836eeb5f4f
Fix anonymous users..
2020-01-22 12:15:34 -05:00
John Chilton
083ca32cc6
Fix title...
2020-01-22 12:15:34 -05:00
John Chilton
d93c295994
Migrate upload tabs Backbone to Vue and b-tabs.
2020-01-22 12:15:34 -05:00
John Chilton
aae0cff4d9
no-enforce-focus needed for select2 to work properly
2020-01-22 12:15:34 -05:00
John Chilton
d51662dbe0
Migrate upload-view to new UploadModal.vue using b-modal
2020-01-22 12:15:34 -05:00
John Chilton