Commit Graph
15 Commits
Author SHA1 Message Date
Dave Bouvier 06c2434f6e Fix functional tests for library templates. 2014-04-25 10:41:53 -04:00
Dave Bouvier b8981f4659 Fix library template functional tests. Revert change to user info tests that was breaking library template tests. 2014-04-22 12:58:42 -04:00
John Chilton d6f8620f62 More work on eliminating references to test_db_util.sa_session.
... tweaked styling of several functional tests (the non-toolbox,datamanager,workflow,api functional tests) along the way - mostly PEP-8 fixes and eliminating * imports. Did not modify tests which do not pass - but did not in the source where they fail inside a TODO.
2014-01-11 22:40:18 -06:00
Carl Eberhard 6f33240584 fix to rusted display_string in TestLibraryFeatures.test_100_add_ldda_to_folder3 2012-08-07 15:57:13 -04:00
Greg Von Kuster 041f54bcb1 Fix for data library functional test. 2011-12-06 08:56:21 -05:00
Greg Von Kuster 39d74e80b3 Fix some broken functional tests and fixes for deleting multiple data libraries and resetting the password for multiple users. Fixes issue # 678. 2011-12-05 09:58:36 -05:00
Greg Von Kuster 023880b713 Data library fixes and improvements:
1. Fix a bug that included the option for a regular user to upload a directory of files when the config setting existed, but the user's directory did not exist.  Instead of throwing an exception, an attempt to create the directory will now be done.  If the attempt fails, the option to "Upload a directory of files" will not be included in the select list on the upload form.

2. When browsing a data library, only display the check boxes and the actions to perform on multiple selected datasets if library datasets are displayed.

3. Clean up the behavior when performing an action on multiple library datasets.  Instead of throwing an error and not allowing the action on any of the datasets if the user is not authorized to perform the action on 1 of them, all "unauthorized" datasets are now left alone and the action is performed on all datasets for which the user is authorized to perform the action.  Appropriate messages detail what occurred.

4. Allow regular users to delete multiple datasets returned from library dataset searches based on the behavior described in 3 above.

5. Do not include the "Select datasets for import into selected histories" option in the actions pop-up menu at the data library level if the library's root folder doesn't contain any accessible datasets.  Make behavior the same for folder popup menus.

6.  Add a new LibraryFolder.active_datasets mapper and eliminate the incorrect LibraryFolder.active_library_datasets property.  Callers of the incorrect property now use the mapper.

7. Eliminate the incorrect LibraryFolder.active_datasets property.

8. Fix the queries in the library_common controller's active_folders_and_lddas() and activable_folders_and_lddas() methods to return library_datasets instead of lddas, and rename the methods to be active_folders_and_library_datasets(0 and activatable_folders_and_library_datasets() respectively.

9. Fix bug where regular user could never see deleted library items when toggling show / hide deleted items.

10. Fix functional test for uploading directories of files to a library folder.  The test generally failed because not enough time would elapse before checking if the files uploaded.  The check is now performed in a later method in the test script, hopefully allowing for enough time to pass.

11. Functional test code clarifications for the browse_library() test method.
2011-02-04 16:16:00 -05:00
Greg Von Kuster 11957ed5fa Fixed as many of the issues as could be found throughout the framework due to the migration of FormValues.content from a list to a dictionary in change set 4744 b73ad3906e24. 2010-12-15 17:00:29 -05:00
Ramkrishna Chakrabarty b34ef29442 Adding a 'name' attribute in the field dict for form_definitions. In the 'form_values'
table, the 'content' column is now a JSON dict instead of a list. Made appropriate code changes.
2010-12-13 17:29:23 -05:00
Greg Von Kuster d354a1ce35 Abstract the code supporting data library templates so templates can be used in sample tracking as well. These templates now provide support for handling information about sample runs. A RequestType can have a single association to a Run, with the run details template made available to all samples. A Sample can have many associations to Runs. 2010-12-09 14:52:27 -05:00
Greg Von Kuster 0b97c298c1 Fix for rendering hidden widget field values associated with library templates whose fields are displayed on the upload form when importing a dataset from the current history. Added new functional test to cover behavior. 2010-09-29 12:39:39 -04:00
Greg Von Kuster 858349cb63 Rewrite the functional tests that cover all Galaxy forms related behavior. Clean up / fix bugs in several sample run request templates. Fix a bug introduced in change set a8cdece11998 which incorrectly generated selected options in a select list in the data library framework. 2010-09-22 16:38:49 -04:00
Greg Von Kuster f7334104a0 Move the upload_option (ie., file, directory, filesystem paths, import from history) into a select list on the data library upload form. Selecting an upload_option now performs a refresh_on_change on the upload form so that any form contents entered before selecting the option are now retained. Improvements and bug fixes were made throughout the pieces of the framework that support this.
Major improvements and very significant code cleanup to the entire functional test framework was done in this change set as well.
2010-09-17 15:23:58 -04:00
Greg Von Kuster f434b53942 Fix for uploading a library dataset inheriting a template containing a CheckboxField. Fix get_html() methods I broke in form_builder.py - unit tests houls passs again. Add more robust functional tests for testing library temple behavior. 2010-09-03 16:43:10 -04:00
Greg Von Kuster 05a98889e5 Library template improvements and miscellaneous fixes:
1. Add support for handling inherited library temnplates that include all supported field types ( AddressField, CheckboxField, SelectField, TextArea, TextField, WorkflowField ) to the upload form for library datasets.  New userAddress objects can now be created on the upload forms.

2. Improve the UI for selecting tempaltes for library items - it is now clear that the displayed template is not useable since it is disabled and a message is displayed.

3. Automatically inherit template contents from  parent for inherited templates.

4. Fix the AddressField UI to display the required fields for rendered html.

5. Add new test_library_templates.py functional test script.

.
2010-09-02 13:59:17 -04:00