Commit Graph
9446 Commits
Author SHA1 Message Date
Ahmed Awan bb24c23650 [24.0] History Multiview panel shows pinned histories on top
Fixes https://github.com/galaxyproject/galaxy/issues/18082
2024-05-03 10:32:31 -05:00
Dannon Baker 97efceafce Explicitly specify that outputFormat is a string -- this fixes tsc getting confused below when reassigning 2024-04-26 11:25:55 -04:00
Dannon Baker fe8ecb12bf Fix usage of citations_export_message when config is not loaded yet 2024-04-26 09:42:58 -04:00
Dannon Baker d3c763821b Fix CitationsList default prop. 2024-04-26 09:17:37 -04:00
Martin Cech 625cd8a9c6 Merge pull request #18033 from martenson/storage-details
[24.0] clarify the object store relocate functionality
2024-04-23 17:50:16 +02:00
Martin Cech b8c39a57df change language to relocate 2024-04-22 09:58:02 -07:00
mvdbeek 5648478e6d Adjust schema for collection elements of collections that aren't populated 2024-04-22 11:52:18 +02:00
Martin Cech 03111fad43 move the link from heading to the body and change to a button
- add minor text adjustments
- close the modal when clicking on the currently selected storage
2024-04-19 13:23:10 -07:00
John Davis ee64fc414d Update client valid tag regex 2024-04-18 22:40:18 -04:00
Dannon Baker b648c60dd4 Add a link to histories list in history import message for situations where you import without a history visible (e.g. published page view) 2024-04-18 12:37:45 -04:00
davelopez af2c2ed314 Set active check for notifications every 30 seconds 2024-04-17 16:19:13 +02:00
davelopez 91f34ac76c Reduce notifications polling frequency 2024-04-17 16:01:41 +02:00
Marius van den Beek 88dcb255b0 Merge pull request #17990 from ahmedhamidawan/use_select_many_in_tool_form
[24.0] Use the new column-select component in `FormData` for multiple select
2024-04-17 12:10:20 +02:00
Dannon Baker 3e89eeb459 Preserve surrounding whitespace when localizing complex nodes 2024-04-16 16:24:22 -04:00
Ahmed Awan f6e19c39f2 remove double ternary op 2024-04-16 11:16:38 -05:00
Ahmed Awan 26844a1eab fix jest fail caused by FormSelection.props.options == null 2024-04-16 09:07:37 -05:00
Ahmed Awan 0f8c379c48 Use the new column-select component in FormData for multiple select
This allows for easier multiselect with added ease for range select.
Fixes https://github.com/galaxyproject/galaxy/issues/17947
2024-04-16 09:07:37 -05:00
Martin Cech 3a35c820b5 Merge pull request #17980 from dannon/history-import-feedback
[24.0] History import - show user feedback on completion.
2024-04-12 23:10:17 +02:00
Dannon Baker 136ae7544c In history view, add info message for when history import is complete 2024-04-12 14:53:43 -04:00
davelopez 9cd781e12f Filter workflow outputs by type in markdown directives 2024-04-12 14:52:58 +02:00
mvdbeek 32327ae496 Merge branch 'release_23.2' into release_24.0 2024-04-12 12:06:45 +02:00
Martin Cech f6a45265cb Merge pull request #17964 from dannon/fix-report-image-display
[24.0] Show dataset image in workflow_outputs display listing.
2024-04-11 22:47:57 +02:00
Martin Cech 346b85fe23 Merge pull request #17972 from mvdbeek/fix_new_workflow_save
[23.2] Set from_tool_form: true when saving new workflow
2024-04-11 21:04:08 +02:00
Dannon Baker f2ef679e1e Use standard buttons for history import/switch in the view interface 2024-04-11 14:46:20 -04:00
mvdbeek 0ec987faa1 Set from_tool_form: true when saving new workflow
Fixes https://github.com/galaxyproject/galaxy/issues/17963 and https://github.com/galaxyproject/galaxy/issues/17970
2024-04-11 19:36:01 +02:00
davelopez 7e2bd277b4 Fix message input type for notifications
Otherwise, is not possible to use line breaks in the message which are supported by the API with full markdown support.
2024-04-11 15:31:57 +02:00
davelopez 4551d50dda Fix notification display time
Prioritize the publication date over the creation date to accurately reflect possible scheduled notifications
2024-04-11 15:12:44 +02:00
Dannon Baker ea455b3823 Reuse datasetimage display for appropriate datatypes
Minor tweaking of pre
2024-04-11 07:45:44 -04:00
Dannon Baker dd9af46eff Document isSubType 2024-04-11 07:45:44 -04:00
Dannon Baker c15b6e0fd3 Allow abstract parent class lookup by classname for isSubType. 2024-04-11 07:45:44 -04:00
Dannon Baker 9291173c77 In HistoryDatasetDisplay markdown element, display images in iframe 2024-04-11 07:45:44 -04:00
mvdbeek 8d62ebade2 Fix toolform not updating for version changes in wf editor
This only happens for non-ts tools which don't have the version in their
tool id.
2024-04-08 17:16:55 +02:00
Laila Los 7b8866495f fix computed setter infinite loop 2024-04-05 15:21:41 +02:00
mvdbeek 0bb2925a05 Make sure step removal also resets mapOver state
Fixes https://github.com/galaxyproject/galaxy/issues/17906
2024-04-05 13:33:18 +02:00
Aysam Guerler f3377c44d3 Merge pull request #17904 from mvdbeek/fix_losing_markdown
[24.0] Fix lost reports when switching workflow versions
2024-04-05 14:00:30 +03:00
Marius van den Beek e72ae4937d Merge pull request #17907 from ahmedhamidawan/dont_save_wf_without_informing
[24.0] Do not save workflow on Run without user confirmation
2024-04-05 09:27:36 +02:00
Ahmed Awan ad6af8d1b2 [24.0] Do not save workflow on Run without user confirmation
This adds a modal when the user runs a workflow with changes, that asks for user confirmation on whether to proceed without saving changes or to save changes and then proceed. Currently, we _always_ save the workflow when it is run (even if there are no changes at all).

Fixes https://github.com/galaxyproject/galaxy/issues/17903
2024-04-04 15:33:55 -05:00
mvdbeek 8630e3b343 Fix lost reports when switching workflow versions
We serialize workflow.reports, but we were only setting it on the
workflow instance if the markdown editor emits it.

Fixes a part of https://github.com/galaxyproject/galaxy/issues/17903
2024-04-04 18:41:34 +02:00
Martin Cech cd7de5511d disable instead of hiding 2024-04-04 09:39:23 -07:00
Martin Cech 4f331e4a70 do not show copy button when editing 2024-04-03 10:16:53 -07:00
Marius van den Beek 5548b11b0c Merge pull request #17886 from ahmedhamidawan/fix_history_has_owner_function
[24.0] Fix hasOwner function for histories in client
2024-04-03 11:15:52 +02:00
John Davis 098ec92a01 Merge pull request #17856 from davelopez/24.0_fix_archived_histories_mixing_with_active
[24.0] Fix archived histories mixing with active in histories list
2024-04-02 14:32:49 -04:00
Ahmed Awan 09f77f4d4c [24.0] Fix hasOwner function for histories in client
The `hasOwner` function in `api/index.ts` was checking:
```
return "user_id" in history;
```

whereas, it also needed to check:
```
return "user_id" in history && history.user_id !== null;
```

because we assume histories (summaries) initally fetched for the `historyStore` without user_id are owned by the current user, but the key is still present in the backend return.

This was causing a really troublesome bug in the `HistoryScrollList` found in the history selector modal, where we could constantly keep fetching `api/histories/count` since we didn't have the expected no. of histories loaded in the component; because `historiesProxy` (which only contains owned histories) would end up being empty.
2024-04-02 12:19:50 -05:00
Marius van den Beek 91b93ebaec Merge pull request #17865 from martenson/config-type
[24.0] wait for config to load with user prefs options
2024-03-29 22:24:25 +01:00
Dannon 2bba32d27c Merge pull request #17861 from ElectronicBlueberry/embed-download-fix
[24.0] Embed download fix
2024-03-28 19:54:19 -05:00
Martin Cech aa00cb8aa8 config is not defined yet on load 2024-03-28 14:02:50 -07:00
Marius van den Beek 30bf8ebc50 Merge pull request #17847 from ahmedhamidawan/tool_panel_slow_computed 2024-03-28 21:13:58 +01:00
davelopez d34f7582c5 Add show_archived per code review 2024-03-28 19:52:11 +01:00
Ahmed Awan 4f0f753097 set tool search worker to null to remove references while unmounted 2024-03-28 13:40:59 -05:00
Laila Los 3439265366 replace to with href 2024-03-28 17:21:31 +01:00