Commit Graph
264 Commits
Author SHA1 Message Date
Jeremy Goecks 2490f2e9c1 Update functional tests to be compatible with 0d1d62b8be2e 2012-01-17 09:05:11 -05:00
Nate Coraor 3c5c6ce091 Fix for some output changes I made to functional tests. 2011-12-08 10:14:29 -05:00
Nate Coraor 44344fe2e0 Fix the dataset controller's stderr method and add one for stdout. Link to
both from the dataset info page.  The functional tests will now provide output
of these on tool test failure.  The functional tests can now use
tool_dependency_dir as well.
2011-12-06 11:29:02 -05:00
Greg Von Kuster 39d74e80b3 Fix some broken functional tests and fixes for deleting multiple data libraries and resetting the password for multiple users. Fixes issue # 678. 2011-12-05 09:58:36 -05:00
Nate Coraor cbb7111ea9 Bugfix for tool tests without attributes. 2011-09-02 10:16:07 -04:00
John Chilton 9ac9830a49 Small whitespace fix for bug introduced by last merge. 2011-08-31 11:31:23 -05:00
John Chilton eaeb4d7c20 Merged latest galaxy-central. 2011-08-31 11:08:30 -05:00
Ross Lazarus 5b2e7947ea Fixed sam_merge.xml to call Picard MergeSamFiles.jar so metadata can be propagated through to the new merged bam from all the individual files - the samtools version of merge would require this to be done separately and passed in with the -h option whereas Picard does it automatically. Added one more test. Interesting that the test for that tool has been failing to correctly pass metadata but passing the buildbot anyway. Thanks to Camille Stephan for pointing out the bug.
Changes to rgManQQ so the user can obtain a decent pdf image. When millions of points are plotted, these are humongous so GS is called to compress the resulting pdf and they are now of reasonable size. PDF's are now linked from the thumbnails. Some minor fiddling with point size on the Manhatten plots so the intersting ones are a little more obvious.

Minor tweak to twilltestcase.py so composite file components are copied correctly to the directory specified by GALAXY_TEST_SAVE. This makes updating test artefacts much simpler because running tests with GALAXY_TEST_SAVE pointing somewhere will now save every tested output file.
2011-08-04 12:43:30 +10:00
Nate Coraor 0756941512 Move a number of dataset-related methods from the root controller to the dataset controller and encode their ids. Also add user disk usage accounting. 2011-07-26 13:30:07 -04:00
John Chilton 10129b8a17 Merged latest galaxy-central changes. 2011-07-25 13:13:17 -05:00
Kanwei Li 1abb36734a Escaping in tests should be more specific 2011-06-17 16:45:25 -04:00
John Chilton ce6aeb31c3 Enhancements to Galaxy's functional testing framework as outlined in issue 490. https://bitbucket.org/galaxy/galaxy-central/issue/490/enabling-iterative-test-driven-development 2011-05-17 15:29:02 -05:00
Daniel Blankenberg 3cbead3137 Add a "contains" compare type to functional tests. Enables simple checking for substrings in a test output file, on a line-by-line basis. TODO: Enhance to enforce order. 2011-05-10 20:11:52 -04:00
Kelly Vincent d6deb67bf2 Added -h flag to samtools view command in functional test's bam to sam conversion so that it keeps the header 2011-04-22 14:58:44 -04:00
Ross Lazarus ee6bd2cf46 Changes to allow all test outputs generated by twill to be saved to a folder pointed to by
an environment variable "GALAXY_TEST_SAVE" if defined before running functional tests
If the environment variable is empty, all tests procede as usual and test outputs are deleted
without saving
2011-04-14 08:09:48 -04:00
Greg Von Kuster 8ba7de4c8b Improved checking to determine if a bam file is sorted. If the version of samtools being used is 0.1.13 or newer, determination of bam sorting is now much more robust. Add a new functional test to the test_library_features script that tests uploading a library_dataset (where the file is an unsorted bam file) using a combination of 'upload_paths' and 'link_to_files'. Rename the test-data file previously named 3.bam to now be named 3unsorted.bam to clarify that it is an unsorted bam file. 2011-03-23 12:18:57 -04:00
Greg Von Kuster e83efed183 Fixes in the user controller:
1. Eliminate some long-standing security issues
2. Encode all object ids - many were not being encoded
3. Eliminate all unnecessary methods
4. Rewite several poorly written methods
5. Fix several bugs related to USER_INFO form definitions
2011-03-22 10:33:42 -04:00
Daniel Blankenberg c52ba62119 When using re_match comparison method in functional tests and line counts do not match, print out first 40 lines of the history file. 2011-03-16 22:27:15 -04:00
Greg Von Kuster 7640af8e06 Don't alter the contents of a file while uploading to a data library if using the filesystem_paths option. This partially resolves the issue where a supposedly sorted BAM file was being resorted upon upload to a data library when using this option. A better imlementation of determining whether a BAM file has been sorted (so that it does not get resorted) remains to be done. 2011-03-15 09:38:29 -04:00
Greg Von Kuster df6f94b1d0 Per request from Peter Cock, turn the "Copy data into Galaxy?" check box into a select list that clarifies the behavior. The default is to copy files into Galaxy. 2011-03-11 14:56:11 -05:00
Greg Von Kuster c650958915 Apply a corrected version of the patch from Peter Cock that flips the  "Preserve directory structure?" setting when uploading library datasets from filesystem paths. 2011-03-11 10:01:54 -05:00
Greg Von Kuster 0e79bf2632 Add a checkbox to the Create Group page that if checked will create a new Role with the same name. This provides a similar feature the the existing checkbox on the Create Role page.
However, the behavior is now changed such that new associations are created when the checkbox is checked whereas before, only the Group or Role objects with the same name were created, but not associated with anything.

This code was very old, so I did some cleanup / improvements as well.  Functional tests enhanced to reflect changes.
2011-03-10 15:48:00 -05:00
Greg Von Kuster a5ea34e29a Add functional tests to cover some recent new library features, and a couple of miscellaneous UI improvements. 2011-03-09 14:50:54 -05:00
Nate Coraor a221548e8f An uninitialized value in R's PDF driver was causing it to sometimes randomly add a few elements to PDF outputs. The bug has been fixed in the buildbot environment and these changes account for that fix. 2011-03-08 11:17:57 -05:00
Nate Coraor 19236474c4 Cause lines_diff on pdf test outputs to only count the lines of a pdf which are not already ignored. 2011-03-03 12:21:22 -05:00
Nate Coraor e1ea63eb9a When comparing bam files in the test framework, convert them to sam for comparison. 2011-02-23 14:53:54 -05:00
Kanwei Li 4660370320 Copy datasets feature:
- Fix functional tests
- Populate previously selected target history if attempt fails
2011-02-22 17:14:16 -05:00
Guruprasad Anada ff7e8fe2e0 Fixed functional tests for the following tools: histogram, estimate indel rates, compute q-values, kernel pca. 2011-02-22 12:37:06 -05:00
Greg Von Kuster 023880b713 Data library fixes and improvements:
1. Fix a bug that included the option for a regular user to upload a directory of files when the config setting existed, but the user's directory did not exist.  Instead of throwing an exception, an attempt to create the directory will now be done.  If the attempt fails, the option to "Upload a directory of files" will not be included in the select list on the upload form.

2. When browsing a data library, only display the check boxes and the actions to perform on multiple selected datasets if library datasets are displayed.

3. Clean up the behavior when performing an action on multiple library datasets.  Instead of throwing an error and not allowing the action on any of the datasets if the user is not authorized to perform the action on 1 of them, all "unauthorized" datasets are now left alone and the action is performed on all datasets for which the user is authorized to perform the action.  Appropriate messages detail what occurred.

4. Allow regular users to delete multiple datasets returned from library dataset searches based on the behavior described in 3 above.

5. Do not include the "Select datasets for import into selected histories" option in the actions pop-up menu at the data library level if the library's root folder doesn't contain any accessible datasets.  Make behavior the same for folder popup menus.

6.  Add a new LibraryFolder.active_datasets mapper and eliminate the incorrect LibraryFolder.active_library_datasets property.  Callers of the incorrect property now use the mapper.

7. Eliminate the incorrect LibraryFolder.active_datasets property.

8. Fix the queries in the library_common controller's active_folders_and_lddas() and activable_folders_and_lddas() methods to return library_datasets instead of lddas, and rename the methods to be active_folders_and_library_datasets(0 and activatable_folders_and_library_datasets() respectively.

9. Fix bug where regular user could never see deleted library items when toggling show / hide deleted items.

10. Fix functional test for uploading directories of files to a library folder.  The test generally failed because not enough time would elapse before checking if the files uploaded.  The check is now performed in a later method in the test script, hopefully allowing for enough time to pass.

11. Functional test code clarifications for the browse_library() test method.
2011-02-04 16:16:00 -05:00
Greg Von Kuster 5f9f45a068 Several data library improvements:
1. Enhance importing library dataset into the current history by now allowing the user to select from a list of existing histories or create a new named history ( similar to copying datasets ).  This feature is available for a specific library dataset, a folder ( or root folder ), when selecting multiple datasets from in a library,  and on the results page for searched library datasets.

2. Add Brad Chapman's latest patch for fixing the lucene search implementation

3. Eliminate searches on dataset state for both whoosh and lucene searches

4. Clarify the objects being searched in the regular search and advanced search boxes in the data libraries grids.

5. Add the ability to perform certain actions on 1 or more selected library datasets on the results page for searched library datasets.

6. Add a "select all" checkbox to the browse_library.mako template.

7. Fixed library functional tests accordingly.
2011-01-31 16:41:03 -05:00
Ramkrishna Chakrabarty 7e3387aabd Request type now requires at least one sample state
Added validation checks for request types with only one sample state
Bug fixes
2011-01-28 10:24:55 -05:00
Ramkrishna Chakrabarty b72c2406c8 Fixed user_info and sample_tracking functional tests.
Refactored getting form values into a separate method in controller.py.
Changed request type access into a restrict permission.
Added a check when sequencer_types are not loaded.
2011-01-04 07:11:12 -05:00
Greg Von Kuster 5e2d7e83f1 Eliminate the use of the 'editing_samples' flag by adding the code needed to add new samples without calling the edit_samples method or mako template. Decoupling the different features makes them much cleaner and easier to maintain. 2011-01-03 11:11:00 -05:00
Ramkrishna Chakrabarty 7858868650 First pass of the new sequencer_type & sequencer framework
- sequencer table now populated with the unique sequencer in the request_type table
- sequencer_type is introduced which defines a sequencer
- support for sequencer (create, delete, edit)
- added support for a simple sequencer for backward compatibility
- added support for Solid sequencer
- tweaked the request_type api methods. removed the sequencer login info.
2010-12-20 10:50:50 -05:00
Greg Von Kuster 11957ed5fa Fixed as many of the issues as could be found throughout the framework due to the migration of FormValues.content from a list to a dictionary in change set 4744 b73ad3906e24. 2010-12-15 17:00:29 -05:00
Ramkrishna Chakrabarty b34ef29442 Adding a 'name' attribute in the field dict for form_definitions. In the 'form_values'
table, the 'content' column is now a JSON dict instead of a list. Made appropriate code changes.
2010-12-13 17:29:23 -05:00
Greg Von Kuster 87c645dc0e Rename the sequencer controller to be named request_type. 2010-12-09 15:59:14 -05:00
Greg Von Kuster d354a1ce35 Abstract the code supporting data library templates so templates can be used in sample tracking as well. These templates now provide support for handling information about sample runs. A RequestType can have a single association to a Run, with the run details template made available to all samples. A Sample can have many associations to Runs. 2010-12-09 14:52:27 -05:00
Ramkrishna Chakrabarty 52be644eb6 sample tracking functional tests now checks if all library sub-folders show up in the selectfield when selecting a folder for a sample 2010-11-30 13:59:13 -05:00
Ramkrishna Chakrabarty c22691a2af Forms refactoring first pass.
sample tracking data transfer selection UI css bug fixed
2010-11-23 00:00:03 -05:00
Ramkrishna Chakrabarty d220a8c791 sample tracking functional tests
- data transfer selection, renaming initiation
- new address at request creation
- request lifecycle, rejection
Fixed ui bugs
2010-11-19 10:52:49 -05:00
Greg Von Kuster efed83a828 Move the sequencer interface ( RequestType ) components from the requests_admin controller to a new sequencer controller. 2010-11-19 10:14:08 -05:00
Greg Von Kuster c3afe4cb34 Code fixes and cleanup for adding and viewing sequencer configurations ( RequestTypes ). Move the request_type templates from the requests folder to their own request_type folder. Add the ability to edit sequencer configurations. 2010-11-18 14:16:39 -05:00
Ramkrishna Chakrabarty a244683705 Fixed naming of the library selectfield for sample operations
Fixed the broken popup menu in the data transfer grid
Fixed the missing required/optional field info in the request form
2010-11-17 16:19:11 -05:00
Ramkrishna Chakrabarty b8652ecc4e - added the change data library sample operation functional test.
- renaming dataset now checks for incorrect filename characters
- fixed bugs
2010-11-17 11:33:54 -05:00
Greg Von Kuster c3c7c89c5d More miscellaneous Sample Tracking cleanup and bug fixes, move supported form_builder field types from form_builder.BaseField to Request.model and Sample.model. 2010-11-17 10:25:12 -05:00
Ramkrishna Chakrabarty 394b01dfdb More tests added to sample tracking functional tests 2010-11-15 12:21:35 -05:00
Greg Von Kuster 212a7e65cf First pass at cleaning up the Galaxy Form Definition UI ( forms controller still needs a re-write ). 2010-11-15 11:46:39 -05:00
Ramkrishna Chakrabarty 34499ddbcf More changes to sample tracking functional tests
- assign target data library, editing samples, assign sample barcode
2010-11-12 16:37:36 -05:00
Kanwei Li 78d4d8ed8b Upgrade to Mako 0.4.1 and fix failing tests due to entity escaping. Improve error message for checking strings in history. 2011-06-17 15:23:28 -04:00