Commit Graph
1962 Commits
Author SHA1 Message Date
davelopez a66ec96dfe Prevent deletion of user-defined object stores
Skips the physical file removal process for datasets stored in user-defined object stores. These storage locations cannot be resolved by the cleanup script, so the database records are updated while the external files remain intact to prevent potential errors or data loss.
2026-06-08 12:41:24 +02:00
Dannon Baker c57aaeb96c Drop --frozen-lockfile from prebuilt client install
No root pnpm-lock.yaml is shipped, so `pnpm install --frozen-lockfile`
fails with ERR_PNPM_NO_LOCKFILE (hit locally via planemo). The dev
branch is unaffected -- client/pnpm-lock.yaml exists.
2026-04-16 17:30:10 -04:00
mvdbeek 8ac4b81b79 Fix repo metadata persistence in fix_tool_config_paths.py 2026-03-09 15:09:45 +01:00
Matthias Bernt 11505ae687 add zero-ice constraint
its an implicit dependency of omero py
2026-01-29 13:00:44 +01:00
John Davis b0e8306de6 Merge pull request #20819 from ccoulombe/refactor/cleanup-datasets
Refactor/cleanup admin_cleanup_datasets.py script
2026-01-27 19:06:52 -05:00
John DavisandNicola Soranzo 4f66c00124 Update scripts/cleanup_datasets/admin_cleanup_datasets.py
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
2026-01-27 15:16:04 -05:00
John Davis 8a40ef19fb Format 2026-01-27 11:51:12 -05:00
John Davis 01a3f2707b Do not change existing behavior; raising error is correct 2026-01-27 11:50:36 -05:00
John Davis 5ffdf789c1 Remove redundant join criteria 2026-01-27 11:49:22 -05:00
John Davis 3a59617837 Restore old comment 2026-01-27 11:30:40 -05:00
John Davis cce6f59c1c Do not use aliased on models for readability: just import them 2026-01-27 11:28:27 -05:00
John Davis 1bd316e951 Use == false() instead of is_(False) 2026-01-27 11:20:42 -05:00
Nicola Soranzo 17003e8d00 Apply 2026 black style 2026-01-20 10:25:45 +00:00
Nicola Soranzo eb9fde1dcd Drop support for Python 3.9 2026-01-19 18:39:16 +00:00
Dannon Baker f8db1d03c1 Update build system for pnpm
Replaces yarn with pnpm throughout the Makefile and common_startup.sh.
The startup script now installs pnpm via conda, corepack, or npm
depending on the environment.
2026-01-12 16:49:17 -05:00
Nicola Soranzo 959f4a5aa4 Clean up code with pyupgrade
by runnig:

```shell
make pyupgrade
ruff check --fix .
make format
```

Also update ruff configuration to:
- Enable UP006 and UP035 error codes for PEP 585 type annotations
- Ignore UP045 for the packages which need to stay compatible with Python 3.8
- Add tool-util-models paths to those that need to stay compatible with Python 3.8
2026-01-06 22:25:34 +00:00
Nicola Soranzo fc7d1dee35 Switch galaxyproject package index to `--extra-index-url`
so that `uv pip install` treats it with higher priority:

https://docs.astral.sh/uv/concepts/indexes/#-index-url-and-extra-index-url

Note that `pip` treats all indexes with the same priority:

https://pip.pypa.io/en/stable/cli/pip_install/#finding-packages

Allows uv to install the Python 3.14 wheel of pysam==0.23.3 from
wheels.galaxyproject.org instead of trying to build it from the source
package from PyPI.
2025-12-24 15:15:11 +00:00
Nicola Soranzo 176382b6be Install pip module if missing 2025-12-24 15:15:10 +00:00
mvdbeek b55ae26068 Add toolshed metadata fixing script
Updates repository_metadata.tools with new and correct file locations.
The test toolshed moved around `file_path` multiple times since its
inception, and old revisions might point at old location. This is a
simple script that fixes the locations. It has a dry run mode that I've
run successfully:

```
----------------------------------------------------------------------
Dry run complete - no changes made to database
======================================================================
SUMMARY
======================================================================
Total RepositoryMetadata records processed: 25414
RepositoryMetadata with tools: 22497
Total tools examined: 40470
Tools with correct paths (unchanged): 3898
Tools with paths updated: 36572
  - Tool file exists on disk: 33297
  - Tool file missing (removed in later changeset): 3275
Tools with path construction errors: 0
======================================================================
```
it also write out json files for each repository as backups should
this be needed.

Closes https://github.com/galaxyproject/galaxy/issues/21454
2025-12-15 12:09:23 +01:00
Nicola Soranzo f20306b03b Shellcheck fixes 2025-10-29 18:45:26 +00:00
Nicola Soranzo 6cf9d49c8a Install uv into `$GALAXY_CONDA_ENV` 2025-10-29 18:45:25 +00:00
Nicola Soranzo ae62f129c6 Reduce command duplications 2025-10-29 18:45:25 +00:00
Arash e4f6aa39e9 Enhance ensure_prereqs function to use 'uv' for pip list if available 2025-10-29 12:45:46 +00:00
Arash 137928e8fd Streamlines wheel + conditional dependency setup 2025-10-29 12:45:43 +00:00
Arash 2409312f8c Makes uv optional with pip fallbacks 2025-10-29 12:45:42 +00:00
Arash 478b88a7d4 Enhance package management by integrating 'uv' for faster installation and virtual environment creation across scripts 2025-10-29 12:45:42 +00:00
Dannon Baker 5b4b3892f9 Use corepack to enable yarn in common_startup.sh 2025-10-22 12:49:20 -04:00
mvdbeek b488cf2694 Use nodejs-wheel to install node 2025-09-27 09:17:12 +02:00
Charles Coulombe f14f34dca7 Removed unsused imports 2025-08-26 13:18:46 -04:00
Charles Coulombe 85d8e6a78f Added --no-send option, to allow not sending an email upon deletion 2025-08-26 10:29:34 -04:00
Charles Coulombe f0e63ff652 Added state to email subject. Differentiate between the information and the actual deletion email 2025-08-25 15:38:57 -04:00
Charles Coulombe 651426ae39 Updated _get_tool_id_for_hda function to be more readable but mainly compatible with sqlalchemy 2.x 2025-08-20 08:57:04 -04:00
Charles Coulombe 860e2cda72 Refactored and updated administrative_delete_datasets function to be more readable but mainly compatible with sqlalchemy 2.x 2025-08-19 19:50:04 -04:00
Charles Coulombe 3904721208 Fixed query results mapping for compatibility with sqlalchemy 2.x 2025-08-19 19:01:31 -04:00
Charles Coulombe b6f5553615 Format with 3 decimals and display seconds 2025-08-19 11:06:35 -04:00
Nicola Soranzo 7f89e0eab9 Code cleanups from pyupgrade
Found by running:

```
make pyupgrade
ruff check --fix .
ruff check --preview --unsafe-fixes --select=F401 --fix .
make format
make update-client-api-schema
```

The bulk of the changes are replacements of typing deprecated aliases
such as `Dict` and `List` with the standard library classes. These
aliases became redundant in Python 3.9 when the corresponding
pre-existing classes were enhanced to support `[]`, see
https://docs.python.org/3/library/typing.html#deprecated-aliases

Also:
- Update the `pyupgrade` Makefile target to use `--py38-plus` for the
  packages needed by Pulsar, including the new galaxy-tool-util-models
  package.
2025-07-31 11:17:22 +01:00
Charles Coulombe b08b68a889 Fix assertion on python version
Likely a typo, f-strings were introduced in 3.6
2025-07-24 21:15:28 -04:00
davelopez fdac8820a6 Merge release_25.0 into dev 2025-06-16 14:12:30 +02:00
mvdbeek 37c5e9978c Run make format 2025-05-09 10:53:43 +02:00
Nate Coraor 0ee30084cb Preserve loc permissions 2025-05-09 10:52:17 +02:00
Nate Coraor a5cc985765 Add optional empty directory pruning 2025-05-09 10:52:17 +02:00
Nate Coraor 5027e02bf3 Drop unused colors 2025-05-09 10:52:16 +02:00
Nate Coraor 8f5e50ddcf lint 2025-05-09 10:52:16 +02:00
Nate Coraor da2c8cb321 Drop symlink map, add support for tables that don't use path or dbkey columns. 2025-05-09 10:52:16 +02:00
Nate Coraor 6e79ca5922 Script to reorganize tool data to new layout, symlink logic is broken 2025-05-09 10:52:12 +02:00
Ahmed Awan b80f41816c Merge remote-tracking branch 'upstream/release_24.2' into dev 2025-03-31 10:35:43 -05:00
Nicola Soranzo cd11d22129 Merge branch 'release_24.1' into release_24.2 2025-03-28 17:55:45 +00:00
John Davis 1bf72997a0 Handle "%" character in raw SQL
This statement is prepared for SQLAlchemy but executed via psycopg2 in
the `pgcleanup.py` script. For psycopg2, the "%" character should be replaced
with %% (see docs
https://www.psycopg.org/docs/usage.html#passing-parameters-to-sql-queries).
SQLAlchemy already takes care of it automatically.
2025-03-28 15:08:21 +00:00
Nicola Soranzo 5fe5b53bf3 Fix new ruff 0.11.0 errors
Also:
- Add and fix type annotations
- Fix call of `object_store_allows_id_selection()` method
2025-03-15 17:12:02 +00:00
John Chilton 293ce59e3c Allow bootstrap_test_shed to bypass errors in tool shed 1.0 API.
Alternative to https://github.com/galaxyproject/galaxy/pull/18680 if that never gets deployed.
2025-03-03 20:39:27 -05:00