Commit Graph
7786 Commits
Author SHA1 Message Date
Laila Los 92bfdb20ff consolidate tool id shortening methods 2024-03-26 12:14:08 +01:00
John Davis cdb5110972 Merge pull request #17794 from jmchilton/helpful_job_errors
[24.0] Improved error messages for runtime sharing problems.
2024-03-25 13:35:18 -04:00
Marius van den Beek a4e3e4b533 Merge pull request #17756 from dannon/published_datasets_fixes
[24.0] Datasets list anonymous access and history link fixes.
2024-03-22 09:19:14 +01:00
Marius van den Beek 21213c0fdd Merge pull request #17762 from ahmedhamidawan/content_item_select_keyboard_unify
[24.0] Improve Shift+Click select in history panel and add it for `ContentItem` selector checkboxes as well
2024-03-22 09:11:51 +01:00
Ahmed Awan f4d958f057 fix failing jest because of added allItems prop 2024-03-21 17:33:01 -05:00
Ahmed Awan 1d20ce1d6d add a first and last item tracker to SelectedItems, remove Shift+Ctrl
Modified `SelectedItems` so that for range select, we track the first and last item in a range, along with the anchor. This way, we can persist with a selected range even if the user deselects a few items within it, since we keep track of the beginning and end of the range.

Also, added a CSS indicator to `ContentItem`s which actually indicates which item if the Shift+click range select anchor.
This also removes the `Shift+Ctrl+Click` multiple range select.
2024-03-21 17:06:05 -05:00
Ahmed Awan 20e4422656 fix seleniums and add jest for compact FilterMenus 2024-03-20 21:06:40 -05:00
Ahmed Awan 008b652c62 add a compact version of FilterMenu; no collapse on search
It groups `is` type boolean filters on one line, and in checkboxes.
Adding filters applies them immediately, and there is no search button.
2024-03-20 16:59:59 -05:00
Ahmed Awan 7996b03747 shorten placeholders for grid boolean is filters 2024-03-20 15:01:14 -05:00
Ahmed Awan 8522a0164e [24.0] Fix history filters taking up space in GridList
Add a popover version of the `FilterMenu` component. This can be enabled via the `isPopover` prop. Fixes https://github.com/galaxyproject/galaxy/issues/17618
2024-03-20 13:51:53 -05:00
Marius van den Beek 7cb1de5dd5 Merge pull request #17776 from itisAliRH/fix-workflow-anonymous-actions
[24.0] Fix anonymous user create, run and import workflows
2024-03-20 15:55:39 +01:00
Marius van den Beek 5714783a58 Merge pull request #17779 from davelopez/24.0_restore_histories_API_behaviour_for_keys_query
[24.0] Restore histories API behavior for `keys` query parameter
2024-03-20 09:12:52 +01:00
Martin Cech 4d3342152c Merge pull request #17782 from jmchilton/private_object_store_ui
[24.0] Prompt user to change default history permissions...
2024-03-20 03:10:21 +01:00
John Chilton 6cd4f68c36 Improved error messages for private object stores. 2024-03-19 16:03:23 -04:00
John ChiltonandDannon c2bd0d66f7 Update client/src/components/History/CurrentHistory/SelectPreferredStore.vue
Co-authored-by: Dannon <dannon.baker@gmail.com>
2024-03-19 15:32:20 -04:00
Martin Cech 6abf2dfb94 Merge pull request #17792 from dannon/fix-viz-activity-images
[24.0] Fix visualization activity plugin list images
2024-03-19 19:34:43 +01:00
Ahmed Awan c9e9ec1ca3 don't initialize shift selection if shiftKey is pressed 2024-03-19 12:56:27 -05:00
Marius van den Beek a9cafe5600 Merge pull request #17788 from dannon/fix-sharing-slug-confusion
[24.0] Avoid showing a shareable URL with the default slug/username.
2024-03-19 16:30:51 +01:00
Marius van den Beek 89e41ae840 Merge pull request #17791 from dannon/fix-history-dropdown
[24.0] Swap history dropdown from using the tiny caret to faBars.
2024-03-19 16:30:31 +01:00
Dannon Baker 704755867d Fix visualiation plugin list to generate and use the absolute path to
viz logos, which should always be resolved as static content.
2024-03-19 10:28:01 -04:00
Dannon Baker cf70ef69bf Attribute order fix. 2024-03-19 10:15:12 -04:00
Dannon Baker 3f8cefb569 Swap history dropdown from using the tiny caret to faBars. The caret is
too small, and bars communicate usage of the menu effectively here.
2024-03-19 10:09:57 -04:00
Dannon Baker c777d44b2e Formatting. 2024-03-19 09:46:01 -04:00
Dannon Baker a3ae5fc28f Clarify language about the activity bar being beta, enabled by default
down the road.
2024-03-19 09:30:56 -04:00
Dannon Baker 2da3a20142 Minor tweak to sharing -- make it more difficult to collide with default client side values. 2024-03-19 08:47:52 -04:00
Dannon Baker fca1ec87d3 Fix sharing page to avoid showing a shareable URL with the default
'username/slug' in it.  This has been reported by users to be confusing,
especially when a history can take ~10s to actually publish and return
with the valid, new slug -- folks are sharing busted URLs.
2024-03-19 08:46:24 -04:00
John Chilton c1b7f65387 Prompt user to change default history permissions...
... if picking a private object store for that history.
2024-03-18 16:15:02 -04:00
Ahmed Awan be59728585 add tooltip text to published icons in published Workflow grid 2024-03-18 14:52:27 -05:00
Ahmed Awan 7eb3cc9059 allow exact query search (surrounded by quotes) in grids
Users can bypass the client filtering by surrounding their raw search query by quotes and sending the unprocessed filter to the backend.
2024-03-18 14:44:02 -05:00
Ahmed Awan 8df4a5f28e remove underline from PanelViewMenu advanced section
Not related to changes in this PR.
2024-03-18 13:07:24 -05:00
Ahmed Awan b58d195386 change published button to filter toggle instead of link to published 2024-03-18 13:07:24 -05:00
Ahmed Awan d4e11206f3 add alias WorkflowFilters like 'u: username, n: name` etc. 2024-03-18 13:06:42 -05:00
Ahmed Awan cdbe0c1dec add overlay as loading indicator on GridLists
Fixes https://github.com/galaxyproject/galaxy/issues/17666
2024-03-18 13:04:46 -05:00
Ahmed Awan 51572b10f6 fix name tag filtering functionality
Quoted tags should match exact results. Name tags are unquoted _when sent to the backend_.
2024-03-18 13:04:46 -05:00
Ahmed Awan b77de7e8f3 do not perform query when invalid filters are present
Modified the `Filtering.getValidFilters` function to return an `invalidFilters` object as well, which can be used to tell the user which filters were invalid.
2024-03-18 13:04:46 -05:00
davelopez 178d7b77b0 Refactor and reuse userOwnsHistory 2024-03-18 18:07:19 +01:00
davelopez b0bccaf0e0 Fix typo 2024-03-18 18:06:34 +01:00
John Davis 799fde4b56 Merge pull request #17775 from davelopez/24.0_fix_missing_keys_from_histories_list
[24.0] Add missing fields in histories listings
2024-03-18 12:51:19 -04:00
Alireza Heidari 36236add23 🔒: prevent anonymous user to create or import a workflow and redirect to login 2024-03-18 16:10:31 +01:00
Alireza Heidari 64fc05dc6b 🔒: prevent anonymous user to run a workflow and redirect to login 2024-03-18 16:10:31 +01:00
John Davis d7a8a675fd Merge pull request #17763 from martenson/storage-language
[24.0] change user-facing language from "object store" to "storage location"
2024-03-18 11:08:13 -04:00
Marius van den Beek 495d2208e6 Merge pull request #17768 from mvdbeek/fix_subworkflow_listed_by_default
[24.0] Fix ``include_nested_invocations`` parameter use
2024-03-18 15:53:35 +01:00
davelopez 2665b3e2ca Add missing fields in histories listings 2024-03-18 15:18:23 +01:00
John Chilton aa8f85aa97 Merge pull request #17744 from martenson/revise-lang
[24.0] Revise language around non-private object stores
2024-03-18 10:09:40 -04:00
mvdbeek f776c3ad89 Fix `include_nested_invocations` passing, drop unused provder method
Fixes https://github.com/galaxyproject/galaxy/issues/17760
2024-03-18 11:05:17 +01:00
Marius van den Beek e2e6ba46ea Merge pull request #17726 from davelopez/24.0_fix_histories_api_index_serialization
[24.0] Fix histories API index_query serialization
2024-03-17 18:03:39 +01:00
Marius van den Beek 56ffd6bcbe Merge pull request #17753 from ElectronicBlueberry/fix-tag-sorting
[24.0] Fix tag sorting
2024-03-17 18:02:30 +01:00
Martin Cech 9e79c70cce improve visibility of object store badge popovers
so it is not white on white bg
2024-03-15 17:32:52 -07:00
Martin Cech 9519ffe8f4 change user-facing language from "object store" to "storage location" 2024-03-15 17:25:25 -07:00
Ahmed Awan b4c5b55aa3 [24.0] Add Shift+Click select for ContentItem selector buttons as well
While keyboard select was added in https://github.com/galaxyproject/galaxy/pull/17502 (and polished/fixed) in other PRs, the selector buttons did not allow for Shift+Click selection. This PR adds that.
2024-03-15 18:41:23 -05:00