Commit Graph
3111 Commits
Author SHA1 Message Date
mvdbeek da3e48faa5 Mark rerun_with_use_cached_job as flakey
Sometimes it does not pick up the equivalent job that should exist. Will need
to dig into this, but in the meantime we can allow the test to fail.
2018-01-09 15:53:22 +01:00
Dannon Baker 1f592f6ace Merge pull request #5270 from mvdbeek/fix_element_identifier_job_resume
Copy element_identifier to resumed job
2018-01-05 13:24:01 -05:00
mvdbeek 2f6cc22384 Copy element_identifier to resumed job
This fixes #5269.
2018-01-05 17:32:09 +02:00
John Chilton f6ed568971 Clarify some FTP purging behaviors with tests.
xref https://github.com/galaxyproject/galaxy/pull/5264#issuecomment-355373614
2018-01-04 14:23:49 -05:00
John Chilton 75283c7b6c Merge pull request #4178 from zipho/neo_datatype
Neostore Zip datatype support
2018-01-02 13:33:27 -05:00
mvdbeek 81c3b8cc4d Include more information in assertion 2017-12-31 18:06:49 +02:00
mvdbeek c327594ed7 Simplify use_cached_jobs workflow tests 2017-12-31 18:06:49 +02:00
mvdbeek 78c37d32d9 Assert that histories contains same dataset ids 2017-12-31 18:06:49 +02:00
mvdbeek 9d38219d65 Pass use_cached_jobs on to subworkflow invoker 2017-12-31 18:06:49 +02:00
mvdbeek 1c4476a6af Add a test for skipping jobs in workflow context
This is using the simplest of workflows. I had to
remove the chromInfo part from the workflow, because the
path referenced would be changed dynamically and so the
job search wouldn't recognize this as being equivalent.
2017-12-31 18:06:48 +02:00
mvdbeek 0dcf9d7fd6 Refine cached job tool test to make less asumptions 2017-12-31 18:06:48 +02:00
mvdbeek 4b6e403622 Add use_cached_job param to tools and workflow API
Also includes a simple test that runs cat1 three times,
the second time with `use_cached_job=False` (the default),
and the third time with `use_cached_job=True` and verifies
that the second output is different from the third, and that the
first and third output are identical.
2017-12-31 18:06:48 +02:00
mvdbeek 91696783b1 Uncomment test that relies on HDAHistory 2017-12-31 18:06:46 +02:00
mvdbeek e75daa1ddd Skip test that deletes the jobs input dataset
This does not work at the moment, since we need to verify a jobs' input name,
dataset and metadata, for which we don't have an explicit trail. The only trace
is via the update_time (i.e if a input dataset hasn't been updated since the
job was created we know these were the actual parameters in use during the
execution of this job).
2017-12-31 17:44:20 +02:00
mvdbeek 009daeff81 Fix the wildcard search 2017-12-31 17:44:20 +02:00
mvdbeek fc92adc1cc Take into account HDA name, metadata, element_identifier and datatype 2017-12-31 17:44:20 +02:00
John Chilton 8e93c2e070 Merge pull request #5247 from mvdbeek/job_rerun_fixes
Fix and enhance job resume functionality
2017-12-31 08:14:46 -06:00
mvdbeek c0dbace7bb Replace collection elements with re-run output
This specifically addresses the problem where some jobs of a mapped-over
collection have failed. Instead of filtering the failed collection and
restarting the workflow at this position (involving a lot of copy-paste ...)
the user can now limit the rerun to the problematic jobs and the workflow
should resume from there.
Should fix https://github.com/galaxyproject/galaxy/issues/2235.

This is one possible implementation, it would also be feasible to not
manipulate the original collection, but to copy the HDCA and then to replace
collection elements and replace all references for jobs that depend on the HDCA,
as we do for HDAs. This implementation seems simpler, but let me know if you
see problems with this approach.
2017-12-31 14:08:26 +02:00
mvdbeek 9fdf0a6269 Add job resume test with HDCA input to paused dataset
I am slightly surprised that this worked without change,
but it appears that the remapping occurs via the HDAs that
the HDCA is composed of.
2017-12-31 14:08:26 +02:00
mvdbeek 39073b4b4c Add test for resume job functionality
This test runs a workflow whose first step fails, followed by a tool that uses
the first step's output as an input, which is behind a nested conditional. This
recapitulates the bug described in https://github.com/galaxyproject/galaxy/issues/5222.
2017-12-31 14:07:42 +02:00
John Chilton f017de30bf Tool-centric annotation of out of memory errors.
- Update explicit stdio definitions as well as detect_errors-based definitions to allow this.
- Update runner code to allow resubmission in such cases.
2017-12-22 09:08:18 -05:00
Martin Cech 0bf73e4381 Merge pull request #5209 from jmchilton/library_upload_testing
Library Upload Refactoring, Testing, and Fixes
2017-12-20 15:25:30 -05:00
John Chilton 00e31c13f5 Fix more selenium library tests. 2017-12-20 00:40:42 -05:00
John Chilton 895e9971cb More upload configuration options testing - this time for libraries. 2017-12-19 16:09:44 -05:00
John Chilton e4d0788a28 Improvements to library testing.
- Add tests for creating a collection from a library.
- Add more class names to library GUI to improve selectors for tests.
- Automatically select whichever radio box makes sense in library collection builder dialog based on whether there is a selection or not.
2017-12-18 15:47:17 -05:00
Martin Cech 96565e9b84 wip on importing from library to history as a collection
+ various es6 additions; cleanup; refactoring

I tried to separate it into more commits but it kept growing too fast, sorry
2017-12-18 13:16:50 -05:00
Nicola Soranzo 6d3eadedbd Merge pull request #5227 from jmchilton/merge_1709
Merge 17.09.
2017-12-15 18:14:34 +00:00
John Chilton 90ba35a9a4 Merge remote-tracking branch 'jmchilton/release_17.09' into merge_1709 2017-12-15 12:02:07 -05:00
mvdbeek 3f6c45578e Fix dataset spelling (thx @nsoranzo) 2017-12-15 16:13:32 +01:00
mvdbeek b39772011a Optionally allow dataset populators to fail 2017-12-15 13:36:38 +01:00
Nicola Soranzo 6f722861cf Python3: fix moved imports
Add `.ci/check_py3_compatibility.sh` script to find library modules
that have been moved in Python3. Fix errors found by the script.
2017-12-15 01:03:28 +00:00
mvdbeek 62a3ff3562 Do not assert dataset state in test_gzipped_html_content_blocked_by_default test 2017-12-14 18:16:51 +01:00
mvdbeek 710177f398 Add API tests for history uploads from URL 2017-12-14 17:21:09 +01:00
John Chilton 6fd6595238 Another try to fix flakey tool form Selenium test. 2017-12-14 08:21:46 -05:00
John Chilton 5043439df2 Selenium - little pause to let extension form in upload dialog render.
xref https://github.com/galaxyproject/galaxy/issues/5169
2017-12-13 16:04:49 -05:00
John Chilton dc67206b21 Merge remote-tracking branch 'jmchilton/dev' into neo_datatype 2017-12-12 10:23:41 -05:00
guerler 34a71af9e1 Merge branch 'dev' into remove_formbuilder 2017-12-11 10:38:27 -05:00
mvdbeek 309b71720e Improvements to datatypes suggested by @nsoranzo 2017-12-10 12:13:37 +01:00
guerler 2686299ac9 Fix value setting in test case 2017-12-09 15:35:45 -05:00
mvdbeek 46371d1251 Decompose interval_to_tabix converter script
This renames some variables to make it clearer what files they reflect.
Also adds a very basic test that this works as intended.
2017-12-08 15:18:56 +01:00
mvdbeek eb636c1136 Make sure files don't change in-place 2017-12-08 11:35:31 +01:00
mvdbeek 2a6e00dd00 one more linting fix 2017-12-08 11:35:31 +01:00
mvdbeek 6ca896ff9b Fix index file syntax and fix linting problems 2017-12-08 11:35:31 +01:00
mvdbeek 0ac77ad7fd Fix Vcf index generation and test 2017-12-08 11:35:31 +01:00
mvdbeek df35d089e3 Add more unittests for CRAM, bcf and vcf 2017-12-08 11:35:31 +01:00
mvdbeek ae72e56683 Use subprocess to check if pysam.index succeeds
Checking if pysam.index succeeds tests whether a file is coordinate sorted.
If pysam.index fails to index htslib writes to stderr and this fails set meta
tool. To prevent this we run this in a subprocess and discard stderr.
2017-12-08 11:35:31 +01:00
mvdbeek 369485a43a Move Bam doctests to unittests 2017-12-08 11:35:31 +01:00
Eric Rasche 044dcfbb21 Merge pull request #5139 from jmchilton/resubmit_dynamic
Test resubmit for dynamic JobDestination structures.
2017-12-08 08:50:41 +00:00
Björn Grüning c8d45dd4b3 Merge pull request #5143 from jmchilton/fix_missing_outputs
Re-allow workflow outputs that aren't produced during workflow scheduling.
2017-12-07 16:23:28 +01:00
Björn Grüning c8937c8929 Merge pull request #5145 from jmchilton/subworkflow_delayed_handling
Fixes for handling delayed steps within subworkflows.
2017-12-07 16:21:12 +01:00