mvdbeek
b1509ba76d
Fix client unit tests
2025-05-02 19:37:28 +02:00
mvdbeek
4d71d88081
Improve edam test robustness
...
No guarantee that the title won't change, and I think it has recently.
2025-05-02 17:46:08 +02:00
mvdbeek
96c26d1028
Wait for `userLoad` before tool panel init
...
We use the user to hash localStorage values, so gotta have it before we
determine whether the panel value needs to set.
Fixes https://github.com/galaxyproject/galaxy/issues/19461
2025-05-02 17:45:00 +02:00
Alireza Heidari
886105eae9
Fix edit permission for datasets
2025-04-22 17:12:12 +02:00
Ahmed Awan
97a6ceed1a
remove newHistoryTarget prop and instead check if history is different
...
This means that we show the little icon to switch to the history for the invocation if that history isn't current, regardless of if results were generated in a new history or not.
2025-04-15 10:13:35 -05:00
Ahmed Awan
ba43210086
add jest to test new populated_state for job summary
2025-04-14 19:49:09 -05:00
Ahmed Awan
642ad39a5d
use populated_state in the jobs summary to continue polling for states
...
As we can see this value being set in `summarize_invocation_jobs` here https://github.com/galaxyproject/galaxy/blob/4a0cca07d97d7bbd22eb39ddab38d4d4354aa4fa/lib/galaxy/managers/jobs.py#L957-L1000 , `new` seems to be a non-terminal `populated_state`, meaning this summary will have updates which will eventually produce some state counts.
To fix the bug of never getting a state count for the invocation view before the scheduling state becomes terminal, we now wait for the state to be something else than `new`, and only then look for other reasons to stop polling.
2025-04-14 19:22:05 -05:00
Ahmed Awan
a2dc1485c4
route to invocation on run
...
**For a singular invocation** (excluding cases of batch runs), we now push to the `workflows/invocations/{invocation_id}` route when the workflow is run.
Without this, we would stay on the `workflows/run` route and refreshing would take you back to the run form, instead of the invocation view.
2025-04-14 15:50:05 -05:00
Ahmed Awan
3dca5d9225
fix jobStatesSummary return type (should be allowed to return null)
2025-04-14 15:42:17 -05:00
Ahmed Awan
00aa61cbc0
[24.2] Ensure job states are fetched in invocation view
...
Fixes https://github.com/galaxyproject/galaxy/issues/20003
We weren't checking if the job states summary had been fetched before we had the
```
if (invocationSchedulingTerminal.value && jobCount.value === 0)
```
check. `jobCount` would always be 0 if the states summary hadn't been fetched yet.
2025-04-14 15:32:45 -05:00
David López
d44bac9efb
Merge pull request #19992 from davelopez/24.2_fix_user_object_stores_updates
...
[24.2] Update selectable object stores after adding or editing them
2025-04-14 09:59:06 +02:00
Marius van den Beek
fed8750d25
Merge pull request #19985 from mvdbeek/fix_collection_drag_and_drop
...
[24.2] Always set copy_elements to true
2025-04-11 20:57:28 +02:00
Dannon
0f8eb33d05
Merge pull request #19987 from dannon/wizard-rate-limit
...
[24.2] ChatGXY Error Handling
2025-04-11 11:59:20 -04:00
davelopez
0c13d2df94
Add object store update functionality and refactor related components
...
- Introduced `addOrUpdateObjectStore` method in the object store store for managing object stores without server reload.
- Updated `CreateInstance.vue` and `EditInstance.vue` to utilize the new method for adding or updating object stores.
- Enhanced `useConfigurationTemplateEdit` to accept the new callback for object store updates.
2025-04-11 14:31:49 +02:00
Dannon Baker
e78fc8a55b
Typo, formatting, some cleanup.
2025-04-10 16:17:14 -04:00
Dannon Baker
8d109f8236
Better error display for wizard, when one happens.
2025-04-10 13:22:26 -04:00
mvdbeek
1037d32b00
Always set copy_elements to true
...
Fixes https://github.com/galaxyproject/galaxy/issues/19984
2025-04-10 18:50:21 +02:00
John Davis and Ahmed Hamid Awan
77dd5769d4
Update client/src/components/License/LicenseSelector.vue
...
Co-authored-by: Ahmed Hamid Awan <qe66653@umbc.edu >
2025-04-10 12:46:15 -04:00
John Davis and Ahmed Hamid Awan
1a879ac5f9
Use proper casing
...
Co-authored-by: Ahmed Hamid Awan <qe66653@umbc.edu >
2025-04-10 12:44:55 -04:00
John Davis and Ahmed Hamid Awan
0732a7e5c9
Use proper casing
...
Co-authored-by: Ahmed Hamid Awan <qe66653@umbc.edu >
2025-04-10 12:44:40 -04:00
John Davis and Ahmed Hamid Awan
4db7d2b6cb
Use proper casing
...
Co-authored-by: Ahmed Hamid Awan <qe66653@umbc.edu >
2025-04-10 12:44:28 -04:00
Dannon Baker
fbd793dc49
Refactor GalaxyWizard component to handle new ChatResponse format and improve error handling
2025-04-10 11:27:38 -04:00
Dannon Baker
744af02072
Rebuild client API schema for chat response
2025-04-10 10:57:24 -04:00
Dannon Baker
99de35ef5c
Enhance response handling in GalaxyWizard component to support new ChatResponse format
2025-04-10 10:52:04 -04:00
John Davis
a54f860da7
Fix default labels in external login selector
2025-04-10 10:24:25 -04:00
John Davis
740913a01c
Fix default labels in custom builds selector
2025-04-10 10:24:03 -04:00
John Davis
b00dc2aa69
Fix default labels in licence selector
2025-04-10 10:23:31 -04:00
davelopez
d36e867445
Enhance FormData handling to prevent duplicate entries
2025-03-28 12:21:52 +01:00
davelopez
989a615f60
Refactor handleIncoming function to use toDataOption
...
For reusability
2025-03-28 12:20:29 +01:00
davelopez
19c448adc6
Add containsDataOption function to prevent duplicate entries in FormData
...
When drag and dropping the same item
2025-03-27 10:49:36 +01:00
davelopez
cc2ee180d6
Move itemUniqueKey function to types module for reuse
2025-03-26 18:10:32 +01:00
Marius van den Beek
7bd3e599ad
Merge pull request #19837 from jdavcs/24.2_multiselect
...
[24.2] Do not reorder options in FormSelect component when multiselect disabled
2025-03-26 10:01:59 +01:00
Marius van den Beek
1761e48055
Merge pull request #19853 from jdavcs/24.2_admin_ordering
...
[24.2] Fix default ordering of items sorted by name
2025-03-26 10:00:42 +01:00
John Chilton
b1f401d56d
Merge pull request #19797 from mvdbeek/fix_collection_builder_input_restriction
...
[24.2] Fix collection builder input states
2025-03-25 12:00:08 -04:00
Marius van den Beek
68be79f17a
Merge pull request #19841 from ahmedhamidawan/fix_directory_form_element_encoding
...
[24.2] Decode/encode FormDirectory paths to allow spaces (and other characters)
2025-03-25 16:50:24 +01:00
Ahmed Awan
c0762f7190
add jest to test https://github.com/galaxyproject/galaxy/pull/19841
2025-03-24 13:53:34 -05:00
Ahmed Awan
937c8489c5
update url when an added path is removed
2025-03-24 13:09:06 -05:00
Ahmed Awan
91665975a0
show path in FormDirectory
2025-03-24 13:09:06 -05:00
Ahmed Awan
f88bf02348
Decode/encode FormDirectory paths to allow spaces (and other characters)
...
Fixes https://github.com/galaxyproject/galaxy/issues/19812
2025-03-24 13:09:06 -05:00
Ahmed Awan and mvdbeek
b0a448a5b8
use itemUniqueKey instead of just id because those aren't unique
...
Co-authored-by: mvdbeek <m.vandenbeek@gmail.com >
2025-03-24 13:05:03 -05:00
Ahmed Awan
e7fe2f0a7e
improve drag and drop typing in FormData, fix multi drop
...
This adds `HistoryOrCollectionItem` typing to `FormData` and also fixes the bug with multiple item drag-drop not working.
2025-03-24 12:25:57 -05:00
Ahmed Awan
09526e446f
[24.2] Fix drag and drop for dataset collection elements
2025-03-24 12:15:00 -05:00
mvdbeek
1545945986
Lazy-load invocation step jobs as needed
...
Fixes https://github.com/galaxyproject/galaxy/issues/19876
2025-03-23 16:03:00 +01:00
Ahmed Awan
add040ebb6
change multiselect current option highlight to darkened secondary
2025-03-20 13:19:51 -05:00
Ahmed Awan
0f0b8fe49b
change multiselect current option highlight to success from danger
2025-03-20 12:30:21 -05:00
Ahmed Awan
2b29c6666b
add explicit track by id functionality to FormSelect
2025-03-20 11:57:40 -05:00
John Davis
b588b27449
Fix default ordering for admin UI
2025-03-19 20:17:06 -04:00
Ahmed Awan
df2ff299c2
[24.2] Add spacing between workflow author and invocation count
...
Fixes https://github.com/galaxyproject/galaxy/issues/19848
2025-03-19 11:20:47 -05:00
Ahmed Awan
165cff939f
ensure item is checked if selected and is an object with id
2025-03-19 10:21:26 -05:00
John Davis
a49d031b57
Do not reorder options in FormSelect component when multiselect disabled
2025-03-18 13:05:13 -04:00