Present users with the job standard error and also check for binary sniffing problems and report them with a pretty message suggesting specifying a file type.
Problem one is that passing the tool_state as the input payload doesn't
preserve the tool state, adressed with the client-part fix.
Then passing the tool state still has no effect since the state is
properly recovered in `module_factory.from_dict`, but then overwritten
by recovering the state starting with an empty dict. It looks like this
isn't necessary as we call populate_state anyway when calling
`module.get_config_form()`.
Fixes https://github.com/galaxyproject/galaxy/issues/5879.
- Missed allowing collection name in library mode - I told Martin this possible because I thought it was and the library collection type text states it is possible but I didn't fix the switch in rule-definitions.js and notice the problems in createCollection associated with that.
- Fix to drop file type and genome selector when coming from libraries because this targets existing datasets - think this might have slipped back in a bad merge.
- Fix modal title when coming from data library folders.
- Improve text instructions when coming from a library.
Fixes#5967.
Allow the rules DSL & GUI component to operate on existing collections to allow filtering, sorting, modifying identifiers and general re-organization of existing collections (e.g. the outputs of tools). Implementing this as a collection operation tool so that it should be executable interactively in the tool form and in a batch fashion as part of workflow executions.
For this to be tracked properly as a tool execution and to work properly in the tool form, I've implemented a new tool framework and tool form parameter type called "rules".
This can thought of as a more GUI friendly alternative to my proposed collection operations that consumed JavaScript expressions.
This includes API tests for both tool and workflow execution of the new tool as well as Selenium tests for tool form execution, workflow editor interactions, and workflow running.
- Print a pretty error for this scenerio.
- Improve the error state of the widget to add a cancel and "okay" button - the cancel button dimisses the widget and the okay button gives the reseracher a chance to return to the rules and try again.
guerler