Commit Graph
300 Commits
Author SHA1 Message Date
Nicola Soranzo 962def5bb8 Merge branch 'release_22.05' into dev 2022-11-28 15:22:49 +00:00
mvdbeek b6117ee3df Fix metadata setting for discovered datasets with extended metadata
Fixes https://github.com/galaxyproject/galaxy/issues/15036
2022-11-20 16:02:15 +01:00
mvdbeek b627762a76 Add more test scenarios
Test collection black hole
2022-11-08 22:16:20 +01:00
Marius van den Beek cda2aea10c Merge pull request #12999 from simonbray/dupl-collection
Add duplicate_file_to_collection tool
2022-10-17 12:01:41 +02:00
Nicola Soranzo 70b2ea429c Merge branch 'release_22.01' into release_22.05 2022-09-06 12:12:21 +01:00
Nicola Soranzo 9f1d8d053b Merge branch 'release_21.09' into release_22.01 2022-09-06 11:36:36 +01:00
Nicola Soranzo 06baa27d05 Merge branch 'release_21.05' into release_21.09 2022-09-06 11:24:20 +01:00
Nicola Soranzo 8069584d0f Merge branch 'release_21.01' into release_21.05 2022-09-06 11:12:59 +01:00
Matthias Bernt 59f77048ce test case showing failing set_meta
broke in https://github.com/galaxyproject/galaxy/commit/7d0ec29fa06ae6f04c0ae6fc193a390bc11cddcd
2022-08-25 16:45:26 +02:00
Nicola Soranzo e383e593e0 Merge branch 'release_22.01' into release_22.05 2022-07-27 15:38:19 +01:00
Matthias Bernt d642ce34c8 fix startswith attribute of <options>
as documented in the xsd

in addition fix https://github.com/galaxyproject/galaxy/issues/14324,
i.e. document the `separator` attribute of options

also doc that only 1MB is used and lines starting with `#` are always
ignored
2022-07-14 14:19:40 +02:00
Nicola Soranzo d3b4ef81d0 Merge branch 'release_21.09' into release_22.01 2022-06-23 14:30:57 +01:00
mvdbeek 55ecc382e7 Add selenium test for ucsc table browser data source 2022-06-13 11:03:13 +02:00
mvdbeek 5ea0a53538 Add selenium test for ucsc table browser data source 2022-06-09 15:03:45 +02:00
Marius van den Beek 7cb3f76c6e Merge pull request #12232 from bernt-matthias/topic/drilldown
fix `drill_down` parameters
2022-05-25 15:52:50 +02:00
M Bernt 228d07a9cc Merge branch 'dev' into topic/count-pairs-correctly 2022-04-21 13:03:59 +02:00
Nicola Soranzo 8adc7ec870 Merge branch 'release_21.09' into release_22.01 2022-04-11 19:03:41 +01:00
Matthias Bernt 4bc560383f add test for correct sorting on recursive discovery 2022-04-08 19:38:50 +02:00
Matthias Bernt 0626e45b3c add test for correct sorting on recursive discovery 2022-04-07 14:42:19 +02:00
Matthias Bernt 9c5cfed6f4 add functional test for drill down parameters 2022-03-22 08:57:42 +01:00
Matthias Bernt c194cc62f1 fix doc for expect_num_pairs and add test tool
also the TOC for discovered_dataset was wrong
and fixed a minor typo in comments in xsd
2022-01-30 15:21:34 +01:00
Matthias Bernt 2e33be78ac make param_value filter work with multi data inputs
ie data with multiple=true and collections
2022-01-11 15:54:42 +01:00
Matthias Bernt c8090031b7 add test for param_value filter 2022-01-11 15:54:42 +01:00
Matthias Bernt 34cd037df3 restructure tests
- put them all in one test tool
- and add other select parameter types
2021-12-16 09:55:12 +01:00
Matthias Bernt defbfbe8cf test for optional & multiple column select
showing that its currently not possible to select no column

and the same for a select with dynamic options (wo legal_values)
that shows that it works here
2021-12-16 09:55:12 +01:00
John Chilton 918302c23e Fix running pytest test/integration/test_remote_files.py::RemoteFilesIntegrationTestCase directly. 2021-12-08 11:33:13 -05:00
Nicola Soranzo 55b690ac99 Remove missing tool from functional test tool conf 2021-12-08 08:14:14 +00:00
Nicola Soranzo 6c0036fb57 Fix wrong test tool file path 2021-12-08 08:14:13 +00:00
Nicola Soranzo cf1d036b1c Remove entry already in lib/galaxy/config/sample/tool_conf.xml.sample
Cannot be imported from this directory any way.
2021-12-08 08:14:12 +00:00
Simon Bray f95fcb5c42 add duplicate_file_to_collection tool 2021-11-29 08:50:44 +01:00
mvdbeek 1a531cd1a0 Fix from work dir glob with extended metadata
I also have a commit coming for pulsar that fixes this if pulsar stages
out from_work_dir outputs.
2021-10-31 13:06:41 +01:00
mvdbeek ed9f46f757 Add two versions of build_list tool 2021-09-20 14:17:14 +02:00
Marius van den Beek f10aecbf4c Merge pull request #11043 from bernt-matthias/topic/validator-negate
Add `negate` attribute to validators .. and tests for all
2021-09-16 11:54:24 +02:00
mvdbeek e60a9af01b Fix is_of_type for datasets in a collection
Include a test tool that fails like this without the fix:

```
Traceback (most recent call last):
  File "/Users/mvandenb/src/galaxy/lib/galaxy/util/template.py", line 80, in fill_template
    return unicodify(t, log_exception=False)
  File "/Users/mvandenb/src/galaxy/lib/galaxy/util/__init__.py", line 1060, in unicodify
    value = str(value)
  File "/Users/mvandenb/src/galaxy/.venv/lib/python3.9/site-packages/Cheetah/Template.py", line 1053, in __unicode__
    return getattr(self, mainMethName)()
  File "cheetah_DynamicallyCompiledCheetahTemplate_1631180564_759418_48584.py", line 89, in respond
  File "/Users/mvandenb/src/galaxy/lib/galaxy/tools/wrappers.py", line 342, in is_of_type
    datatype = self.datatypes_registry.get_datatype_by_extension(e)
AttributeError: 'NoneType' object has no attribute 'get_datatype_by_extension'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/mvandenb/src/galaxy/lib/galaxy/jobs/runners/__init__.py", line 237, in prepare_job
    job_wrapper.prepare()
  File "/Users/mvandenb/src/galaxy/lib/galaxy/jobs/__init__.py", line 1160, in prepare
    self.command_line, self.extra_filenames, self.environment_variables = tool_evaluator.build()
  File "/Users/mvandenb/src/galaxy/lib/galaxy/tools/evaluation.py", line 463, in build
    raise e
  File "/Users/mvandenb/src/galaxy/lib/galaxy/tools/evaluation.py", line 459, in build
    self.__build_command_line()
  File "/Users/mvandenb/src/galaxy/lib/galaxy/tools/evaluation.py", line 484, in __build_command_line
    command_line = fill_template(command, context=param_dict, python_template_version=self.tool.python_template_version)
  File "/Users/mvandenb/src/galaxy/lib/galaxy/util/template.py", line 118, in fill_template
    return fill_template(template_text=template_text,
  File "/Users/mvandenb/src/galaxy/lib/galaxy/util/template.py", line 126, in fill_template
    raise first_exception or e
  File "/Users/mvandenb/src/galaxy/lib/galaxy/util/template.py", line 80, in fill_template
    return unicodify(t, log_exception=False)
  File "/Users/mvandenb/src/galaxy/lib/galaxy/util/__init__.py", line 1060, in unicodify
    value = str(value)
  File "/Users/mvandenb/src/galaxy/.venv/lib/python3.9/site-packages/Cheetah/Template.py", line 1053, in __unicode__
    return getattr(self, mainMethName)()
  File "cheetah_DynamicallyCompiledCheetahTemplate_1631180564_725492_78593.py", line 87, in respond
  File "/Users/mvandenb/src/galaxy/lib/galaxy/tools/wrappers.py", line 342, in is_of_type
    datatype = self.datatypes_registry.get_datatype_by_extension(e)
AttributeError: 'NoneType' object has no attribute 'get_datatype_by_extension'
```

Broken in https://github.com/galaxyproject/galaxy/pull/11613
2021-09-09 11:45:53 +02:00
John Chilton 853d7e978d API test case to ensure dataset names get escaped during tool evaluation.
I think other sanitization properties aren't testing that model properties are escaped.
2021-08-18 13:41:06 -04:00
Nate Coraor a6ac841f85 Support setting per-job-environment container resolvers using the container_resolvers key in the environment config. 2021-08-17 10:28:51 -04:00
Matthias Bernt a0046e4316 improved default messages from validators
- improved default messages
- allways substitute %s by value, deprecate `substitute_by_value`
- add functional tool tests to the tool_conf file (forgotten before)
  and small fixes
2021-08-02 15:02:10 +02:00
Nicola Soranzo 8b55e59ee7 Merge pull request #12185 from bernt-matthias/topic/test/converters 2021-06-25 00:30:51 +01:00
Marius van den Beek 7177d8e88d Merge pull request #11613 from jmchilton/export_file
Add tool for exporting individual files to galaxy file source plugins.
2021-06-23 18:43:34 +02:00
Matthias Bernt 979669a8ca make __target_datatype a hidden parameter in biom converter
to allow for standard tool test

but also keep the converter test.
2021-06-23 09:35:26 +02:00
mvdbeek 90ccfefe9a Add switch for optional select in workflow editor
If the `Set value for this optional select field ? `switch is set to no
we serialize the value as `null` instead of `""`, which is especially
important in optional select fields, where `""` may correspond to an
option that is distinct from not setting a value.

I have only enabled this for select parameters that are cast to text
parameters, but I think this discrimination between set and unset
would also be great for optional text parameters.
There might be a better way to do it in the UI (maybe some icon that
indicates that the value is set, that can be toggled with an backspace
when the field is empty?), but I think this will do for the relatively
rare case of optional select parameters that are cast to text fields.

Fixes https://github.com/galaxyproject/galaxy/issues/12081
2021-06-14 12:49:51 +02:00
mvdbeek 8bf9de4e1a Provide $input.serialize(), allow wrap_json to serialize collections 2021-05-28 22:49:49 +02:00
John Chilton e9081759ca Add tool for exporting individual files to Galaxy.
Stolen wholesale from EU. Trying to make it a bit more general though.
2021-05-27 17:21:01 +02:00
Marius van den Beek eb3f3c816f Merge pull request #11832 from qiagu/dynamic_options
Make tool parameter options capable of referring to metadata file
2021-05-04 09:49:35 +02:00
cat-bro 58f767d296 breaking test for GalaxyInteractorApi get_tool_tests 2021-04-29 23:50:12 +10:00
qiagu 455b838bd4 Make test tool for meta_file_key 2021-04-13 19:23:59 -07:00
M Bernt 08fbff5844 tests for multiple value splitter 2021-04-06 18:32:19 +02:00
John Chilton a6f3b255cb Merge pull request #11764 from mvdbeek/fix_format_input_implicit_conversion
[21.01] Fix format="input" with implicit conversions
2021-04-01 10:45:55 -04:00
mvdbeek 7eb853d703 Fix format="input" with implicit conversions
where the implicit converter uses galaxy.json.

Add test, fix fix
2021-03-31 22:06:39 +02:00
Anthony Bretaudeau 4adeca0e86 Merge remote-tracking branch 'upstream/release_21.01' into pulsar_tool_dir 2021-03-25 16:53:34 +01:00