Commit Graph
34455 Commits
Author SHA1 Message Date
galaxybot 45dce13ff2 Update Python dependencies 2023-06-03 03:13:32 +00:00
Rendani Gangazhe 18d148b641 Add carbon emssions reporting to job information page 2023-06-02 10:08:17 -04:00
John Chilton c96e2cd964 Accessibility tests and fixes for copy_view.mako 2023-06-02 10:08:17 -04:00
John Chilton 2562022302 Add aria-expanded to StatelessTags element. 2023-06-02 10:08:17 -04:00
John Chilton 1823d27b1b Fix transiently failing published histories test.
A better fix would be to verify the sorting icons change on the page instead of sleeping to detect the elements being rendered but not yet wired u
p which I think is the problem?
2023-06-02 10:08:17 -04:00
John Davis 6b5e7bbcfb Raise config error if connection URL is unparseable
Delete involucro file (added accidentally in ee31eca)
2023-06-02 10:08:13 -04:00
mvdbeek 73413b1627 Merge branch 'release_23.0' into dev 2023-06-01 15:19:47 +02:00
mvdbeek cc43c50eef Fix test search for mulled container hashes
Fixes
```
FAILED test/unit/tool_util/mulled/test_get_tests.py::test_hashed_test_search - AssertionError: assert ['bamtools --help'] == ['bamtools --help', 'samtools --help']
  Right contains one more item: 'samtools --help'
  Full diff:
  - ['bamtools --help', 'samtools --help']
  + ['bamtools --help']
```
(again). The test broke with the addition of
`osx-64/samtools-1.3.1-h0840685_11.tar.bz2` 4 days ago.
2023-06-01 12:51:21 +02:00
mvdbeek a710551142 Fix linting of FITS datatype code
Introduced in https://github.com/galaxyproject/galaxy/pull/15905
2023-06-01 11:56:46 +02:00
Björn Grüning 78ab683636 Merge pull request #15905 from esg-epfl-apc/fits-datatypes
FITS data format
2023-05-31 18:46:01 +02:00
Marius van den Beek 290592b20f Merge pull request #16162 from nsoranzo/move_axe-selenium-python_to_dev_deps
Move axe-selenium-python to dev dependencies
2023-05-31 10:44:36 +02:00
francoismg 9bbaf2bfcc Fixed linting 2023-05-31 09:25:41 +02:00
Björn Grüning b58e165002 Merge pull request #16093 from jmchilton/upload_paired_test
Improve robustness of collection upload tests.
2023-05-30 22:20:55 +02:00
Nicola Soranzo 87e66de706 Move axe-selenium-python to dev dependencies
Follow-up on https://github.com/galaxyproject/galaxy/pull/16122 and
https://github.com/galaxyproject/galaxy/pull/16153 .

Run `make update-dependencies' .
2023-05-30 18:38:36 +01:00
Nicola Soranzo afc11e2ebc Merge branch 'release_23.0' into dev 2023-05-30 17:49:58 +01:00
John Chilton a64079e1f4 Improve robustness of collection upload tests. 2023-05-30 11:03:45 -04:00
Dannon Baker 6de151f994 In practice this is not always defined and should be treated as
optional, I think
2023-05-29 16:28:29 -04:00
Tillman 32fe0c9a19 Adapt API tests to use JSON payload 2023-05-29 18:25:06 +02:00
Tillman 2fed3a95e9 remove the mapping to the legacy route 2023-05-29 18:23:27 +02:00
Tillman b5e4d2cd14 Refactor index and reload operation 2023-05-29 18:22:11 +02:00
Tillman 76e357fa26 Add pydantic models for the display_applications API 2023-05-29 18:14:09 +02:00
Nuwan Goonasekera acc45b2fef Merge pull request #15110 from pcm32/patch-12
Documents use of k8s_extra_job_envs in job_conf sample advanced
2023-05-29 12:27:52 +05:30
Marius van den Beek 606a0396b0 Merge pull request #16136 from martenson/invo
Add option to see invocations related to a history
2023-05-28 11:19:30 +02:00
galaxybot 782dc9fd3d Update Python dependencies 2023-05-27 03:12:46 +00:00
Björn Grüning 6ff2397a91 Merge pull request #16122 from jmchilton/axe-selenium
Integrate accessibility testing into Selenium testing
2023-05-26 22:53:31 +02:00
Marius van den Beek 45ea7eb734 Merge pull request #16144 from jmchilton/caching_refactor
Refactor caching object stores ahead of adding task-based store.
2023-05-26 14:42:45 +02:00
mvdbeek 49c82389ff Merge branch 'release_23.0' into dev 2023-05-26 12:56:53 +02:00
Marius van den Beek 9e377241bf Merge pull request #16149 from mvdbeek/dev
Merge 23.0 into dev
2023-05-26 09:32:29 +02:00
mvdbeek c1a055ff2f Merge branch 'release_23.0' into dev 2023-05-25 16:36:34 +02:00
Nicola Soranzo 7fea2db936 Merge branch 'release_22.05' into release_23.0 2023-05-25 13:53:52 +01:00
John Chilton c59416d6a2 Merge pull request #16148 from jmchilton/latest_test_errors
When writing test error debug directories, create a 'latest' symlink.
2023-05-25 08:35:11 -04:00
Nicola Soranzo ffb5291010 Fix parsing of mulled tsv files containing comments and tabs 2023-05-25 08:32:22 +01:00
Nicola Soranzo cc35a28ac8 Add test for conda `best_search_result()` 2023-05-25 08:32:21 +01:00
Nicola Soranzo a0d6e87fcc Fix testing importing modules in containers 2023-05-25 08:32:21 +01:00
Nicola Soranzo 95c6e4b71d Fix `get_test_from_anaconda() and base_image_for_targets()` functions
by extracting all specified files in ``get_files_from_conda_package()``
and processing them in order of precedence.

Fix broken mulled unit test:

```
FAILED test/unit/tool_util/mulled/test_get_tests.py::test_hashed_test_search - AssertionError: assert ['bamtools --help'] == ['bamtools --help', 'samtools --help']
  Right contains one more item: 'samtools --help'
  Full diff:
  - ['bamtools --help', 'samtools --help']
  + ['bamtools --help']
```

which failed because, after a new build of samtools 1.3.1 was released,
``get_file_from_conda_package()`` started returning the content of
``info/recipe/meta.yaml.template`` instead of ``info/recipe/meta.yaml``
when called inside ``get_test_from_anaconda()``. Then parsing
the content of ``info/recipe/meta.yaml.template`` in
``get_commands_from_yaml()`` failed with

```
jinja2.exceptions.UndefinedError: 'compiler' is undefined
```

because that file contains ``{{ compiler('c') }}`` .

Broken in https://github.com/galaxyproject/galaxy/pull/15682 .
2023-05-25 08:32:20 +01:00
John Chilton de6fc52721 When writing test error debug directories, create a latest symlink to ease navigation. 2023-05-24 15:46:09 -04:00
John Chilton b24bf478a9 Refactor object store cache parsing for de-duplication. 2023-05-24 15:41:05 -04:00
John Chilton 6a6de712b8 Enable object stores to work without a configured cache. 2023-05-24 15:41:05 -04:00
davelopez 5837ae49f1 Add test coverage for immutability check 2023-05-24 20:17:31 +02:00
John Chilton 9425493bdb Attempt to fix typing issues in integration tests. 2023-05-24 13:20:21 -04:00
John Chilton 8a2de17d0d Fix selenium test that just ended with an api request and no check. 2023-05-24 12:54:25 -04:00
John Chilton f9e00f597a axe testing 2023-05-24 12:54:25 -04:00
davelopez 4cc9d48cc8 Improve histories and datasets immutability checks
Avoids some mutation operations through the API on items that are purged or archived.
2023-05-24 16:52:51 +02:00
Marius van den Beek 0901ad748f Merge pull request #16133 from mvdbeek/implicit_converter_fix
[23.0] Fix implicit converters with optional parameters
2023-05-24 14:44:48 +02:00
mvdbeek b346c82344 Inject None in optional parameters when buidling implicit converter params
Fixes:
```
KeyError: 'chrom'
  File "galaxy/tools/__init__.py", line 1909, in handle_single_execution
    rval = self.execute(
  File "galaxy/tools/__init__.py", line 2005, in execute
    return self.tool_action.execute(
  File "galaxy/tools/actions/__init__.py", line 392, in execute
    ) = self._collect_inputs(tool, trans, incoming, history, current_user_roles, collection_info)
  File "galaxy/tools/actions/__init__.py", line 327, in _collect_inputs
    inp_data, all_permissions = self._collect_input_datasets(
  File "galaxy/tools/actions/__init__.py", line 268, in _collect_input_datasets
    tool.visit_inputs(param_values, visitor)
  File "galaxy/tools/__init__.py", line 1748, in visit_inputs
    visit_input_values(self.inputs, values, callback)
  File "galaxy/tools/parameters/__init__.py", line 224, in visit_input_values
    callback_helper(
  File "galaxy/tools/parameters/__init__.py", line 159, in callback_helper
    new_value = callback(**args)
  File "galaxy/tools/actions/__init__.py", line 191, in visitor
    input_datasets[prefix + input.name] = process_dataset(value)
  File "galaxy/tools/actions/__init__.py", line 126, in process_dataset
    data = data.get_converted_dataset(trans, target_ext, target_context=parent, history=history)
  File "galaxy/model/__init__.py", line 4211, in get_converted_dataset
    self.datatype.convert_dataset(
  File "galaxy/datatypes/data.py", line 795, in convert_dataset
    job, converted_datasets, *_ = converter.execute(trans, incoming=params, set_output_hid=visible, history=history)
  File "galaxy/tools/__init__.py", line 2005, in execute
    return self.tool_action.execute(
  File "galaxy/tools/actions/__init__.py", line 453, in execute
    params=wrapped_params.params,
  File "galaxy/tools/parameters/wrapped.py", line 43, in params
    self.wrap_values(self.tool.inputs, params, skip_missing_values=not self.tool.check_values)
  File "galaxy/tools/parameters/wrapped.py", line 58, in wrap_values
    value = input_values[input.name]
```

in https://sentry.galaxyproject.org/share/issue/4f2171798f214f7ba8b947eaaebe2776/
2023-05-24 10:54:31 +02:00
Marius van den Beek d07357d1af Merge pull request #16085 from jmchilton/workflow_display_tests
Selenium test for displaying workflows with problems in pages.
2023-05-24 10:13:18 +02:00
Björn Grüning 5a9be495b5 Merge pull request #16075 from davelopez/add_item_listing_count
Add count support for listing filters
2023-05-24 08:12:06 +02:00
Dannon eb29c292d0 Merge pull request #16132 from jvanbraekel/patch-2
Fix : Ignore error messages for admin created accounts
2023-05-23 16:54:49 -04:00
Martin Cech 8b926e676f Merge pull request #16128 from mvdbeek/fix_bulk_endpoint_with_related_filter
[23.0] Fix related-hid in bulk contents API
2023-05-23 11:12:22 -04:00
Dannon 9e970f22ce Merge pull request #15225 from hujambo-dunia/upgrade-tags-multiselect
Upgraded to new multiselect Tags component for Workflows, DatasetList, Attributes
2023-05-23 08:02:47 -04:00