It is pretty cool to use hooks and an alternative tool submission
endpoint, but this is less invasive. We'd have to do this anyway for
cases where the upload is already on the server and the pre-finish hook
doesn't fire.
Replaces our custom Sentry WSGI middleware with middleware shipped by
sentry-sdk. Adds sentry-sdk ASGI middleware. Our custom sentry
middleware also allowed logging slow requests to sentry. I have dropped
this for now, and if we still want this in the future, we should
probably implement this as a custom logging middleware instead, which
would automatically appear in Sentry as well.
We used to hardcode the log level for events to WARNING, and the Sentry
default is ERROR now, which I think is a good idea. I've made this
configurable using the sentry_event_level config variable.
It does not seem to be possible to connect multiple dsn's in the same
app, unless we start hacking
(https://github.com/getsentry/sentry-python/issues/198), so I dropped
the custom_dsn from the sentry error reporting plugin (which has been
broken anyway, so shouldn't be a big deal).
David has taken on the migration to fastAPI as his first big project
within the Galaxy codebase and has gained a very good understanding of
Galaxy's backend and the new server stack. His PRs are well-crafted and
contain rigorous tests.
David is also the maintainer of the [Galaxy language
server](https://github.com/galaxyproject/galaxy-language-server), has
presented his work at this years' GCC and is a member of the backend
working group. So I'm proposing to add David to the committers group.
Oleg has contributed many large pieces of new and modernized frontend
components as well as complementary backend changes. He has included
many tests for new and old components, is an important member of the
UI-UX and testing working groups and has presented his work at multiple
GCC conferences. So let's make Oleg an official member of the committers
group.
make runnable from pr. Still need to debug
divs out
tree
broken into components
cleaning
formatting, file names, jest tests
jest
removed image files, will be retrieved via npm or separate repo
update
plugin via webpack
webpack plugin
change to plugin to prevent repeated image downloading
update
add actual page accessible from help and registration
Full draft
jest fix, next to make package customizeable
yarn lock
fix
update
Update
Refactor from here for the confiuration stuff -- this displays the bundle
drop plugin_build_hash -- these should never be committed
Update plugin gitignore
Oops, left in a debug
mvdbeek