Commit Graph
35 Commits
Author SHA1 Message Date
John Chilton 528497f7c4 Refactor galaxy.web.security into galaxy.security.idencoding.
I want to be able to use this class in galaxy.model and it doesn't have any dependnecies on "web" stuff so I'd like to move it out of galaxy.model and into galaxy.security. galaxy.model shouldn't have dependencies on galaxy.web (and doesn't after the recent 976f5ad367), so this pre-emptively ensures it doesn't require these dependencies for https://github.com/galaxyproject/galaxy/pull/7367.

This has the benefit of also eliminating any galaxy.web dependencies from the generic test base file (test/base/testcase.py) which has long been a goal of mine as well.

There are places we legimately use ID encoding and decoding for security (i.e. job files API) but for the most part it doesn't provide security for API endpoints and this causes confusion repeatedly, so I've started the process of renaming the contained class SecurityHelper to something I feel makes it clearer this is just about encoding and decoding IDs.
2019-03-19 14:28:31 -04:00
John Chilton 5f3f792f6f Unification of Galaxy configuration parsing for scripts/* 2018-03-23 16:14:49 -04:00
Nicola Soranzo bd88524a10 Fix import order and Python3 compatibility 2017-08-18 12:35:04 +01:00
Nicola Soranzo 4e75635d62 Use log.warning() instead of deprecated warn() 2017-08-18 12:35:04 +01:00
Nicola Soranzo 21b44bf348 Fix all E201 and E202 style errors
using the following command:
```
autopep8 -i -r --exclude $(sed -e 's|^|./|' -e 's|/$||' .ci/flake8_blacklist.txt | paste -sd,) --select E201,E202 .
```
2017-08-17 11:35:39 +01:00
Max Schaefer 43ddd47320 Add missing var declarations.
In all these cases, a variable was not declared to be a local using `var` (and hence was implicitly interpreted as a global variable), but all uses of that variable were preceded by a definition within the same function, suggesting that the variable was, in fact, meant to be local, not global.
2017-08-16 15:22:42 +01:00
Nicola Soranzo 1d17a29c79 Fixes for pycodestyle 2.2.0 2016-11-15 16:56:50 +00:00
anuprulez 0d915ce131 Adding maximize/minimize feature to the communication channel 2016-07-14 14:11:44 +02:00
anuprulez 464e9a4261 Fixed issue with Firefox auto scrolling 2016-06-19 17:45:30 +02:00
anuprulez 008220d88d Adjusted the vertical position of gravatar icons 2016-06-19 15:47:09 +02:00
anuprulez feb00567e4 Adjusted the vertical position of gravatar icons 2016-06-19 15:44:20 +02:00
Bjoern Gruening 10c2764f09 add the identicon to gravatar 2016-06-19 13:21:26 +02:00
Bjoern Gruening e477d728d4 do not show gravatar for server messages 2016-06-19 10:30:45 +02:00
anuprulez c017b51666 Fixed UI issues and log deletion functionality in main tab 2016-06-19 02:29:20 +02:00
Bjoern Gruening b690abb46a make chat view a little bit more compact and fix bug in displaying "me" messages 2016-06-19 00:56:40 +02:00
Bjoern Gruening 4a304b63b1 fix pep8 2016-06-19 00:56:10 +02:00
Eric Rasche 83e61f1ca4 Support gravatar and rework template 2016-06-18 19:12:37 +00:00
anuprulez b8a92a3f80 Fixing issue with no persistent rooms 2016-06-18 17:20:38 +02:00
Bjoern Gruening 5ed647e34f release preparation 2016-06-18 10:33:03 +02:00
anuprulez 111a1c6222 Fixing the issue with persistent room names with spaces, adding fancy scroll bar, buttons instead of links for persistent rooms and UI changes for message area 2016-06-14 20:03:58 +02:00
Bjoern Gruening f034f1778b make the communication window more packed 2016-06-14 00:00:48 +02:00
anuprulez 074fefeda2 Adding features-space enabled chat room names, ctrl+l for chat log deletion, removing delete icon, smooth transition on window load and code cleanup 2016-06-13 20:48:42 +02:00
anuprulez 80ee76cb39 Adding persistent rooms from config 2016-06-11 16:32:34 +02:00
Bjoern Gruening f75189aaaa style cleanups 2016-06-10 22:34:20 +02:00
anuprulez 0cd28c7251 Added global chat rooms 2016-06-10 20:27:27 +02:00
Bjoern Gruening 043b129c91 Merge branch 'rt_comm' of https://github.com/bgruening/galaxy into rt_comm 2016-06-09 15:00:25 +02:00
Bjoern Gruening 74e3e05034 fix js bug 2016-06-09 15:00:01 +02:00
Bjoern Gruening 6bc64e7426 enhance documentation 2016-06-08 15:28:16 +02:00
Bjoern Gruening 4d186982ce fix a few bugs, we should now be back to buisness 2016-06-08 11:55:50 +02:00
Bjoern Gruening a4970e71cf adjust path to galaxy-lib 2016-06-08 10:26:22 +02:00
Bjoern Gruening 0bff02f95d move everything under scripts/communication 2016-06-08 10:24:06 +02:00
Eric Rasche c4d11500ac Refactor to not use client provided usernames 2016-06-07 22:14:07 +00:00
Eric Rasche e08a7cd39a Separate out into three files for legibility 2016-06-07 21:16:37 +00:00
anuprulez 009cbe4cb4 added horizontal scroll in case of multiple tabs/rooms 2016-06-07 02:14:58 +02:00
Remi Marenco 656b2c5c68 Move the html template into a dedicated folder + Add info about button online/offline 2016-06-05 11:14:35 -04:00