Sergey Golitsynskiy has been a very active contributor to the Galaxy
code base and ecosystem (ansible-galaxy, sequence-utils, iuc) during the
last year. His contributions are of high quality and contain appropriate
tests and documentation and it is a pleasure to review Sergey's
contributions.
I propose that we add Sergey to the Galaxy committers group so that we
can benefit from his experience and skills.
Use 'kind/refactoring' for refactoring AND any kind of code cleanup. The
'area/cleanup' is removed as redundant and not really describing a
"focus area" or "domain" (as per description of area labels).
There's a considerable amount of work done on Galaxy's configuration
system, from definition in the schema to loading and processing
configuration options, to handling configuration files. Currently, there
is no easy way to tag this: the "area" label that has been used is
"admin", but I don't think that's correct: modifying how configuration
is processed by the system is very different from how it is utilized by
the user.
I realize that would add yet another option when tagging an issue or PR,
but I think the benefit of accurately tagging that work outweighs a
little bit of added complexity. I'll be happy to retag relevant issues and
PRs (for the past several months or even 2019, maybe?) if this is approved.
- Add some labels that were added on GitHub, but not here:
- authentication
- client-build
- compliance
- Rename `system` to `scripts`, since this was the original (I think)
and `system` is too generic
- Remove unused `roadmap`, we use GitHub `Projects` now
- Add some labels that have been added to Github but not this list (tool-dependencies, i18n, security).
- Add subworkflows which was added to Github as ``area/subworkflows`` but which I think should be ``area/workflows/subworkflows``.
- Add various specific testing areas (integration, selenium, and api) and a general testing area for bugs and enhancements for other parts of testing.*
- Add labels I think should be there but aren't (cwl, objectstore, upload, webhooks)
* I know there is a kind/testing, but I initially thought it should be an area and I still do. I'm either making enhancements or bug fixes to testing - I think ``kind/bug``, ``kind/enhancement``, and ``kind/refactoring`` apply to the ``area`` of testing. Maybe the new more specific areas for testing make that clear? I wanted to see all the recent Selenium changes but I didn't have a real clear way to do that without this. Maybe a compromise if others haven't come around to my way of seeing things is to keep the area sub-types of testing (e.g. ``area/testing/selenium``) but drop ``area/testing`` from this list.
Marius has been an indispensable member of the Galaxy community for a while - his contributions to tools, planemo, and ansible roles have been signficant and invaluable.
However over the last several months he has taken a very active role on the Galaxy central code base itself. He has worked through a number of very intricate bugs to tool shed, tooling, and workflow code - consistently providing high quality and important bug fixes. Beyond that he has made signficant enhancements to the testing of Galaxy and workflow available to tool developers leveraging local tool sheds. He also is very active in the review of issues and pull requests, perhaps the most important role of Galaxy committer group members.
Ross Lazarus has done a lot for Galaxy for a long time and has been a fantastic presence in the community. He is now retired and has no intention of touching the code or reviewing pull requests so I think it is best to remove him from the committers list. I have contacted him to confirm this and he has no problem with his removal from this group.
Just to reiterate, this isn't a condemnation of any kind, from the organization policies - "Periodically, active members may review this group and request inactive members are removed - this should not be interpreted as a condemnation of these inactive members but merely as a reflection of a desire to keep this group focused enough to remain effective."
Enis Afgan