Commit Graph
566 Commits
Author SHA1 Message Date
mvdbeek b5b6fbd979 Relax validation requirement for non-sample identifiers
and relax test.
2026-01-12 19:36:15 +01:00
John Chilton 0addb6a639 Merge remote-tracking branch 'origin/release_25.1' into merge_25_1 2025-12-23 09:47:17 -05:00
John ChiltonandClaude Opus 4.5 c9ad0def06 Filter sample sheet collections by column_definitions compatibility
Backend:
- Add column_definitions_compatible() in sample_sheet_util.py
- Filter incompatible collections in match_collections()
- Include column_definitions in HDCA options response

Frontend:
- Add column_definitions to DataOption type
- Check compatibility in canAcceptSrc for drag/drop

Fixes #21472

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 11:27:15 -05:00
Ahmed Awan 1979e59234 Merge remote-tracking branch 'upstream/release_25.1' into merge_25.1_into_dev_de 2025-12-17 09:13:17 +05:00
mvdbeek 42183a6cf7 Maintain column definitions on map over 2025-12-16 11:28:00 +01:00
mvdbeek b4f9428bfa Merge branch 'release_25.1' into dev 2025-12-12 17:35:46 +01:00
mvdbeek e63ac527a0 Maintain columns on sample sheet map over 2025-12-12 08:27:39 +01:00
Nuwan Goonasekera e7cc7e90f8 Remove unused imports and make format 2025-12-02 22:13:29 +05:30
Nuwan Goonasekera 1177e7ef83 Use iat frmo acccess_token if possible and add more tests for migration 2025-12-02 22:13:29 +05:30
Nuwan Goonasekera b4e904524a Drop custos table on upgrade and restore data on downgrade 2025-12-02 22:13:29 +05:30
Nuwan Goonasekera a4b3a1d4fe Refactor migration scripts 2025-12-02 22:13:29 +05:30
Nuwan Goonasekera b7006d484f Run isort to fix import error 2025-12-02 22:13:29 +05:30
Nuwan Goonasekera 7cad9915ec Fix mypy type errors in migration scripts 2025-12-02 22:13:29 +05:30
Nuwan Goonasekera f8d07f65d8 Fix alembic down revision and lint errors 2025-12-02 22:13:29 +05:30
Nuwan Goonasekera 25c669ab9b Add migration scripts and tests 2025-12-02 22:13:29 +05:30
Nuwan Goonasekera 666491a4e4 Also remove defunct custos vault 2025-12-02 22:13:28 +05:30
John Chilton ded7f0b567 Try to improve error messages for workbook upload parsing problems. 2025-10-30 10:59:58 -04:00
Matthias Bernt 8da1d47118 fix unit test
the extraction does not create the `crate/` dir automatically, but just
extracts to the given path.
2025-09-22 15:01:52 +02:00
John Davis 763c859530 Ignore type error: function is defined in sniff.py 2025-09-05 14:00:29 -04:00
Keith Suderman d0b4b9a1b4 Rebase with upstream changes 2025-09-05 13:22:19 -04:00
Keith Suderman 14188b8402 Run make format to fix linting errors 2025-09-05 11:27:40 -04:00
Keith Suderman b9f3b1f552 Simplify unit tests and add test data files. 2025-09-04 19:34:42 -04:00
Keith Suderman 1cf079b56d Fix Ipynb datatype sniffer and add unit tests. 2025-08-22 11:23:08 -04:00
davelopez 6a7bf2454b Fix file source initialization by converting root LocalPath to string
As the TestPosixConfiguredFileSources expects a string as root argument as well as the pydantic model for PosixFilesSource
2025-08-18 11:21:05 +02:00
mvdbeek ec7929c742 Construct CTEs using sqlalchemy core 2025-08-11 17:17:15 +02:00
mvdbeek 2924f29a1e Use NamedTupe for collection state summary 2025-08-11 17:17:13 +02:00
mvdbeek c2ddea2217 Implement touch collection update time CTE 2025-08-11 17:17:10 +02:00
mvdbeek e83e6b72a1 Return states and deleted status with HDCA 2025-08-11 10:32:11 +02:00
Nicola Soranzo 7f89e0eab9 Code cleanups from pyupgrade
Found by running:

```
make pyupgrade
ruff check --fix .
ruff check --preview --unsafe-fixes --select=F401 --fix .
make format
make update-client-api-schema
```

The bulk of the changes are replacements of typing deprecated aliases
such as `Dict` and `List` with the standard library classes. These
aliases became redundant in Python 3.9 when the corresponding
pre-existing classes were enhanced to support `[]`, see
https://docs.python.org/3/library/typing.html#deprecated-aliases

Also:
- Update the `pyupgrade` Makefile target to use `--py38-plus` for the
  packages needed by Pulsar, including the new galaxy-tool-util-models
  package.
2025-07-31 11:17:22 +01:00
Nicola Soranzo e2777065eb Merge branch 'release_25.0' into dev 2025-07-30 17:45:20 +01:00
John Chilton 5447f98289 Rework sample sheets to use POSTs instead of GETs.
Marius outlines why in the review of the PR.
2025-07-28 13:43:14 -04:00
John Chilton d26605517e Implement sample sheets. 2025-07-25 11:46:59 -04:00
John Chilton 8947cf8051 Generalize fetch workbook parsing on backend.
Can now read a bunch of CSV/TSV files as easily as excel files.
2025-07-25 11:46:24 -04:00
John Chilton 316d9817a8 Validate workflow inputs more directly on the backend. 2025-07-25 11:46:24 -04:00
Leonid Kostrykin 65e5ed0d12 Revert "Merge pull request #20464 from mvdbeek/drop_num_unique_values"
This reverts commit 6fe8a7bf6d, reversing
changes made to 8903af6964.
2025-07-17 14:38:18 +02:00
Nicola Soranzo 99e352a3d0 Merge branch 'release_25.0' into dev 2025-06-22 15:26:46 +01:00
John Chilton 85d634ae9f Implement fetch workbooks. 2025-06-19 22:54:56 -04:00
mvdbeek 6231f4feb0 Remove `num_unique_values` tiff metadata element
This was added in https://github.com/galaxyproject/galaxy/pull/18951 but
it's memory consumption scales with input size. On a 5.5GB TIFF file
this consumed a peak of 18GB of memory.

@kostrykin added a workaround for the memory consumption in
https://github.com/galaxyproject/galaxy/pull/19830, but this now very
slow.

Besides improving the efficient, Perhaps there is a more gentle way to approach

> Many tools assume that images are binary, or label maps, for example, and it makes no sense to run those tools on other images.

?

Could those tools just error out, and/or consume a different datatype ?
Do we need the full unique values, or is it ok to just check if it's
more than `n` unique values ?
2025-06-15 11:44:10 +02:00
John Chilton b18f0708f7 Implement DatasetSource.requested_transform.
Should be distinct from transforms apply.
2025-06-12 18:01:30 +02:00
John Chilton cb2d5cc611 Implement nested collection test in test_model_discovery. 2025-05-14 12:57:29 -04:00
John Chilton 219796f049 Implement paired_or_unpaired collections, list wizards. 2025-05-09 17:39:38 -04:00
John Chilton 9c7770d3aa More dataset collection unit testing... 2025-05-09 16:38:20 -04:00
John Chilton 0b3b408b50 Migrate doctests to unit tests. 2025-05-09 16:38:19 -04:00
Eli Chadwick 70cd4511b0 avoid caching in python 3.9 2025-05-07 10:45:12 +01:00
Eli Chadwick f9688c43a7 isort 2025-05-07 10:45:11 +01:00
Eli Chadwick 09458577b2 linting 2025-05-07 10:45:10 +01:00
Eli Chadwick 007541d1e3 add version check to xfail 2025-05-07 10:45:10 +01:00
Eli Chadwick a4fbf706b4 fix version check 2025-05-07 10:45:09 +01:00
Eli Chadwick bd4da7a339 fix problem with non-existent files failing validation 2025-05-07 10:45:08 +01:00
Eli Chadwick d1906cbf54 work around dependency issues 2025-05-07 10:45:08 +01:00