Commit Graph
6116 Commits
Author SHA1 Message Date
Dannon Baker 2c0c0063c7 Fix dropdown popping out of line in the toolshed server selection
interface
2019-10-23 08:56:28 -04:00
Martin Cech 9a4d190192 improve UX of clearing search terms
by providing tooltip,
and removing the disabled trigger, so it gets a natural tabindex
2019-10-22 15:19:28 -04:00
Martin Cech ba4e0bf968 add caret to toolsheds dropdown in admin menu
so it is clear this is a menu
2019-10-22 14:54:33 -04:00
Martin Cech bc703c58e6 remove inherited overflow
this broke libraries, and generally shouldn't be used
with such scope I believe
2019-10-10 14:37:03 -04:00
Dannon Baker 747156d03b Client format 2019-10-07 13:55:15 -04:00
Sebastian Kapust 870510e58e Fix visibility of tool panel footer 2019-10-07 13:53:33 -04:00
John Chilton cd5ebd2757 Add missing help for invocation report syntax. 2019-10-03 17:41:27 -04:00
Martin Cech 417ba50ed6 Merge pull request #8683 from jmchilton/reports_editor_fixes
[19.09] Small fixes for issues with the invocation report editor.
2019-09-30 10:50:20 -04:00
Dannon Baker d50f3250d0 format client 2019-09-26 15:07:43 -04:00
Dannon Baker 3af57fe951 Fix typo in workflow invocations admin header. 2019-09-26 15:06:47 -04:00
John Chilton e7cb6ec1ae Drop "Manage" from admin Workflow Invocation link.
Requested by @martenson on https://github.com/galaxyproject/galaxy/pull/8664. Also drop Manage in "Manage Jobs" link for symmetry? Or should I not do that?
2019-09-23 12:34:20 -04:00
Aysam Guerler 0f93ef9dab Merge pull request #8664 from jmchilton/invocation_monitor
[19.09] Bug fix - add missing invocation state tracking, report link.
2019-09-23 12:10:58 -04:00
John Chilton 7f265aca7a ReportEditor - hack around editor pushing the toolbar off screen 2019-09-20 08:17:24 -04:00
John Chilton 78f457e0cc ReportEditor - Handle initially empty report. 2019-09-20 08:17:21 -04:00
John Chilton a0881c9e31 Refactor invocation job summary to vuex. 2019-09-18 14:40:55 -04:00
John Chilton e660096b24 Refactor invocation state handling to vuex. 2019-09-18 10:51:25 -04:00
John Chilton 6fcb1b661a Bug fix - add missing invocation state tracking, report link.
This is imperfect and rough but provides a bare minimum implementation of a bunch of important functionality that the absence of represents serious enough usability problems that I think it belongs in 19.09.

For admins, there is no way to track workflow invocations being scheduled currently and we routinely ask people to set the state on the workflow invocation column with SQL directly. This is a serious issue and this commit provides a new list in the admin interface of active invocations with state tracking (for steps scheduled and jobs executed) with a cancel button for each.

The same component that gets embedded in the grid for state tracking is also now added to the landing page after workflows are executed. Each invocation gets its own tracking widget - we don't name workflow invocations so the creation time is used to distinguish between invocations (we could probably iterate on this and do something with inputs?). Even if ephemeral, this provides users a way of tracking workflow invocation progress and notifying them if scheduling fails. Previously we had no such notifications. It also provides them a way to cancel workflow invocations (less of a bug then these other points, but still important).

Once the workflow has finished executing, an invocation report link will appear - again the lack of a link inside of the app to the invocation report added in 19.09. Previously there was no link in the UI for this report.
2019-09-18 10:49:17 -04:00
John Chilton 7894748636 Format client for release_19.09 branch. 2019-09-18 10:18:39 -04:00
John Chilton fb963976c2 Remove debug logging for entry points. 2019-09-17 15:29:50 -04:00
John Chilton 5a3dae5220 Implement progress bar for state tracking. 2019-09-17 15:29:49 -04:00
John Chilton dca94aca2d Use new /api/invocations API endpoint to de-hack invocation report URL. 2019-09-17 15:29:49 -04:00
John Chilton b5c7eccba0 Refactor collection state description into a Vue component. 2019-09-17 15:29:49 -04:00
guerler 69bd851a63 Reset input in toolshed search input on escape key 2019-09-13 12:12:55 -04:00
guerler 33399500c6 Add clear search option to toolshed search text field 2019-09-12 14:54:54 -04:00
Martin Cech 638e5da1a9 Merge pull request #8622 from guerler/resilience_missing_toolshed
[19.09] Allow users to switch toolsheds if main toolshed is unavailable
2019-09-12 14:42:31 -04:00
guerler 729c40fd3c Use quotes to wrap category search terms in toolshed client 2019-09-11 15:54:08 -04:00
guerler 008246beca Add category search option to toolshed component 2019-09-11 15:41:01 -04:00
guerler e1f1bad807 Allow user to switch to alternative toolshed if main toolshed is offline 2019-09-11 15:36:36 -04:00
Martin Cech 17720c7aa9 increase default search pagesize
one of the side effects is that the infinite scrolling will never trigger
if you are able to render all 10 results
2019-09-10 16:27:04 -04:00
Dannon Baker 36a47514d9 Add openlayers to viz plugin autobuilder 2019-09-06 16:11:49 -04:00
Dannon b70871ad65 Merge pull request #8585 from guerler/fix_toolshed_error_parsing
Fix parsing of errors in toolshed interface
2019-09-06 15:31:38 -04:00
Dannon 431c96df2b Merge pull request #6891 from anuprulez/annotate_images_viz
Visualization for free style image annotation
2019-09-06 15:30:56 -04:00
John Chilton 6264871fe8 Merge pull request #8574 from bgruening/it_cleanups
Interactive tools cleanup
2019-09-06 15:09:32 -04:00
Dannon Baker 9d1e784868 Alternate approach to plugin building; this should be useful as a stepping stone towards moving these out of the repo completely, and it'll work *right now*. 2019-09-06 14:56:10 -04:00
guerler b8c498e563 Fix parsing of unexpected errors in toolshed interface 2019-09-06 14:52:56 -04:00
Martin Cech f0488f6528 Merge pull request #8579 from guerler/restore_section_labels
Modify tool panel section text color, size and margin to improve readability
2019-09-06 12:03:09 -04:00
Martin Cech ad2f58adf3 use font weight to differentiate between tool title and desc 2019-09-06 11:58:25 -04:00
guerler ae498d1dde Modify tool panel section text color and margin to improve readability 2019-09-05 16:57:05 -04:00
Martin Cech 5c78159d61 Merge pull request #8575 from dannon/multipanel-click-fix
Fix menu option classes (and thus event bindings) for histories in th…
2019-09-05 15:55:58 -04:00
Dannon Baker ac6539e71c Fix menu option classes (and thus event bindings) for histories in the multipanel. 2019-09-05 10:38:17 -04:00
John Chilton 974d6520a4 Merge pull request #8368 from inkuzmin/tools-panel-vue
Porting Tools Panel to Vue.js (resolves #8262)
2019-09-05 10:37:36 -04:00
John Chilton 928a7944e0 Cleanup some code not used after #8368. 2019-09-04 14:19:37 -04:00
Bjoern Gruening 5232aefddd RT to IT 2019-08-31 13:33:29 +02:00
Martin Cech fb72089739 Merge pull request #8530 from abretaud/library_tags
Add API to tag library datasets
2019-08-30 14:20:57 -04:00
Martin Cech 21c7764875 Merge pull request #8543 from jmchilton/invocation_reports_4
Implement workflow invocation reports (🎉 syntax)
2019-08-30 13:52:21 -04:00
guerler 38ec505875 Format client 2019-08-30 12:10:16 -04:00
John Chilton fa637518e8 Implement yet another syntax for Galaxy Markdown.
The community took a vote (https://github.com/galaxyproject/galaxy/pull/8511#issuecomment-525886525) and the overwhelming favorite was this programming style declaration of a vaguely C-ish language embedded in quote fenced blocks.
2019-08-30 09:46:14 -04:00
John Chilton 664ab71653 Rework toward more RMarkdown-y syntax for Galaxy Markdown. 2019-08-30 09:43:15 -04:00
John Chilton ad650897d6 Implement workflow invocation reports.
Implement markdown backend and frontend components as well generator plugin framework to allow customizable workflow invocation reports.

Architectural Choices on the Client

Old-style embedded objects vs components

In theory, this could make really nice use of excellent VueJS components for dataset display, dataset collection display, workflow display, etc.. These aren't available yet, we don't even really have Backbone stuff that exist very well outside history panels, so this re-uses "components" from Galaxy Pages for datasets and reuses the collection display for history panels as a stand-alone display for collections (I got this trick from DIsplayStructured.vue). This isn't ideal and I know that but at least reusing things this way will provide a path forward for migrating both pages and this new Markdown language (which could easily replace or co-exist with pages HTML someday) together seamlessly as the real modern components become available and doesn't increase the overall work needed to integrate newer style components. In fact, this might even be the impetus for creating and polishing more of these components.

markdown-it vs markdown-it-vue

I tried this with markdown-it-vue also but it added very little in terms of reducing client code, obscured entirely how to attach plugins to the markdown rendering process, and brought in many, many more extra packages that we don't need or want.

Given there is no representation of invocations in the GUI and not editor for reports config this is a bit challenging still. But here is goes:

- Source Galaxy's virtualenv.
- Login to a user and grab an API key, set in the following command:
- ``GALAXY_TEST_EXTERNAL=http://localhost:8080 GALAXY_TEST_USER_API_KEY=38175dfc69d9009992b69efcca8b209b pytest test/api/test_workflows.py::WorkflowsApiTestCase::test_workflow_invocation_report_custom``
- In the web browser go to http://localhost:8080/api/invocations and grab the latest invocation ID. Replace it in the follow query string.
- Navigate to http://localhost:8080/workflows/invocations/report?id=c887f1d0da42bdfe
2019-08-30 09:43:01 -04:00
John Chilton 10aeb57ca4 rebuild yarn lock for markdown... 2019-08-30 09:37:18 -04:00