Commit Graph

54 Commits

Author SHA1 Message Date
Nicola Soranzo 4c6982be9d Add Python string formatting best practices
Also refine text.
2023-06-27 12:41:52 +01:00
Nicola Soranzo ab5a1e2a69 Document documentation 2023-03-27 16:01:20 +01:00
Nicola Soranzo 7fee81607c Add linting with ruff
ruff (https://github.com/charliermarsh/ruff) is a new and extremely fast
Python linter, written in Rust.
Ruff can be used to replace Flake8 (plus a variety of plugins), isort,
pydocstyle, yesqa, eradicate, pyupgrade, and autoflake.
Here ruff is added to our current linters (flake8, flake8-bugbear and isort)
while we assess its reliability.
I've not enabled the isort rules because many of the options we use are not
implemented yet. I have instead enabled the pyupgrade rules (a tool which I
run manually every few months).

Also:
- Fix new linting errors reported by ruff.
2023-01-16 14:34:56 +00:00
Nate Coraor 7c5f1c9319 Merge pull request #14503 from mvdbeek/place_security_document_in_canonical_location
Place security policy in canonical location
2022-09-07 11:44:29 -04:00
Nicola Soranzo ebf59a0b52 Update location of flake8 configuration 2022-08-28 19:11:09 +01:00
mvdbeek 989fc135e1 Place security policy in canonical location 2022-08-24 17:29:18 +02:00
Nicola Soranzo 7920f49236 Recommend rebasing PRs over merging the target branch
A clean git histories is easier to bisect in case of issues.
2022-05-25 17:55:30 +01:00
Nicola Soranzo f74ae05cf1 Update Python formatting docs 2022-02-03 14:08:09 +00:00
Nicola Soranzo 137aad47b7 Recommend 2FA and commit signing 2021-01-18 20:57:16 +00:00
Nicola Soranzo 887cf37994 Replace example with link to good commit
and highlight the most important points.
2020-11-17 19:31:17 +00:00
Sergey Golitsynskiy bb969be51c Add guidelines for proper commit messages 2020-10-21 14:35:34 -04:00
John Chilton d00ba4caf6 Add link to CONTRIBUTING.md as suggested by Nicola.
Updated the hub docs too just to make sure more people find their way to the slides (https://github.com/galaxyproject/galaxy-hub/pull/622).
2020-07-06 18:49:03 -04:00
Nicola Soranzo 7f569a6011 Officially allow adding new datatypes to the latest tagged release 2020-04-20 08:14:35 +01:00
Nicola Soranzo 19175c2f0e Update CONTRIBUTING.md
Co-Authored-By: Dannon <dannon.baker@gmail.com>
2020-02-04 15:44:13 +00:00
Nicola Soranzo 2ad52474c5 Apply suggestions from code review
Co-Authored-By: Dannon <dannon.baker@gmail.com>
2020-02-04 15:28:26 +00:00
Nicola Soranzo 15a797c359 Update CONTRIBUTING.md
- Update links
- Replace disappeared "Try Git" tutorial with Software Carpentry's one
- Include Python style guidelines and testing instructions from the Hub
2020-02-03 14:14:45 +00:00
Yo Yehudi 3114408017 typo fix comunity -> community 2019-07-05 16:16:56 +02:00
Dannon Baker 7d394d243b Proofreading - thanks @nsoranzo 2018-03-28 15:15:07 -04:00
Dannon Baker 334aea3adc Erase trello from Contributing. 2018-03-28 14:35:18 -04:00
Dannon Baker 05584244a7 Drop old bitbucket/galaxy/galaxy-dist reference. 2018-03-28 11:08:38 -04:00
Dannon Baker cbd7cb3cbc Reflow text 2018-03-28 10:48:08 -04:00
Dannon Baker d61268cc6d Articles are important. 2018-03-28 10:40:06 -04:00
Dannon Baker b960260a34 Mention the client README specifically in CONTRIBUTING, to make it more obvious. 2018-03-28 10:35:16 -04:00
Nicola Soranzo 0730bf8adb Remove any 2017-05-16 18:56:50 +00:00
Eric Rasche 789e48f51e Link to secpol 2017-05-16 17:37:47 +00:00
Martin Cech 224a5b3900 fix contribute pdf link 2017-03-31 20:11:30 -04:00
Martin Cech ffce14e65d change devteam to iuc 2017-03-31 20:09:07 -04:00
Björn Grüning b5fe42c462 Small changes to links and add gitter 2017-04-01 02:05:49 +02:00
John Chilton a79ae2a8c2 Align architecture slides with training-material remarkjs template.
- Copy over the training material style CSS template and add to it only what is needed.
- Cleanup style and layout handling in architecture slides markdown.
- Update generated images for white background.
- Small updates in content to architecture for recent changes (and CONTRIBUTING.md linked to from slides).
2017-02-10 15:32:58 -05:00
Michael R. Crusoe b3bad81fb2 doc tox 2015-10-15 01:50:02 -07:00
Nicola Soranzo 3f40b7ca8f Move "Handling Pull Requests" from CONTRIBUTING.md to organization.rst . 2015-09-07 19:52:48 +01:00
Nicola Soranzo 471664c269 Merge "Issues" and "Galaxy Development" from README.rst in CONTRIBUTING.md . 2015-09-07 19:24:11 +01:00
Dannon Baker 5b2e208b77 Merge pull request #574 from nsoranzo/dev
[PROCEDURES] GitHub issues, security email contact and CI testing
2015-08-15 13:10:21 -04:00
Nicola Soranzo 3df58181cd Small fixes for CONTRIBUTING.md . 2015-08-07 15:41:54 +01:00
Nicola Soranzo 86aa07d87e Require PRs to pass the CI tests. 2015-08-07 15:41:54 +01:00
Nicola Soranzo 55e0f109fc Mention GitHub issues. 2015-08-07 15:41:54 +01:00
Nicola Soranzo d9d86ee8a7 Update contact email address for security issues. 2015-08-07 15:41:54 +01:00
Eric Rasche e3f2255a09 This commit implements #382 in response to the lack of explicit language
on how reversions are to be handled. This is in response to the events
transpiring in #433 and #449.

Additionally this PR corrects the misspelling of the pluralization of
the word veto.

This is a direct follow up, per procedures with a single squashed commit, of #450.
2015-08-05 09:32:56 -05:00
Björn Grüning fc016d8e87 Merge pull request #314 from jmchilton/organization_v2
[PROCEDURES] Implement policies for committers and pull requests.
2015-06-14 19:43:02 +02:00
Dannon Baker 226b05db8a Update galaxy-lab to primary mailing list in CONTRIBUTING 2015-06-05 13:00:36 -04:00
John Chilton 90fe4320b8 Update language in CONTIRBUTING.md...
.. clarifying that people must be added or removed from the committers list one at a time. Also improve the language in that section of the document.
2015-06-05 11:07:00 -04:00
John Chilton 20e4c3d6e4 Refine procedures related to governance changes...
... based on comments made by @blankenberg.
2015-06-04 16:13:35 -04:00
John Chilton 3316b25432 Small clarification to CONTRIBUTING.md recommended by @nsoranzo.
https://github.com/galaxyproject/galaxy/pull/295#discussion_r31454497.
2015-06-01 14:45:28 -04:00
John Chilton 0fe60d49ba Adjust CONTRIBUTING.md security language per suggestion of @martenson. 2015-06-01 14:08:50 -04:00
Martin Cech ac93879823 typo fix 2015-05-30 19:33:19 -04:00
Dannon Baker 73aa35b63c A few minor tweaks to organization/contributing doc. 2015-05-30 08:54:47 -04:00
John Chilton ef74d06904 Implement policies for commmitters and pull requests.
- State and clarfiy my (@jmchilton's) understanding of existing informal pull request policies.
- Add a list of committers who should have "commit" access to the repository according to my understanding of the team meeting held on 5/28/2015.
- Add language describing how the Galaxy project might manage commit access and project governance going forward in accordance with my understanding of the team meeting discussion.

This fills in a lot of gaps left by informal policies and informal discussions and I am eager to see much discussion on each of these topics. Much of the language and structure is borrowed with heavy modification from the Django and Apache variants of these documents.

Also - congrats to @nsoranzo, @erasche, and @bgruening who the team unanimously voted to grant commit access to.
2015-05-30 07:09:44 -04:00
Nicola Soranzo 8254caba54 Update many links which redirect to https. 2015-04-09 20:37:03 +01:00
John Chilton 2650d09175 Document new policy - all changes should come through a PR. 2015-03-29 09:21:46 -04:00
John Chilton 7d5dde8870 More CONTRIBUTING.md modifications for switch to github. 2015-03-29 09:19:38 -04:00