diff --git a/lib/galaxy/web/controllers/history.py b/lib/galaxy/web/controllers/history.py index 376db342a43..f9a9bc45085 100644 --- a/lib/galaxy/web/controllers/history.py +++ b/lib/galaxy/web/controllers/history.py @@ -161,7 +161,7 @@ class HistoryController( BaseController ): status, message = self._list_undelete( trans, histories ) trans.sa_session.flush() # Render the list view - return self.stored_list_grid( trans, status=status, message=message, template='/history/stored_grid.mako', **kwargs ) + return self.stored_list_grid( trans, status=status, message=message, template='/history/grid.mako', **kwargs ) def _list_delete( self, trans, histories ): """Delete histories""" n_deleted = 0 @@ -239,14 +239,14 @@ class HistoryController( BaseController ): if operation == "clone": if not id: message = "Select a history to clone" - return self.shared_list_grid( trans, status='error', message=message, template='/history/shared_grid.mako', **kwargs ) + return self.shared_list_grid( trans, status='error', message=message, template='/history/grid.mako', **kwargs ) # When cloning shared histories, only copy active datasets new_kwargs = { 'clone_choice' : 'active' } return self.clone( trans, id, **new_kwargs ) elif operation == 'unshare': if not id: message = "Select a history to unshare" - return self.shared_list_grid( trans, status='error', message=message, template='/history/shared_grid.mako', **kwargs ) + return self.shared_list_grid( trans, status='error', message=message, template='/history/grid.mako', **kwargs ) ids = util.listify( id ) histories = [] for history_id in ids: @@ -260,7 +260,7 @@ class HistoryController( BaseController ): message = "Unshared %d shared histories" % len( ids ) status = 'done' # Render the list view - return self.shared_list_grid( trans, status=status, message=message, template='/history/shared_grid.mako', **kwargs ) + return self.shared_list_grid( trans, status=status, message=message, template='/history/grid.mako', **kwargs ) @web.expose def delete_current( self, trans ): """Delete just the active history -- this does not require a logged in user.""" diff --git a/lib/galaxy/web/controllers/requests.py b/lib/galaxy/web/controllers/requests.py index ed72519375a..32f2043b3e2 100644 --- a/lib/galaxy/web/controllers/requests.py +++ b/lib/galaxy/web/controllers/requests.py @@ -152,16 +152,12 @@ class Requests( BaseController ): helptext='')) # library associated if request.library: - request_details.append(dict(label='Library', - value=request.library.name, - helptext='Associated library where the resultant \ - dataset will be stored')) + value = request.library.name else: - request_details.append(dict(label='Library', - value=None, - helptext='Associated library where the resultant \ - dataset will be stored')) - + value = None + request_details.append( dict( label='Data library', + value=value, + helptext='Data library where the resultant dataset will be stored' ) ) # form fields for index, field in enumerate(request.type.request_form.fields): if field['required']: @@ -492,18 +488,17 @@ class Requests( BaseController ): else: lib_list.add_option(lib.name, lib.id) if lib_id == 'new': - lib_list.add_option('Create a new library', 'new', selected=True) + lib_list.add_option('Create a new data library', 'new', selected=True) else: - lib_list.add_option('Create a new library', 'new') - widget = dict(label='Library', + lib_list.add_option('Create a new data library', 'new') + widget = dict(label='Data library', widget=lib_list, - helptext='Associated library where the resultant \ - dataset will be stored.') + helptext='Data library where the resultant dataset will be stored.') if lib_id == 'new': - new_lib = dict(label='Create a new Library', + new_lib = dict(label='Create a new data library', widget=TextField('new_library_name', 40, util.restore_text( params.get( 'new_library_name', '' ) )), - helptext='Enter a library name here to request a new library') + helptext='Enter a name here to request a new data library') return [widget, new_lib] else: return [widget] @@ -558,7 +553,7 @@ class Requests( BaseController ): ''' empty_fields = [] if not request.library: - empty_fields.append('Library') + empty_fields.append('Data library') # check rest of the fields of the form for index, field in enumerate(request.type.request_form.fields): if field['required'] == 'required' and request.values.content[index] in ['', None]: diff --git a/lib/galaxy/web/controllers/requests_admin.py b/lib/galaxy/web/controllers/requests_admin.py index 9f744baf5aa..a645b01a3e8 100644 --- a/lib/galaxy/web/controllers/requests_admin.py +++ b/lib/galaxy/web/controllers/requests_admin.py @@ -144,10 +144,9 @@ class Requests( BaseController ): value=str(request.user.email), helptext='')) # library associated - request_details.append(dict(label='Library', + request_details.append(dict(label='Data library', value=trans.app.model.Library.get(request.library_id).name, - helptext='Associated library where the resultant \ - dataset will be stored')) + helptext='Data library where the resultant dataset will be stored')) # form fields for index, field in enumerate(request.type.request_form.fields): if field['required']: diff --git a/templates/admin/center.mako b/templates/admin/center.mako index 5800f847c43..47a9e544ae8 100644 --- a/templates/admin/center.mako +++ b/templates/admin/center.mako @@ -17,7 +17,7 @@
Data Security and Dataset Libraries
+Data Security and Data Libraries
Security - Data security in Galaxy is a new feature, so familiarize yourself with the details which can be found here or in our data security page. The data security @@ -121,8 +121,8 @@ in the way Galaxy has behaved in the past. access - users associated with the role can import this dataset into their history for analysis.If no roles with the "access" permission are associated with a dataset, the dataset is "public" and may be accessed by - anyone. Public library datasets will be accessible to all users (as well as anyone not logged in during a Galaxy session) - from the list of libraries displayed when the "Libraries" menu item is selected. + anyone. Public data library datasets will be accessible to all users (as well as anyone not logged in during a Galaxy session) + from the list of data libraries displayed when the "Data Libraries" menu item is selected.
Associating a dataset with a role that includes the "access" permission restricts the set of users that can access it.
diff --git a/templates/admin/dataset_security/role.mako b/templates/admin/dataset_security/role.mako
index eda5a7f25a8..652d3abeb10 100644
--- a/templates/admin/dataset_security/role.mako
+++ b/templates/admin/dataset_security/role.mako
@@ -84,7 +84,7 @@ $().ready(function() {
%if len( library_dataset_actions ) > 0:
-
diff --git a/templates/admin/index.mako b/templates/admin/index.mako
index 60d6c95ecd5..4bcb65ae6b2 100644
--- a/templates/admin/index.mako
+++ b/templates/admin/index.mako
@@ -89,7 +89,7 @@
diff --git a/templates/admin/library/browse_libraries.mako b/templates/admin/library/browse_libraries.mako
index 45c199404fb..2d69717ea66 100644
--- a/templates/admin/library/browse_libraries.mako
+++ b/templates/admin/library/browse_libraries.mako
@@ -1,13 +1,13 @@
<%inherit file="/base.mako"/>
<%namespace file="/message.mako" import="render_msg" />
-<%def name="title()">Browse Libraries%def>
+<%def name="title()">Browse Data Libraries%def>
%if deleted: Deleted %endif - Libraries + Data Libraries
diff --git a/templates/admin/library/folder_permissions.mako b/templates/admin/library/folder_permissions.mako index 61f8d7aab20..de580c2eba9 100644 --- a/templates/admin/library/folder_permissions.mako +++ b/templates/admin/library/folder_permissions.mako @@ -5,7 +5,7 @@ diff --git a/templates/admin/library/ldda_edit_info.mako b/templates/admin/library/ldda_edit_info.mako index 33b7793c9b5..568c91f38cf 100644 --- a/templates/admin/library/ldda_edit_info.mako +++ b/templates/admin/library/ldda_edit_info.mako @@ -12,7 +12,7 @@ diff --git a/templates/admin/library/ldda_info.mako b/templates/admin/library/ldda_info.mako index c389d7b5220..d7ab07f45ae 100644 --- a/templates/admin/library/ldda_info.mako +++ b/templates/admin/library/ldda_info.mako @@ -20,7 +20,7 @@ diff --git a/templates/admin/library/ldda_permissions.mako b/templates/admin/library/ldda_permissions.mako index 14610490bce..6ea3a74b7a6 100644 --- a/templates/admin/library/ldda_permissions.mako +++ b/templates/admin/library/ldda_permissions.mako @@ -15,7 +15,7 @@ diff --git a/templates/admin/library/library_dataset_info.mako b/templates/admin/library/library_dataset_info.mako index 3e53bdbfabf..576336ab3b8 100644 --- a/templates/admin/library/library_dataset_info.mako +++ b/templates/admin/library/library_dataset_info.mako @@ -11,7 +11,7 @@ diff --git a/templates/admin/library/library_dataset_permissions.mako b/templates/admin/library/library_dataset_permissions.mako index f83c4aa1a9c..e99a9fc49d2 100644 --- a/templates/admin/library/library_dataset_permissions.mako +++ b/templates/admin/library/library_dataset_permissions.mako @@ -11,7 +11,7 @@ diff --git a/templates/admin/library/library_info.mako b/templates/admin/library/library_info.mako index 59b2dfff339..64e21b8fab1 100644 --- a/templates/admin/library/library_info.mako +++ b/templates/admin/library/library_info.mako @@ -5,7 +5,7 @@ diff --git a/templates/admin/library/library_permissions.mako b/templates/admin/library/library_permissions.mako index 8943e361cfe..4594ac1db5a 100644 --- a/templates/admin/library/library_permissions.mako +++ b/templates/admin/library/library_permissions.mako @@ -5,7 +5,7 @@ diff --git a/templates/admin/library/new_dataset.mako b/templates/admin/library/new_dataset.mako index 2dd770e07e2..97dc25f83fd 100644 --- a/templates/admin/library/new_dataset.mako +++ b/templates/admin/library/new_dataset.mako @@ -4,7 +4,7 @@ <% import os, os.path %> -Create new library datasets +Create new data library datasets
- This information will be displayed in the "Information" column for this dataset in the library browser
+ This information will be displayed in the "Information" column for this dataset in the data library browser
diff --git a/templates/admin/library/new_folder.mako b/templates/admin/library/new_folder.mako
index 42783a69d74..60007fd83ee 100644
--- a/templates/admin/library/new_folder.mako
+++ b/templates/admin/library/new_folder.mako
@@ -4,7 +4,7 @@
diff --git a/templates/admin/library/new_library.mako b/templates/admin/library/new_library.mako index c514d2965b3..2d6a7487f35 100644 --- a/templates/admin/library/new_library.mako +++ b/templates/admin/library/new_library.mako @@ -6,13 +6,13 @@ %endif
- Create a new library
+ Create a new data library
diff --git a/templates/history/stored_grid.mako b/templates/history/stored_grid.mako
deleted file mode 100644
index 2ddbf135c40..00000000000
--- a/templates/history/stored_grid.mako
+++ /dev/null
@@ -1,196 +0,0 @@
-<%inherit file="/base.mako"/>
-<%def name="title()">${grid.title}%def>
-
-%if message:
- - - - -%endif - -<%def name="javascripts()"> - ${parent.javascripts()} - -%def> - -<%def name="stylesheets()"> - - -%def> - -%if grid.standard_filters: -
-
-%endif
-
-
diff --git a/templates/library/browse_libraries.mako b/templates/library/browse_libraries.mako
index c52fd8a8eb7..e318daaaa72 100644
--- a/templates/library/browse_libraries.mako
+++ b/templates/library/browse_libraries.mako
@@ -1,9 +1,9 @@
<%inherit file="/base.mako"/>
<%namespace file="/message.mako" import="render_msg" />
-<%def name="title()">Browse Libraries%def>
+<%def name="title()">Browse Data Libraries%def>
-${grid.title}- Filter: - %for i, filter in enumerate( grid.standard_filters ): - %if i > 0: - | - %endif - ${filter.label} - %endfor -Libraries+Data Libraries%if msg: ${render_msg( msg, messagetype )} diff --git a/templates/library/browse_library.mako b/templates/library/browse_library.mako index af2f320042c..0ef2fae1003 100644 --- a/templates/library/browse_library.mako +++ b/templates/library/browse_library.mako @@ -2,7 +2,7 @@ <%namespace file="/message.mako" import="render_msg" /> <% from galaxy import util %> -<%def name="title()">Browse Library%def> +<%def name="title()">Browse data library%def> <%def name="stylesheets()"> @@ -211,7 +211,7 @@ class RowCounter( object ): %endfor %def> -Library “${library.name}”+Data Library “${library.name}”
diff --git a/templates/library/folder_permissions.mako b/templates/library/folder_permissions.mako index 2849d748950..2a1d39cf376 100644 --- a/templates/library/folder_permissions.mako +++ b/templates/library/folder_permissions.mako @@ -5,7 +5,7 @@ diff --git a/templates/library/ldda_edit_info.mako b/templates/library/ldda_edit_info.mako index ec7906730b7..e4311c3a3e2 100644 --- a/templates/library/ldda_edit_info.mako +++ b/templates/library/ldda_edit_info.mako @@ -12,7 +12,7 @@ diff --git a/templates/library/ldda_info.mako b/templates/library/ldda_info.mako index 3c3f514b6bd..7ba3833b783 100644 --- a/templates/library/ldda_info.mako +++ b/templates/library/ldda_info.mako @@ -19,7 +19,7 @@ diff --git a/templates/library/ldda_permissions.mako b/templates/library/ldda_permissions.mako index becc5b9e9d8..10f2ce53d94 100644 --- a/templates/library/ldda_permissions.mako +++ b/templates/library/ldda_permissions.mako @@ -15,7 +15,7 @@ diff --git a/templates/library/library_dataset_info.mako b/templates/library/library_dataset_info.mako index b82978587e0..5dc8517f712 100644 --- a/templates/library/library_dataset_info.mako +++ b/templates/library/library_dataset_info.mako @@ -11,7 +11,7 @@ diff --git a/templates/library/library_dataset_permissions.mako b/templates/library/library_dataset_permissions.mako index 619e427c636..0effe604724 100644 --- a/templates/library/library_dataset_permissions.mako +++ b/templates/library/library_dataset_permissions.mako @@ -11,7 +11,7 @@ diff --git a/templates/library/library_info.mako b/templates/library/library_info.mako index 7e98645182c..97f02812d66 100644 --- a/templates/library/library_info.mako +++ b/templates/library/library_info.mako @@ -5,7 +5,7 @@ diff --git a/templates/library/library_permissions.mako b/templates/library/library_permissions.mako index cc358fad826..2c2841da6f6 100644 --- a/templates/library/library_permissions.mako +++ b/templates/library/library_permissions.mako @@ -5,7 +5,7 @@ diff --git a/templates/library/new_dataset.mako b/templates/library/new_dataset.mako index 65c16152d66..1279af7dae0 100644 --- a/templates/library/new_dataset.mako +++ b/templates/library/new_dataset.mako @@ -16,7 +16,7 @@ @@ -68,7 +68,7 @@ %elif upload_option == 'upload_directory':
<%
- # Directories of files from the Libraries view are restricted to a
+ # Directories of files from the Data Libraries view are restricted to a
# sub-directory named the same as the current user's email address
# contained within the configured setting for user_library_import_dir
user_library_import_dir = os.path.join( trans.app.config.user_library_import_dir, trans.user.email )
diff --git a/templates/library/new_folder.mako b/templates/library/new_folder.mako
index 3179590d6a9..bdeb1a6c38f 100644
--- a/templates/library/new_folder.mako
+++ b/templates/library/new_folder.mako
@@ -4,7 +4,7 @@
diff --git a/templates/library/select_info_template.mako b/templates/library/select_info_template.mako index e3769eff025..29261553678 100644 --- a/templates/library/select_info_template.mako +++ b/templates/library/select_info_template.mako @@ -4,7 +4,7 @@ diff --git a/templates/requests/edit_request.mako b/templates/requests/edit_request.mako index 4e478bc7b5d..dc353a75598 100644 --- a/templates/requests/edit_request.mako +++ b/templates/requests/edit_request.mako @@ -58,7 +58,7 @@ $( function() {
${field['widget'].get_html()}
- %if field['label'] == 'Library' and new_library:
+ %if field['label'] == 'Data library' and new_library:
${new_library.get_html()}
%endif
diff --git a/templates/requests/new_request.mako b/templates/requests/new_request.mako
index 4af24f0804c..24e4e4921d8 100644
--- a/templates/requests/new_request.mako
+++ b/templates/requests/new_request.mako
@@ -58,7 +58,7 @@ $( function() {
${field['widget'].get_html()}
- %if field['label'] == 'Library' and new_library:
+ %if field['label'] == 'Data library' and new_library:
${new_library.get_html()}
%endif
diff --git a/templates/requests/show_request.mako b/templates/requests/show_request.mako
index 5fe02b7df9d..b8154d4b543 100644
--- a/templates/requests/show_request.mako
+++ b/templates/requests/show_request.mako
@@ -79,7 +79,7 @@
%if not rd['value']:
None
%else:
- %if rd['label'] == 'Library':
+ %if rd['label'] == 'Data library':
%if rd['value']:
${rd['value']}
%else:
diff --git a/test/functional/test_security_and_libraries.py b/test/functional/test_security_and_libraries.py
index 075c39d0a1d..4671213452f 100644
--- a/test/functional/test_security_and_libraries.py
+++ b/test/functional/test_security_and_libraries.py
@@ -1451,7 +1451,7 @@ class TestSecurityAndLibraries( TwillTestCase ):
check_edit_page2( latest_3_lddas )
self.home()
def test_195_upload_directory_of_files_from_libraries_view( self ):
- """Testing uploading a directory of files to a root folder from the Libraries view"""
+ """Testing uploading a directory of files to a root folder from the Data Libraries view"""
# admin_user will not have the option sto upload a directory of files from the
# Libraries view since a sub-directory named the same as their email is not contained
# in the configured user_library_import_dir. However, since members of role_one have
|