From f787182994b3c50e3aa25e9c36ccbebbdea90ba8 Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Sat, 23 May 2026 00:28:24 +0300
Subject: [PATCH] Add workflow module tests

---
 test/unit/workflows/test_modules.py | 116 ++++++++++++++++++++++++++++
 1 file changed, 116 insertions(+)

diff --git a/test/unit/workflows/test_modules.py b/test/unit/workflows/test_modules.py
index 6ef6f84911f..27f479587da 100644
--- a/test/unit/workflows/test_modules.py
+++ b/test/unit/workflows/test_modules.py
@@ -556,3 +556,119 @@ def __mock_tool(
 
 def _to_json(*args, **kwargs):
     return "{}"
+
+
+# _mapped_inputs_from_collection_info: reduce a MatchingCollections to
+# source-neutral per-input map-over descriptors. Workflow path is always
+# linked=True.
+
+
+def test_mapped_inputs_from_collection_info_none_or_empty():
+    assert modules._mapped_inputs_from_collection_info(None) == {}
+    assert modules._mapped_inputs_from_collection_info(bunch.Bunch(collections={})) == {}
+
+
+def test_mapped_inputs_from_collection_info_hdca_no_subcollection():
+    collection_info = bunch.Bunch(collections={"a": bunch.Bunch(id=7)}, subcollection_types={})
+
+    mapped = modules._mapped_inputs_from_collection_info(collection_info)
+
+    assert set(mapped) == {"a"}
+    descriptor = mapped["a"]
+    assert descriptor.src == "hdca"
+    assert descriptor.id == 7
+    assert descriptor.map_over_type is None
+    assert descriptor.linked is True
+
+
+def test_mapped_inputs_from_collection_info_subcollection_map_over_type():
+    collection_info = bunch.Bunch(
+        collections={"a": bunch.Bunch(id=7)},
+        subcollection_types={"a": bunch.Bunch(collection_type="paired")},
+    )
+
+    mapped = modules._mapped_inputs_from_collection_info(collection_info)
+
+    assert mapped["a"].map_over_type == "paired"
+
+
+def test_mapped_inputs_from_collection_info_dce_src():
+    dce = mock.MagicMock(spec=model.DatasetCollectionElement)
+    dce.id = 9
+    collection_info = bunch.Bunch(collections={"a": dce}, subcollection_types={})
+
+    mapped = modules._mapped_inputs_from_collection_info(collection_info)
+
+    assert mapped["a"].src == "dce"
+    assert mapped["a"].id == 9
+
+
+# _capture_workflow_tool_request_state outcome taxonomy: the function
+# returns (template, combinations, tool_request). Skipped steps and
+# unexpected capture-code defects return (None, None, None) — no
+# ToolRequest minted. Real meta-model rejections after the converter has
+# produced a structural payload mint a ToolRequest with
+# request_state == "validation_failed". trans/step are unused here;
+# collection_info=None -> no mapped inputs; resolve raises before any
+# downstream is reached.
+
+
+class _CaptureFakeTool:
+    id = "test_tool"
+    profile = "21.09"
+    parameters: list = []
+
+
+def _capture(resolve):
+    # history=None means the mint path is unreachable in these unit cases;
+    # every exercised branch returns before touching it.
+    return modules._capture_workflow_tool_request_state(
+        None, _CaptureFakeTool(), None, None, None, resolve, []
+    )
+
+
+def test_capture_skipped_conditional_step_returns_none():
+    """A falsy `when` raises SkipWorkflowStepEvaluation: nothing to capture."""
+
+    def resolve(iteration_elements):
+        raise modules.SkipWorkflowStepEvaluation
+
+    assert _capture(resolve) == (None, None, None)
+
+
+def test_capture_converter_guard_returns_none_quietly():
+    """Converter raised before request_internal was built: no ToolRequest, quiet."""
+
+    def resolve(iteration_elements):
+        raise modules.RequestInternalToWorkflowStateError("cross-product")
+
+    with mock.patch.object(modules, "log") as log:
+        assert _capture(resolve) == (None, None, None)
+
+    log.debug.assert_called_once()
+    log.warning.assert_not_called()
+
+
+def test_capture_invalid_state_returns_none_quietly():
+    """Meta-model rejection at resolve-time: no payload to record, quiet."""
+
+    def resolve(iteration_elements):
+        raise modules.exceptions.RequestParameterInvalidException("bad state")
+
+    with mock.patch.object(modules, "log") as log:
+        assert _capture(resolve) == (None, None, None)
+
+    log.debug.assert_called_once()
+    log.warning.assert_not_called()
+
+
+def test_capture_unexpected_error_returns_none_loudly():
+    """Capture-code defect: drop the partial payload, surface at warning."""
+
+    def resolve(iteration_elements):
+        raise RuntimeError("capture bug")
+
+    with mock.patch.object(modules, "log") as log:
+        assert _capture(resolve) == (None, None, None)
+
+    log.warning.assert_called_once()