From 5f7601795aea8bd1ab1080f3004b142934981f53 Mon Sep 17 00:00:00 2001
From: Laila Los <44241786+ElectronicBlueberry@users.noreply.github.com>
Date: Wed, 14 Sep 2022 15:56:24 +0200
Subject: [PATCH 01/25] add heading classes
---
client/src/style/scss/ui.scss | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/client/src/style/scss/ui.scss b/client/src/style/scss/ui.scss
index 4437da080b7..f018f87a339 100644
--- a/client/src/style/scss/ui.scss
+++ b/client/src/style/scss/ui.scss
@@ -477,3 +477,20 @@ $ui-margin-horizontal-large: $margin-v * 2;
.flex-gapx-1 {
column-gap: 0.25rem;
}
+
+/* Heading Sizes */
+.h-large {
+ font-size: $h1-font-size;
+}
+
+.h-medium {
+ font-size: $h2-font-size;
+}
+
+.h-small {
+ font-size: $h3-font-size;
+}
+
+.h-text {
+ font-size: $font-size-base;
+}
From 74ea3649ba3aa0fbc22b3c88a3119f0f96b08783 Mon Sep 17 00:00:00 2001
From: Laila Los <44241786+ElectronicBlueberry@users.noreply.github.com>
Date: Wed, 14 Sep 2022 15:56:41 +0200
Subject: [PATCH 02/25] change heading default sizes
---
client/src/style/scss/theme/blue.scss | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/client/src/style/scss/theme/blue.scss b/client/src/style/scss/theme/blue.scss
index 3e0c3282cbf..b9a69531795 100644
--- a/client/src/style/scss/theme/blue.scss
+++ b/client/src/style/scss/theme/blue.scss
@@ -88,10 +88,10 @@ $font-size-base: 0.85rem; // default 1rem
// Header font sizes
$h1-font-size: $font-size-base * 2; // default 2.5
-$h2-font-size: $font-size-base * 1.75; // default 2
-$h3-font-size: $font-size-base * 1.5; // default 1.75
-$h4-font-size: $font-size-base * 1.25; // default 1.5
-$h5-font-size: $font-size-base; // default 1.25
+$h2-font-size: $font-size-base * 1.5; // default 2
+$h3-font-size: $font-size-base * 1.25; // default 1.75
+$h4-font-size: $font-size-base; // default 1.5
+$h5-font-size: $font-size-base * 0.9; // default 1.25
$h6-font-size: $font-size-base * 0.85; // default 1
// Increase contrast of dropdown items
From 8b200f7b499ad04d56ee115d0f138a9114862b9c Mon Sep 17 00:00:00 2001
From: Laila Los <44241786+ElectronicBlueberry@users.noreply.github.com>
Date: Wed, 14 Sep 2022 15:56:57 +0200
Subject: [PATCH 03/25] add heading component
---
client/src/components/Common/Heading.vue | 81 ++++++++++++++++++++++++
1 file changed, 81 insertions(+)
create mode 100644 client/src/components/Common/Heading.vue
diff --git a/client/src/components/Common/Heading.vue b/client/src/components/Common/Heading.vue
new file mode 100644
index 00000000000..ae16bf2fae2
--- /dev/null
+++ b/client/src/components/Common/Heading.vue
@@ -0,0 +1,81 @@
+
+
+
+
+
+
+
+
+
+
+
From 11b238dbd79ee44ef0965c657f7d4d0e9dfece35 Mon Sep 17 00:00:00 2001
From: Laila Los <44241786+ElectronicBlueberry@users.noreply.github.com>
Date: Thu, 15 Sep 2022 10:54:46 +0200
Subject: [PATCH 04/25] add inline prop
---
client/src/components/Common/Heading.vue | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/client/src/components/Common/Heading.vue b/client/src/components/Common/Heading.vue
index ae16bf2fae2..2b0cc87eb22 100644
--- a/client/src/components/Common/Heading.vue
+++ b/client/src/components/Common/Heading.vue
@@ -13,11 +13,13 @@ const props = defineProps({
h6: Boolean,
bold: Boolean,
separator: Boolean,
+ inline: Boolean,
// acceptable sizes are "large", "medium", "small", and "text"
size: String,
icon: String,
});
+// apply heading element
for (const key of ["h1", "h2", "h3", "h4", "h5", "h6"]) {
if (props[key]) {
element = key;
@@ -25,6 +27,7 @@ for (const key of ["h1", "h2", "h3", "h4", "h5", "h6"]) {
}
}
+// apply size class
if (props.size) {
sizeClass = "h-" + props.size;
}
@@ -39,7 +42,11 @@ if (props.size) {
-
+
@@ -57,6 +64,10 @@ h1, h2, h3, h4, h5, h6 {
display: flex;
align-items: center;
gap: 0.25em;
+
+ &.inline {
+ display: inline-flex;
+ }
}
.separator {
From 339e7c3d95a6b12f981f2e1cc12ec27dddc30f2c Mon Sep 17 00:00:00 2001
From: Laila Los <44241786+ElectronicBlueberry@users.noreply.github.com>
Date: Thu, 15 Sep 2022 10:54:58 +0200
Subject: [PATCH 05/25] add demo page
---
client/src/components/HeadingsDemo.vue | 27 ++++++++++++++++++++++++++
client/src/entry/analysis/router.js | 5 +++++
lib/galaxy/webapps/galaxy/buildapp.py | 1 +
3 files changed, 33 insertions(+)
create mode 100644 client/src/components/HeadingsDemo.vue
diff --git a/client/src/components/HeadingsDemo.vue b/client/src/components/HeadingsDemo.vue
new file mode 100644
index 00000000000..7e9f7fd70d5
--- /dev/null
+++ b/client/src/components/HeadingsDemo.vue
@@ -0,0 +1,27 @@
+
+
+
+
+ Default Heading
+ Large H2 Heading
+ Medium H3 Heading with Separator
+ Heading with Icon
+ Small Heading with Icon
+ Medium Bold H2
+ Inline Text Sized Bold H3 next to some text.
+ Bold H3 with Separator
+ Bold Medium H4 with Icon
+ Small H4 with Icon
+ Small H3 with Separator
+
+
diff --git a/client/src/entry/analysis/router.js b/client/src/entry/analysis/router.js
index 3348ec04db1..a4f75b7f249 100644
--- a/client/src/entry/analysis/router.js
+++ b/client/src/entry/analysis/router.js
@@ -62,6 +62,7 @@ import { CloudAuth } from "components/User/CloudAuth";
import { ExternalIdentities } from "components/User/ExternalIdentities";
import { HistoryExport } from "components/HistoryExport/index";
import { StorageDashboardRouter } from "components/User/DiskUsage";
+import HeadingsDemo from "components/HeadingsDemo";
Vue.use(VueRouter);
@@ -471,6 +472,10 @@ export function getRouter(Galaxy) {
component: StoredWorkflowInvocations,
props: true,
},
+ {
+ path: "headings_demo",
+ component: HeadingsDemo,
+ },
],
},
],
diff --git a/lib/galaxy/webapps/galaxy/buildapp.py b/lib/galaxy/webapps/galaxy/buildapp.py
index ec91cd6cdf0..1ba742634a2 100644
--- a/lib/galaxy/webapps/galaxy/buildapp.py
+++ b/lib/galaxy/webapps/galaxy/buildapp.py
@@ -271,6 +271,7 @@ def app_pair(global_conf, load_app_kwds=None, wsgi_preflight=True, **kwargs):
webapp.add_client_route("/interactivetool_entry_points/list")
webapp.add_client_route("/libraries{path:.*?}")
webapp.add_client_route("/storage{path:.*?}")
+ webapp.add_client_route("/headings_demo")
# ==== Done
# Indicate that all configuration settings have been provided
From cb387ddbf61f91a3a584c2ce18f7356c14e57090 Mon Sep 17 00:00:00 2001
From: Laila Los <44241786+ElectronicBlueberry@users.noreply.github.com>
Date: Thu, 15 Sep 2022 14:58:41 +0200
Subject: [PATCH 06/25] fix bold separator heading
---
client/src/components/Common/Heading.vue | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/client/src/components/Common/Heading.vue b/client/src/components/Common/Heading.vue
index 2b0cc87eb22..0d4f8e2caf8 100644
--- a/client/src/components/Common/Heading.vue
+++ b/client/src/components/Common/Heading.vue
@@ -34,10 +34,10 @@ if (props.size) {
-
+
-
+
From 0cdbf38e7c65e704d33afc0f86a5a685f69950e5 Mon Sep 17 00:00:00 2001
From: Laila Los <44241786+ElectronicBlueberry@users.noreply.github.com>
Date: Fri, 16 Sep 2022 10:48:18 +0200
Subject: [PATCH 07/25] change separator heading appearance remove
icon-separator heading
---
client/src/components/Common/Heading.vue | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/client/src/components/Common/Heading.vue b/client/src/components/Common/Heading.vue
index 0d4f8e2caf8..b684a1ab747 100644
--- a/client/src/components/Common/Heading.vue
+++ b/client/src/components/Common/Heading.vue
@@ -34,9 +34,8 @@ if (props.size) {
-
-
-
+
+
@@ -72,8 +71,8 @@ h1, h2, h3, h4, h5, h6 {
.separator {
display: grid;
- grid-template-columns: auto auto 1fr;
- gap: 0.25em;
+ grid-template-columns: 1rem auto 1fr;
+ gap: 0.5rem;
align-items: center;
margin-bottom: 0.5rem;
@@ -86,7 +85,6 @@ h1, h2, h3, h4, h5, h6 {
display: block;
height: 1px;
background-color: $brand-secondary;
- min-width: 1rem;
}
}
From 99322854e753e43df7f665535b746a07b6ab796b Mon Sep 17 00:00:00 2001
From: Laila Los <44241786+ElectronicBlueberry@users.noreply.github.com>
Date: Thu, 22 Sep 2022 15:21:35 +0200
Subject: [PATCH 08/25] fix RuleCollectionBuilder css leak
---
.../src/components/RuleCollectionBuilder.vue | 318 +++++++++---------
1 file changed, 160 insertions(+), 158 deletions(-)
diff --git a/client/src/components/RuleCollectionBuilder.vue b/client/src/components/RuleCollectionBuilder.vue
index 69e40abb6f2..d21c905d9f3 100644
--- a/client/src/components/RuleCollectionBuilder.vue
+++ b/client/src/components/RuleCollectionBuilder.vue
@@ -1,5 +1,5 @@
-
+
-
+
{{
l(
@@ -548,7 +548,7 @@
{{ l("Close") }}
-
+
A problem was encountered.
@@ -1757,160 +1757,162 @@ export default {
-
From e4d52b2f81e0a7134da3c8da9707ff60da89756b Mon Sep 17 00:00:00 2001
From: Laila Los <44241786+ElectronicBlueberry@users.noreply.github.com>
Date: Thu, 22 Sep 2022 15:22:24 +0200
Subject: [PATCH 09/25] fix and slight changes Heading component
---
client/src/components/Common/Heading.vue | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/client/src/components/Common/Heading.vue b/client/src/components/Common/Heading.vue
index b684a1ab747..17d289549a8 100644
--- a/client/src/components/Common/Heading.vue
+++ b/client/src/components/Common/Heading.vue
@@ -54,7 +54,7 @@ if (props.size) {
diff --git a/client/src/components/DatasetInformation/DatasetInformation.vue b/client/src/components/DatasetInformation/DatasetInformation.vue
index 0d78156654d..9152c092464 100644
--- a/client/src/components/DatasetInformation/DatasetInformation.vue
+++ b/client/src/components/DatasetInformation/DatasetInformation.vue
@@ -1,7 +1,7 @@
-
Dataset Information
+
Dataset Information
diff --git a/client/src/components/InheritanceChain/InheritanceChain.vue b/client/src/components/InheritanceChain/InheritanceChain.vue
index a8c97986518..45e0a2e89fc 100644
--- a/client/src/components/InheritanceChain/InheritanceChain.vue
+++ b/client/src/components/InheritanceChain/InheritanceChain.vue
@@ -1,6 +1,6 @@
-
Inheritance Chain
+
Inheritance Chain
{{ datasetName }}
diff --git a/client/src/components/JobInformation/JobInformation.vue b/client/src/components/JobInformation/JobInformation.vue
index 9c520be436b..b789b258502 100644
--- a/client/src/components/JobInformation/JobInformation.vue
+++ b/client/src/components/JobInformation/JobInformation.vue
@@ -1,7 +1,7 @@
-
Job Information
+
Job Information