From f69843ff5a37ec9ba89bef50e033f552a9e04068 Mon Sep 17 00:00:00 2001 From: Nate Coraor Date: Mon, 27 Oct 2008 11:02:41 -0400 Subject: [PATCH] Fix a remote_user bug found by James Casbon. filter_by does not raise an exception when no results are returned like select_by did. --- lib/galaxy/web/framework/__init__.py | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/galaxy/web/framework/__init__.py b/lib/galaxy/web/framework/__init__.py index 69e2404a6d0..237cb4409a8 100644 --- a/lib/galaxy/web/framework/__init__.py +++ b/lib/galaxy/web/framework/__init__.py @@ -267,6 +267,7 @@ class UniverseWebTransaction( base.DefaultWebTransaction ): # remote_user middleware ensures HTTP_REMOTE_USER exists try: user = self.app.model.User.filter_by( email=self.environ[ 'HTTP_REMOTE_USER' ] ).first() + assert user is not None except: user = self.app.model.User( email=self.environ[ 'HTTP_REMOTE_USER' ] ) user.set_password_cleartext( 'external' )