Faster and cleaner set creation

test/unit/jobs/test_rule_helper.py

@@ -77,22 +77,22 @@ def test_choose_one_unhashed():
     rule_helper = __rule_helper()
 
     # Random choices if hash not set.
-    chosen_ones = set([])
+    chosen_ones = set()
     __do_a_bunch(lambda: chosen_ones.add(rule_helper.choose_one(['a', 'b'])))
 
-    assert chosen_ones == set(['a', 'b'])
+    assert chosen_ones == {'a', 'b'}
 
 
 def test_choose_one_hashed():
     rule_helper = __rule_helper()
 
     # Hashed, so all choosen ones should be the same...
-    chosen_ones = set([])
+    chosen_ones = set()
     __do_a_bunch(lambda: chosen_ones.add(rule_helper.choose_one(['a', 'b'], hash_value=1234)))
     assert len(chosen_ones) == 1
 
     # ... also can verify hashing on strings
-    chosen_ones = set([])
+    chosen_ones = set()
     __do_a_bunch(lambda: chosen_ones.add(rule_helper.choose_one(['a', 'b'], hash_value="i am a string")))
 
     assert len(chosen_ones) == 1

test/unit/test_containers.py

@@ -5,4 +5,4 @@ def test_dummy():
     t = galaxy.containers.parse_containers_config('')
     assert t == {'_default_': {'type': 'docker'}}
     s = galaxy.containers.docker_model.DockerAttributeContainer()
-    assert s.members == frozenset([])
+    assert s.members == frozenset()

test/unit/tool_util/test_tool_deps.py

@@ -140,7 +140,7 @@ def test_tool_requirements():
     assert tool_requirements_ab == ToolRequirements([REQUIREMENT_B, REQUIREMENT_A])
     assert tool_requirements_ab == ToolRequirements([REQUIREMENT_B, REQUIREMENT_A, REQUIREMENT_A])
     assert tool_requirements_ab != tool_requirements_b
-    assert len(set([tool_requirements_ab, tool_requirements_ab_dup])) == 1
+    assert len({tool_requirements_ab, tool_requirements_ab_dup}) == 1
 
 
 def test_module_dependency_resolver():