diff --git a/lib/galaxy_ext/expressions/handle_job.py b/lib/galaxy_ext/expressions/handle_job.py index 0d21f75cd29..fd9da47a629 100644 --- a/lib/galaxy_ext/expressions/handle_job.py +++ b/lib/galaxy_ext/expressions/handle_job.py @@ -16,7 +16,7 @@ warnings.filterwarnings("ignore", message=r"[\n.]DEPRECATION: Python 2", module= try: from cwltool import expression except ImportError: - expression = None + expression = None # type: ignore[assignment] from galaxy.tools.expressions import evaluate diff --git a/lib/galaxy_test/base/populators.py b/lib/galaxy_test/base/populators.py index b8f437cbf6f..24acf2c9b9c 100644 --- a/lib/galaxy_test/base/populators.py +++ b/lib/galaxy_test/base/populators.py @@ -67,7 +67,7 @@ from typing import ( Union, ) -import cwltest +import cwltest.utils import requests import yaml from bioblend.galaxy import GalaxyClient @@ -2102,7 +2102,7 @@ class CwlPopulator: try: for key, value in expected_outputs.items(): actual_output = run.get_output_as_object(key) - cwltest.compare(value, actual_output) + cwltest.utils.compare(value, actual_output) except Exception: self.dataset_populator._summarize_history(run.history_id) raise diff --git a/packages/app/setup.py b/packages/app/setup.py index 6c6e9756017..ff05f734349 100644 --- a/packages/app/setup.py +++ b/packages/app/setup.py @@ -20,8 +20,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") diff --git a/packages/auth/setup.py b/packages/auth/setup.py index 9d60dfdc4bf..9956ac4642b 100644 --- a/packages/auth/setup.py +++ b/packages/auth/setup.py @@ -3,6 +3,10 @@ import ast import os import re +from typing import ( + Dict, + List, +) try: from setuptools import setup @@ -20,8 +24,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") @@ -40,7 +45,7 @@ PACKAGES = [ ENTRY_POINTS = """ [console_scripts] """ -PACKAGE_DATA = { +PACKAGE_DATA: Dict[str, List[str]] = { # Be sure to update MANIFEST.in for source dist. "galaxy": [], } diff --git a/packages/build_scripts/commit_version.py b/packages/build_scripts/commit_version.py index b3f48dc713d..218aa54d32f 100644 --- a/packages/build_scripts/commit_version.py +++ b/packages/build_scripts/commit_version.py @@ -6,27 +6,31 @@ import re import subprocess import sys -DEV_RELEASE = os.environ.get("DEV_RELEASE", None) == "1" -PROJECT_DIRECTORY = os.getcwd() -PROJECT_DIRECTORY_NAME = os.path.basename(os.path.abspath(PROJECT_DIRECTORY)) -PROJECT_MODULE_FILENAME = f"project_galaxy_{PROJECT_DIRECTORY_NAME}.py" -PROJECT_NAME = PROJECT_DIRECTORY_NAME.replace("_", "-") - def main(argv): + DEV_RELEASE = os.environ.get("DEV_RELEASE", None) == "1" + PROJECT_DIRECTORY = os.getcwd() + PROJECT_DIRECTORY_NAME = os.path.basename(os.path.abspath(PROJECT_DIRECTORY)) + PROJECT_MODULE_FILENAME = f"project_galaxy_{PROJECT_DIRECTORY_NAME}.py" + PROJECT_NAME = PROJECT_DIRECTORY_NAME.replace("_", "-") + source_dir = argv[1] version = argv[2] mod_path = os.path.join(PROJECT_DIRECTORY, source_dir, PROJECT_MODULE_FILENAME) if not DEV_RELEASE: history_path = os.path.join(PROJECT_DIRECTORY, "HISTORY.rst") - history = open(history_path).read() + with open(history_path) as f: + history = f.read() today = datetime.datetime.today() today_str = today.strftime("%Y-%m-%d") history = history.replace(".dev0", f" ({today_str})") - open(history_path, "w").write(history) - mod = open(mod_path).read() + with open(history_path, "w") as f: + f.write(history) + with open(mod_path) as f: + mod = f.read() mod = re.sub(r"__version__ = '[\d\.]*\.dev\d+'", f"__version__ = '{version}'", mod) - mod = open(mod_path, "w").write(mod) + with open(mod_path, "w") as f: + f.write(mod) tag = f"galaxy-{PROJECT_NAME}-{version}" shell(["git", "commit", "-m", f"Version {version} of {PROJECT_NAME} (tag {tag}).", "HISTORY.rst", mod_path]) shell(["git", "tag", tag]) diff --git a/packages/build_scripts/new_version.py b/packages/build_scripts/new_version.py index 4575540a196..e23eac58073 100644 --- a/packages/build_scripts/new_version.py +++ b/packages/build_scripts/new_version.py @@ -24,13 +24,16 @@ def main(argv): new_version = ".".join(map(str, new_version_tuple)) new_dev_version = 0 else: - dev_version = re.compile(r"dev([\d]+)").search(version).group(1) + dev_match = re.compile(r"dev([\d]+)").search(version) + assert dev_match + dev_version = dev_match.group(1) new_dev_version = int(dev_version) + 1 new_version = version.replace(f"dev{dev_version}", f"dev{new_dev_version}") history_path = os.path.join(PROJECT_DIRECTORY, "HISTORY.rst") if not DEV_RELEASE: - history = open(history_path).read() + with open(history_path) as f: + history = f.read() def extend(from_str, line): from_str += "\n" @@ -45,15 +48,18 @@ def main(argv): """, ) - open(history_path, "w").write(history) + with open(history_path, "w") as f: + f.write(history) mod_path = os.path.join(PROJECT_DIRECTORY, source_dir, PROJECT_MODULE_FILENAME) - mod = open(mod_path).read() + with open(mod_path) as f: + mod = f.read() if not DEV_RELEASE: mod = re.sub(r"__version__ = '[\d\.]+'", f"__version__ = '{new_version}.dev0'", mod, 1) else: mod = re.sub(f"dev{dev_version}", f"dev{new_dev_version}", mod, 1) - mod = open(mod_path, "w").write(mod) + with open(mod_path, "w") as f: + f.write(mod) shell(["git", "commit", "-m", f"Starting work on {PROJECT_NAME} {new_version}", "HISTORY.rst", mod_path]) diff --git a/packages/build_scripts/print_version_for_release.py b/packages/build_scripts/print_version_for_release.py index 36c8f97a693..3615cc085c5 100644 --- a/packages/build_scripts/print_version_for_release.py +++ b/packages/build_scripts/print_version_for_release.py @@ -4,21 +4,30 @@ import re import sys from distutils.version import LooseVersion -DEV_RELEASE = os.environ.get("DEV_RELEASE", None) == "1" -PROJECT_DIRECTORY = os.getcwd() -PROJECT_DIRECTORY_NAME = os.path.basename(os.path.abspath(PROJECT_DIRECTORY)) -PROJECT_MODULE_FILENAME = f"project_galaxy_{PROJECT_DIRECTORY_NAME}.py" - -source_dir = sys.argv[1] -PROJECT_MODULE_PATH = os.path.join(PROJECT_DIRECTORY, source_dir, PROJECT_MODULE_FILENAME) - _version_re = re.compile(r"__version__\s+=\s+(.*)") -with open(PROJECT_MODULE_PATH, "rb") as f: - version = str(ast.literal_eval(_version_re.search(f.read().decode("utf-8")).group(1))) -if not DEV_RELEASE: - # Strip .devN - version_tuple = LooseVersion(version).version[0:3] - print(".".join(map(str, version_tuple))) -else: - print(version) + +def main(): + DEV_RELEASE = os.environ.get("DEV_RELEASE", None) == "1" + PROJECT_DIRECTORY = os.getcwd() + PROJECT_DIRECTORY_NAME = os.path.basename(os.path.abspath(PROJECT_DIRECTORY)) + PROJECT_MODULE_FILENAME = f"project_galaxy_{PROJECT_DIRECTORY_NAME}.py" + + source_dir = sys.argv[1] + PROJECT_MODULE_PATH = os.path.join(PROJECT_DIRECTORY, source_dir, PROJECT_MODULE_FILENAME) + + with open(PROJECT_MODULE_PATH, "rb") as f: + version_match = _version_re.search(f.read().decode("utf-8")) + assert version_match + version = str(ast.literal_eval(version_match.group(1))) + + if not DEV_RELEASE: + # Strip .devN + version_tuple = LooseVersion(version).version[0:3] + print(".".join(map(str, version_tuple))) + else: + print(version) + + +if __name__ == "__main__": + main() diff --git a/packages/config/setup.py b/packages/config/setup.py index a60b82d7120..4c280a2539c 100644 --- a/packages/config/setup.py +++ b/packages/config/setup.py @@ -20,8 +20,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") diff --git a/packages/data/setup.py b/packages/data/setup.py index 96ca4b1ae48..1657da1b1bc 100644 --- a/packages/data/setup.py +++ b/packages/data/setup.py @@ -20,8 +20,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") diff --git a/packages/files/setup.py b/packages/files/setup.py index b4ac6ee9ba6..7621b42feda 100644 --- a/packages/files/setup.py +++ b/packages/files/setup.py @@ -3,6 +3,10 @@ import ast import os import re +from typing import ( + Dict, + List, +) try: from setuptools import setup @@ -20,8 +24,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") @@ -41,7 +46,7 @@ PACKAGES = [ ENTRY_POINTS = """ [console_scripts] """ -PACKAGE_DATA = { +PACKAGE_DATA: Dict[str, List[str]] = { # Be sure to update MANIFEST.in for source dist. "galaxy": [], } diff --git a/packages/job_execution/setup.py b/packages/job_execution/setup.py index 1a6fe2e1bb2..5f56cdd42ec 100644 --- a/packages/job_execution/setup.py +++ b/packages/job_execution/setup.py @@ -3,6 +3,10 @@ import ast import os import re +from typing import ( + Dict, + List, +) try: from setuptools import setup @@ -20,8 +24,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") @@ -43,7 +48,7 @@ ENTRY_POINTS = """ [console_scripts] galaxy-set-metadata=galaxy.metadata.set_metadata:set_metadata """ -PACKAGE_DATA = { +PACKAGE_DATA: Dict[str, List[str]] = { # Be sure to update MANIFEST.in for source dist. "galaxy": [], } diff --git a/packages/job_metrics/setup.py b/packages/job_metrics/setup.py index 3ee4855fc0d..02b89dad47d 100644 --- a/packages/job_metrics/setup.py +++ b/packages/job_metrics/setup.py @@ -3,6 +3,10 @@ import ast import os import re +from typing import ( + Dict, + List, +) try: from setuptools import setup @@ -20,8 +24,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") @@ -40,7 +45,7 @@ PACKAGES = [ ENTRY_POINTS = """ [console_scripts] """ -PACKAGE_DATA = { +PACKAGE_DATA: Dict[str, List[str]] = { # Be sure to update MANIFEST.in for source dist. "galaxy": [], } diff --git a/packages/meta/setup.py b/packages/meta/setup.py index 941b710d8d0..5617f975bbe 100644 --- a/packages/meta/setup.py +++ b/packages/meta/setup.py @@ -3,6 +3,10 @@ import ast import os import re +from typing import ( + Dict, + List, +) try: from setuptools import setup @@ -20,8 +24,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") @@ -32,11 +37,11 @@ PROJECT_EMAIL = get_var("PROJECT_EMAIL") PROJECT_DESCRIPTION = get_var("PROJECT_DESCRIPTION") TEST_DIR = "tests" -PACKAGES = [] +PACKAGES: List[str] = [] ENTRY_POINTS = """ [console_scripts] """ -PACKAGE_DATA = { +PACKAGE_DATA: Dict[str, List[str]] = { # Be sure to update MANIFEST.in for source dist. } PACKAGE_DIR = { diff --git a/packages/objectstore/setup.py b/packages/objectstore/setup.py index 848db4bafc6..939525e3111 100644 --- a/packages/objectstore/setup.py +++ b/packages/objectstore/setup.py @@ -3,6 +3,10 @@ import ast import os import re +from typing import ( + Dict, + List, +) try: from setuptools import setup @@ -20,8 +24,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") @@ -40,7 +45,7 @@ PACKAGES = [ ENTRY_POINTS = """ [console_scripts] """ -PACKAGE_DATA = { +PACKAGE_DATA: Dict[str, List[str]] = { # Be sure to update MANIFEST.in for source dist. "galaxy": [], } diff --git a/packages/package.Makefile b/packages/package.Makefile index dbf38ce86b5..5dc4b5884d7 100644 --- a/packages/package.Makefile +++ b/packages/package.Makefile @@ -93,5 +93,4 @@ push-release: release: release-local push-release mypy: - test -f $(TEST_DIR) && mypy $(SOURCE_DIR) $(TEST_DIR) - test -f $(TEST_DIR) || mypy $(SOURCE_DIR) + mypy . diff --git a/packages/selenium/setup.py b/packages/selenium/setup.py index c806143fb72..98577e51b76 100644 --- a/packages/selenium/setup.py +++ b/packages/selenium/setup.py @@ -20,8 +20,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") diff --git a/packages/test_api/setup.py b/packages/test_api/setup.py index 5df0575feb8..81bf4bdd038 100644 --- a/packages/test_api/setup.py +++ b/packages/test_api/setup.py @@ -3,6 +3,10 @@ import ast import os import re +from typing import ( + Dict, + List, +) try: from setuptools import setup @@ -20,8 +24,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") @@ -39,7 +44,7 @@ PACKAGES = [ ENTRY_POINTS = """ [console_scripts] """ -PACKAGE_DATA = { +PACKAGE_DATA: Dict[str, List[str]] = { # Be sure to update MANIFEST.in for source dist. "galaxy": [], } diff --git a/packages/test_base/setup.py b/packages/test_base/setup.py index 1a1948f991d..22e78588af5 100644 --- a/packages/test_base/setup.py +++ b/packages/test_base/setup.py @@ -20,8 +20,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") diff --git a/packages/test_selenium/setup.py b/packages/test_selenium/setup.py index 1bfdcdb04e5..98f2e873265 100644 --- a/packages/test_selenium/setup.py +++ b/packages/test_selenium/setup.py @@ -3,6 +3,10 @@ import ast import os import re +from typing import ( + Dict, + List, +) try: from setuptools import setup @@ -20,8 +24,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") @@ -40,7 +45,7 @@ PACKAGES = [ ENTRY_POINTS = """ [console_scripts] """ -PACKAGE_DATA = { +PACKAGE_DATA: Dict[str, List[str]] = { # Be sure to update MANIFEST.in for source dist. "galaxy": [], } diff --git a/packages/tool_util/setup.py b/packages/tool_util/setup.py index d8023e328ca..09ec16be8da 100644 --- a/packages/tool_util/setup.py +++ b/packages/tool_util/setup.py @@ -20,8 +20,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") diff --git a/packages/util/setup.py b/packages/util/setup.py index e84ca646425..aa4ebdb8546 100644 --- a/packages/util/setup.py +++ b/packages/util/setup.py @@ -20,8 +20,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") diff --git a/packages/web_framework/setup.py b/packages/web_framework/setup.py index 2b2f46af48f..051f2a58a53 100644 --- a/packages/web_framework/setup.py +++ b/packages/web_framework/setup.py @@ -3,6 +3,10 @@ import ast import os import re +from typing import ( + Dict, + List, +) try: from setuptools import setup @@ -20,8 +24,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") @@ -45,7 +50,7 @@ PACKAGES = [ ENTRY_POINTS = """ [console_scripts] """ -PACKAGE_DATA = { +PACKAGE_DATA: Dict[str, List[str]] = { # Be sure to update MANIFEST.in for source dist. "galaxy": [], } diff --git a/packages/web_stack/setup.py b/packages/web_stack/setup.py index 07451506b18..b04309c8d5e 100644 --- a/packages/web_stack/setup.py +++ b/packages/web_stack/setup.py @@ -3,6 +3,10 @@ import ast import os import re +from typing import ( + Dict, + List, +) try: from setuptools import setup @@ -20,8 +24,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") @@ -39,7 +44,7 @@ PACKAGES = [ ENTRY_POINTS = """ [console_scripts] """ -PACKAGE_DATA = { +PACKAGE_DATA: Dict[str, List[str]] = { # Be sure to update MANIFEST.in for source dist. "galaxy": [], } diff --git a/packages/webapps/setup.py b/packages/webapps/setup.py index c8a8aaff1ee..a74d35093f9 100644 --- a/packages/webapps/setup.py +++ b/packages/webapps/setup.py @@ -3,6 +3,10 @@ import ast import os import re +from typing import ( + Dict, + List, +) try: from setuptools import setup @@ -20,8 +24,9 @@ with open(f"{SOURCE_DIR}/project_galaxy_{project_short_name}.py") as f: def get_var(var_name): pattern = re.compile(rf"{var_name}\s+=\s+(.*)") - match = pattern.search(init_contents).group(1) - return str(ast.literal_eval(match)) + match = pattern.search(init_contents) + assert match + return str(ast.literal_eval(match.group(1))) version = get_var("__version__") @@ -67,7 +72,7 @@ PACKAGES = [ ENTRY_POINTS = """ [console_scripts] """ -PACKAGE_DATA = { +PACKAGE_DATA: Dict[str, List[str]] = { # Be sure to update MANIFEST.in for source dist. "galaxy": [], }