From eed791167eeccb3022bc73d5554a5dbd3c18881b Mon Sep 17 00:00:00 2001 From: davelopez <46503462+davelopez@users.noreply.github.com> Date: Thu, 17 Nov 2022 11:20:18 +0100 Subject: [PATCH] Log when set metadata fails on import Co-authored-by: mvdbeek --- lib/galaxy/model/store/__init__.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/galaxy/model/store/__init__.py b/lib/galaxy/model/store/__init__.py index 70563e1b4ad..96a4c51420b 100644 --- a/lib/galaxy/model/store/__init__.py +++ b/lib/galaxy/model/store/__init__.py @@ -1,6 +1,7 @@ import abc import contextlib import datetime +import logging import os import shutil import tarfile @@ -103,6 +104,7 @@ from ... import model if TYPE_CHECKING: from galaxy.managers.workflows import WorkflowContentsManager +log = logging.getLogger(__name__) ObjectKeyType = Union[str, int] @@ -631,11 +633,12 @@ class ModelImportStore(metaclass=abc.ABCMeta): dataset_instance, history, **regenerate_kwds ) else: - # Try to set metadata directly. TODO: check efficiency of this? + # Try to set metadata directly. @mvdbeek thinks we should only record the datasets try: if dataset_instance.has_metadata_files: dataset_instance.datatype.set_meta(dataset_instance) except Exception: + log.debug(f"Metadata setting failed on {dataset_instance}", exc_info=True) dataset_instance.dataset.state = dataset_instance.dataset.states.FAILED_METADATA if model_class == "HistoryDatasetAssociation":