From ec2acc7caf2bb69e6458814ab1a7bc2f78a74572 Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Fri, 26 Aug 2022 10:08:49 -0400 Subject: [PATCH] Fix dataset visualize action routing --- .../components/History/Content/Dataset/DatasetActions.vue | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/client/src/components/History/Content/Dataset/DatasetActions.vue b/client/src/components/History/Content/Dataset/DatasetActions.vue index 140271ca1d6..e6709f85050 100644 --- a/client/src/components/History/Content/Dataset/DatasetActions.vue +++ b/client/src/components/History/Content/Dataset/DatasetActions.vue @@ -74,6 +74,7 @@ import { copy as sendToClipboard } from "utils/clipboard"; import { absPath, prependPath } from "utils/redirect.js"; import { downloadUrlMixin } from "./mixins.js"; import DatasetDownload from "./DatasetDownload"; +import { iframeAdd } from "components/plugins/legacyNavigation"; export default { components: { @@ -146,7 +147,11 @@ export default { title: title, tryIframe: false, }; - if (!this.iframeAdd(redirectParams)) { + if (!iframeAdd(redirectParams)) { + // We still use iframeAdd here to allow usage from within window + // manager, but it shouldn't actually *use* an iframe in the + // standard case (deferring to $router in the legacy routing handler). + // This should be refactored. this.$router.push(path); } },