From eae78408fbd0bb1e877aacbe8e970a35f05445dc Mon Sep 17 00:00:00 2001 From: mvdbeek Date: Thu, 10 Apr 2025 16:47:04 +0200 Subject: [PATCH] Fix dynamic filter option access when building command line Fixes https://github.com/galaxyproject/galaxy/issues/19975, broken in https://github.com/galaxyproject/galaxy/commit/0f72943993d046ffd8465938ad5eab934791bb25 --- lib/galaxy/tools/parameters/dynamic_options.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/galaxy/tools/parameters/dynamic_options.py b/lib/galaxy/tools/parameters/dynamic_options.py index 4b14c798782..4bd4d8864b0 100644 --- a/lib/galaxy/tools/parameters/dynamic_options.py +++ b/lib/galaxy/tools/parameters/dynamic_options.py @@ -42,6 +42,7 @@ from galaxy.util import ( string_as_bool, ) from galaxy.util.template import fill_template +from galaxy.work.context import WorkRequestContext from . import validation from .cancelable_request import request @@ -188,9 +189,9 @@ class DataMetaFilter(Filter): def get_dependency_name(self): return self.ref_name - def filter_options(self, options: Sequence[ParameterOption], trans, other_values): + def filter_options(self, options: Sequence[ParameterOption], trans: Optional[WorkRequestContext], other_values): options = list(options) - if trans.workflow_building_mode is workflow_building_modes.USE_HISTORY: + if trans and trans.workflow_building_mode is workflow_building_modes.USE_HISTORY: # We're in the run form, can't possibly apply a data_meta filter. return options