From 97e69fbbdfd820b3044ef3289484850bf3faa566 Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Fri, 17 Aug 2012 13:55:37 -0400 Subject: [PATCH 1/9] Fix chunk-serving logic for tabular files. --- lib/galaxy/datatypes/tabular.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/galaxy/datatypes/tabular.py b/lib/galaxy/datatypes/tabular.py index ce3b043b658..0939edae159 100644 --- a/lib/galaxy/datatypes/tabular.py +++ b/lib/galaxy/datatypes/tabular.py @@ -264,10 +264,10 @@ class Tabular( data.Text ): def display_data(self, trans, dataset, preview=False, filename=None, to_ext=None, chunk=None): #TODO Prevent failure when displaying extremely long > 50kb lines. - if to_ext or not preview: - return self._serve_raw(trans, dataset, to_ext) if chunk: return self.get_chunk(trans, dataset, chunk) + if to_ext or not preview: + return self._serve_raw(trans, dataset, to_ext) else: column_names = 'null' if dataset.metadata.column_names: @@ -644,4 +644,5 @@ class FeatureLocationIndex( Tabular ): """ file_ext='fli' MetadataElement( name="columns", default=2, desc="Number of columns", readonly=True, visible=False ) - MetadataElement( name="column_types", default=['str', 'str'], param=metadata.ColumnTypesParameter, desc="Column types", readonly=True, visible=False, no_value=[] ) \ No newline at end of file + MetadataElement( name="column_types", default=['str', 'str'], param=metadata.ColumnTypesParameter, desc="Column types", readonly=True, visible=False, no_value=[] ) + From 3360fe30725e8aeb45595a44936470753d264811 Mon Sep 17 00:00:00 2001 From: Carl Eberhard Date: Fri, 17 Aug 2012 14:39:32 -0400 Subject: [PATCH 2/9] new data for bwa_wrapper/bwa_color_wrapper functional tests From dbc2c27a82c11d6693b92c9dd8358879390cfca8 Mon Sep 17 00:00:00 2001 From: Scott McManus Date: Fri, 17 Aug 2012 15:15:48 -0400 Subject: [PATCH 3/9] Minor tweak to exit code handling --- lib/galaxy/jobs/__init__.py | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/lib/galaxy/jobs/__init__.py b/lib/galaxy/jobs/__init__.py index 5ac63f9957b..50c185834c2 100644 --- a/lib/galaxy/jobs/__init__.py +++ b/lib/galaxy/jobs/__init__.py @@ -490,7 +490,6 @@ class JobWrapper( object ): if stderr contains anything, then False is returned. Note that the job id is just for messages. """ - err_msg = "" # By default, the tool succeeded. This covers the case where the code # has a bug but the tool was ok, and it lets a workflow continue. success = True @@ -507,7 +506,7 @@ class JobWrapper( object ): # Check the exit code ranges in the order in which # they were specified. Each exit_code is a StdioExitCode # that includes an applicable range. If the exit code was in - # that range, then apply the error level and add in a message. + # that range, then apply the error level and add a message. # If we've reached a fatal error rule, then stop. max_error_level = galaxy.tools.StdioErrorLevel.NO_ERROR for stdio_exit_code in self.tool.stdio_exit_codes: @@ -515,20 +514,16 @@ class JobWrapper( object ): tool_exit_code <= stdio_exit_code.range_end ): # Tack on a generic description of the code # plus a specific code description. For example, - # this might append "Job 42: Warning: Out of Memory\n". - # TODO: Find somewhere to stick the err_msg - - # possibly to the source (stderr/stdout), possibly - # in a new db column. + # this might prepend "Job 42: Warning: Out of Memory\n". code_desc = stdio_exit_code.desc if ( None == code_desc ): code_desc = "" - tool_msg = ( "Job %s: %s: Exit code %d: %s" % ( - job.get_id_tag(), - galaxy.tools.StdioErrorLevel.desc( tool_exit_code ), + tool_msg = ( "%s: Exit code %d: %s" % ( + galaxy.tools.StdioErrorLevel.desc( stdio_exit_code.error_level ), tool_exit_code, code_desc ) ) - log.info( tool_msg ) - stderr = err_msg + stderr + log.info( "Job %s: %s" % (job.get_id_tag(), tool_msg) ) + stderr = tool_msg + "\n" + stderr max_error_level = max( max_error_level, stdio_exit_code.error_level ) if ( max_error_level >= @@ -571,7 +566,6 @@ class JobWrapper( object ): re.IGNORECASE ) if ( regex_match ): rexmsg = self.regex_err_msg( regex_match, regex) - # DELETEME log.info( "Job %s: %s" % ( job.get_id_tag(), rexmsg ) ) stderr = rexmsg + "\n" + stderr From 860bb2673c6a0324a6d0dc4738fe632d2e1a458b Mon Sep 17 00:00:00 2001 From: Jeremy Goecks Date: Fri, 17 Aug 2012 17:49:41 -0400 Subject: [PATCH 4/9] Converters enhancements: (a) ignore track lines in wiggle to bigwig converter and add clip option and (b) enable visualization of bedgraph datasets via a bedgraph to bigwig converter. --- .../converters/bedgraph_to_bigwig_converter.xml | 14 ++++++++++++++ .../converters/wig_to_bigwig_converter.xml | 2 +- lib/galaxy/datatypes/interval.py | 5 +++-- 3 files changed, 18 insertions(+), 3 deletions(-) create mode 100644 lib/galaxy/datatypes/converters/bedgraph_to_bigwig_converter.xml diff --git a/lib/galaxy/datatypes/converters/bedgraph_to_bigwig_converter.xml b/lib/galaxy/datatypes/converters/bedgraph_to_bigwig_converter.xml new file mode 100644 index 00000000000..77d2c2a42e6 --- /dev/null +++ b/lib/galaxy/datatypes/converters/bedgraph_to_bigwig_converter.xml @@ -0,0 +1,14 @@ + \ No newline at end of file diff --git a/lib/galaxy/datatypes/converters/wig_to_bigwig_converter.xml b/lib/galaxy/datatypes/converters/wig_to_bigwig_converter.xml index e85c3a7b138..d90702efe78 100644 --- a/lib/galaxy/datatypes/converters/wig_to_bigwig_converter.xml +++ b/lib/galaxy/datatypes/converters/wig_to_bigwig_converter.xml @@ -1,6 +1,6 @@