From d65df1959e5a1ae4af8941096bed88a6cbac58b9 Mon Sep 17 00:00:00 2001 From: mvdbeek Date: Mon, 4 Apr 2022 11:57:53 +0200 Subject: [PATCH] Log metadata task failure That doesn't seem right either. If we didn't wait synchonously we could do this better. --- lib/galaxy/jobs/runners/__init__.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/galaxy/jobs/runners/__init__.py b/lib/galaxy/jobs/runners/__init__.py index 5affc74768d..dc1043dd764 100644 --- a/lib/galaxy/jobs/runners/__init__.py +++ b/lib/galaxy/jobs/runners/__init__.py @@ -390,10 +390,14 @@ class BaseJobRunner: # We're synchronously waiting for a task here. This means we have to have a result backend. # That is bad practice and also means this can never become part of another task. - set_job_metadata.delay( - job_wrapper.working_directory, - extended_metadata_collection="extended" in metadata_strategy, - ).get() + try: + set_job_metadata.delay( + job_wrapper.working_directory, + extended_metadata_collection="extended" in metadata_strategy, + ).get() + except Exception: + log.exception() + return else: lib_adjust = GALAXY_LIB_ADJUST_TEMPLATE % job_wrapper.galaxy_lib_dir venv = GALAXY_VENV_TEMPLATE % job_wrapper.galaxy_virtual_env