From d3f55406473459bcc93239bdec92adae232dbafa Mon Sep 17 00:00:00 2001 From: mvdbeek Date: Fri, 20 Jan 2023 14:57:39 +0100 Subject: [PATCH] Assert that connections are invalid, instead of auto-destroyed --- client/src/utils/navigation/navigation.yml | 1 + lib/galaxy_test/selenium/test_workflow_editor.py | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/client/src/utils/navigation/navigation.yml b/client/src/utils/navigation/navigation.yml index 5b8a7a8120c..416d3b7644b 100644 --- a/client/src/utils/navigation/navigation.yml +++ b/client/src/utils/navigation/navigation.yml @@ -643,6 +643,7 @@ workflow_editor: //div[@data-label='Remove Tags']//input tool_version_button: ".tool-versions" connector_for: "#connection-${sink_id}-${source_id}" + connector_invalid_for: "#connection-${sink_id}-${source_id} .ribbon-inner-invalid" connector_destroy_callout: '.delete-terminal' save_button: '.editor-button-save' state_modal_body: '.state-upgrade-modal' diff --git a/lib/galaxy_test/selenium/test_workflow_editor.py b/lib/galaxy_test/selenium/test_workflow_editor.py index f58142eef8b..f907926eb07 100644 --- a/lib/galaxy_test/selenium/test_workflow_editor.py +++ b/lib/galaxy_test/selenium/test_workflow_editor.py @@ -557,7 +557,7 @@ steps: editor.select_datatype_text_search.wait_for_and_send_keys("bam") editor.select_datatype(datatype="bam").wait_for_and_click() editor.node.output_data_row(output_name="out_file1", extension="bam").wait_for_visible() - self.assert_not_connected("create_2#out_file1", "checksum#input") + self.assert_connection_invalid("create_2#out_file1", "checksum#input") @selenium_test def test_change_datatype_post_job_action_lost_regression(self): @@ -862,6 +862,10 @@ steps: source_id, sink_id = self.workflow_editor_source_sink_terminal_ids(source, sink) self.components.workflow_editor.connector_for(source_id=source_id, sink_id=sink_id).wait_for_visible() + def assert_connection_invalid(self, source, sink): + source_id, sink_id = self.workflow_editor_source_sink_terminal_ids(source, sink) + self.components.workflow_editor.connector_invalid_for(source_id=source_id, sink_id=sink_id).wait_for_present() + def assert_not_connected(self, source, sink): source_id, sink_id = self.workflow_editor_source_sink_terminal_ids(source, sink) self.components.workflow_editor.connector_for(source_id=source_id, sink_id=sink_id).wait_for_absent()