From d0451b86c8b765d81a3c2ae28d881d488ca7878a Mon Sep 17 00:00:00 2001 From: Martin Cech Date: Wed, 6 May 2015 14:38:08 -0400 Subject: [PATCH] avoid adding data managers to the tool search index this would occur if you have some DM installed and you install another tool trigerring the reindexing and then non-admin user uses the searchbox in the tool panel to search for something that also returns the data manager tool resulting in API giving you 404 and logging that user without proper permissions tried to access DM --- lib/galaxy/tools/search/__init__.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/galaxy/tools/search/__init__.py b/lib/galaxy/tools/search/__init__.py index fa3fe142dfa..d7ee29f3c8d 100644 --- a/lib/galaxy/tools/search/__init__.py +++ b/lib/galaxy/tools/search/__init__.py @@ -37,6 +37,9 @@ class ToolBoxSearch( object ): self.index = self.storage.create_index( schema ) writer = self.index.writer() for id, tool in self.toolbox.tools(): + # Do not add data managers to the public index + if tool.tool_type == 'manage_data': + continue add_doc_kwds = { "id": id, "name": to_unicode( tool.name ),