From 0218af04eba52c8261daf0b9089244d38db6dc44 Mon Sep 17 00:00:00 2001 From: John Chilton Date: Tue, 4 Nov 2025 10:46:22 -0500 Subject: [PATCH] Simplify transiently failing test (#21224) see if this stablizes it at all. --- lib/galaxy_test/selenium/test_history_sharing.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/galaxy_test/selenium/test_history_sharing.py b/lib/galaxy_test/selenium/test_history_sharing.py index 16371bcd68f..31931564b49 100644 --- a/lib/galaxy_test/selenium/test_history_sharing.py +++ b/lib/galaxy_test/selenium/test_history_sharing.py @@ -185,7 +185,14 @@ class TestPrivateHistorySharingRequiresPermissionChanges(SeleniumTestCase): # Verify the permission change required dialog appears self.screenshot("history_private_sharing_permissions_dialog") - self.components.histories.sharing.permissions_change_required.wait_for_visible() + + # The next line seems flakey for reasons I don't understand. The data + # description is attached the model and I do see the modal visually but + # maybe the modal is not visible because of the modal content or something? + # At any rate - the following wait would be totally sufficient to ensure + # the modal is rendered and to continue with the test - so I'm going to + # just comment out this line and see if it resolves #21224. + # self.components.histories.sharing.permissions_change_required.wait_for_visible() # Verify the default selected option is 'make_accessible_to_shared' element = self.components.histories.sharing.permissions_change_required_how.wait_for_visible()