From ca5132d7bf5165877dfbed873a89bbe7b1a5f5c5 Mon Sep 17 00:00:00 2001 From: mvdbeek Date: Thu, 26 Oct 2023 15:43:18 +0200 Subject: [PATCH] Skip change_datatype things if we're not actually changing the extension Side-steps a problem with FileParameter in the most efficient way possible. This likely became a problem for one of Wolfgang's workflow afer we dropped some earlier unnecessary flushes. --- lib/galaxy/datatypes/registry.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/lib/galaxy/datatypes/registry.py b/lib/galaxy/datatypes/registry.py index 8c14bb64d8d..ce5f9ad890e 100644 --- a/lib/galaxy/datatypes/registry.py +++ b/lib/galaxy/datatypes/registry.py @@ -590,13 +590,14 @@ class Registry: return self.datatypes_by_extension.get(ext, None) def change_datatype(self, data, ext): - data.extension = ext - # call init_meta and copy metadata from itself. The datatype - # being converted *to* will handle any metadata copying and - # initialization. - if data.has_data(): - data.set_size() - data.init_meta(copy_from=data) + if data.extension != ext: + data.extension = ext + # call init_meta and copy metadata from itself. The datatype + # being converted *to* will handle any metadata copying and + # initialization. + if data.has_data(): + data.set_size() + data.init_meta(copy_from=data) return data def load_datatype_converters(self, toolbox, use_cached=False):