From bf7cc9072c59090091ad16a3a9fa341265e78cf4 Mon Sep 17 00:00:00 2001 From: mvdbeek Date: Fri, 15 Oct 2021 15:38:45 +0200 Subject: [PATCH] Always set item.history to self What I've observed is that for a job with a immediate post job action (e.g setting a dataset tag within https://github.com/galaxyproject/galaxy/blob/202bff420761c63fc30ac933630d72dd40496248/lib/galaxy_test/api/test_workflows.py#L3605) something is resetting hda.history_id. I have no idea how this happens. Possibly https://github.com/galaxyproject/galaxy/blob/f66520e4a6f6b71516c48861f473c1b430ad967f/lib/galaxy/tools/actions/__init__.py#L557 fetches a new HDA from a different sqlalchemy session and modifies it ?? --- lib/galaxy/model/__init__.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/galaxy/model/__init__.py b/lib/galaxy/model/__init__.py index 65961a3f67c..1b7580b6d4d 100644 --- a/lib/galaxy/model/__init__.py +++ b/lib/galaxy/model/__init__.py @@ -2419,10 +2419,9 @@ class History(Base, HasTags, Dictifiable, UsesAnnotations, HasName, RepresentByI def stage_addition(self, items): history_id = self.id for item in listify(items): + item.history = self if history_id: item.history_id = history_id - else: - item.history = self self._pending_additions.append(item) @property