From 7a1d7fcaf4672c0a3ad382b07362b969180797d2 Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Mon, 4 Dec 2017 12:45:45 -0500 Subject: [PATCH 1/6] download behaves badly on firefox, preventing right clicking to copy the url here --- client/galaxy/scripts/mvc/dataset/dataset-li.js | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/client/galaxy/scripts/mvc/dataset/dataset-li.js b/client/galaxy/scripts/mvc/dataset/dataset-li.js index 97f8b831b6e..db96fd99962 100644 --- a/client/galaxy/scripts/mvc/dataset/dataset-li.js +++ b/client/galaxy/scripts/mvc/dataset/dataset-li.js @@ -286,16 +286,10 @@ var DatasetListItemView = _super.extend( return this._renderMetaFileDownloadButton(); } - return $( - [ - '`, - '', - "" - ].join("") - ); + return $(` + + + `); }, /** Render the download button which opens a dropdown with links to download assoc. meta files (indeces, etc.) */ From 0ab21a2f4ed195711d0a55fa369dbc2fc09b123a Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Mon, 4 Dec 2017 13:06:26 -0500 Subject: [PATCH 2/6] We preventdefault on this anyway, so the void(0) doesn't do anything. This allows right click copy on primary dataset regardless of whether or not there are extra meta files. --- client/galaxy/scripts/mvc/dataset/dataset-li.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/galaxy/scripts/mvc/dataset/dataset-li.js b/client/galaxy/scripts/mvc/dataset/dataset-li.js index db96fd99962..b8684908b12 100644 --- a/client/galaxy/scripts/mvc/dataset/dataset-li.js +++ b/client/galaxy/scripts/mvc/dataset/dataset-li.js @@ -298,7 +298,7 @@ var DatasetListItemView = _super.extend( return $( [ '