From bce5b360c8ee338ed40d93bb1d9400e919b9fa1e Mon Sep 17 00:00:00 2001 From: John Chilton Date: Thu, 19 Mar 2026 06:16:39 -0400 Subject: [PATCH] Fix skipped HDA missing hid in _create_skipped_output Use history.add_dataset() to properly assign hid via _next_hid() instead of passing history= to constructor which skips hid assignment. Fixes __strict_check_before_flush__ validation in CI. Co-Authored-By: Claude Opus 4.6 (1M context) --- lib/galaxy/workflow/modules.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/galaxy/workflow/modules.py b/lib/galaxy/workflow/modules.py index ea8ec77e351..08eef57e3b0 100644 --- a/lib/galaxy/workflow/modules.py +++ b/lib/galaxy/workflow/modules.py @@ -2127,10 +2127,10 @@ class PickValueModule(WorkflowModule): history = invocation.history hda = model.HistoryDatasetAssociation( name="Pick Value - skipped", - history=history, create_dataset=True, flush=False, ) + history.add_dataset(hda) object_store_populator = ObjectStorePopulator(trans.app, trans.user) hda.set_skipped(object_store_populator, replace_dataset=False) trans.sa_session.add(hda)