From f362c15d4c60b33b9e84be4906c7b518364dddc3 Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Wed, 12 Feb 2020 09:55:56 -0500 Subject: [PATCH 1/2] Prevent duplicate listing of doi link and link (text, with href doi link) --- client/galaxy/scripts/components/Citations.vue | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/client/galaxy/scripts/components/Citations.vue b/client/galaxy/scripts/components/Citations.vue index 0d9e8ecfe32..ffed609c5cb 100644 --- a/client/galaxy/scripts/components/Citations.vue +++ b/client/galaxy/scripts/components/Citations.vue @@ -155,9 +155,8 @@ export default { doiUrl = `https://doi.org/${fields.doi}`; ref += `[doi:${fields.doi}]`; } - const url = fields.url || doiUrl; - if (url) { - ref += `[Link]`; + if (fields.url) { + ref += `[Link]`; } return convertLaTeX({ onError: (error, latex) => `{${stringifyLaTeX(latex)}}` }, ref); }, From 7f52daa4d21bd8fe24e3c4890f4d93b101536d4f Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Wed, 12 Feb 2020 09:58:08 -0500 Subject: [PATCH 2/2] Minor simplification. --- client/galaxy/scripts/components/Citations.vue | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/client/galaxy/scripts/components/Citations.vue b/client/galaxy/scripts/components/Citations.vue index ffed609c5cb..75906671f88 100644 --- a/client/galaxy/scripts/components/Citations.vue +++ b/client/galaxy/scripts/components/Citations.vue @@ -150,10 +150,8 @@ export default { fields.howpublished )}${this._asSentence(fields.note)}`; } - let doiUrl = ""; if (fields.doi) { - doiUrl = `https://doi.org/${fields.doi}`; - ref += `[doi:${fields.doi}]`; + ref += `[doi:${fields.doi}]`; } if (fields.url) { ref += `[Link]`;