From b19798ffda69f982c3099fd7eeccb6973275d746 Mon Sep 17 00:00:00 2001 From: mvdbeek Date: Fri, 7 Feb 2020 11:56:17 +0100 Subject: [PATCH] Open non-binary files in 'r' mode in DatasetDataProvider Fixes https://sentry.galaxyproject.org/sentry/main/issues/501242/ --- lib/galaxy/datatypes/dataproviders/dataset.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/galaxy/datatypes/dataproviders/dataset.py b/lib/galaxy/datatypes/dataproviders/dataset.py index 76666fa5ab0..f6c5496b001 100644 --- a/lib/galaxy/datatypes/dataproviders/dataset.py +++ b/lib/galaxy/datatypes/dataproviders/dataset.py @@ -52,7 +52,8 @@ class DatasetDataProvider(base.DataProvider): self.dataset = dataset # this dataset file is obviously the source # TODO: this might be a good place to interface with the object_store... - super(DatasetDataProvider, self).__init__(open(dataset.file_name, 'rb')) + mode = 'rb' if dataset.datatype.is_binary else 'r' + super(DatasetDataProvider, self).__init__(open(dataset.file_name, mode)) # TODO: this is a bit of a mess @classmethod