From b12b951e91e6b8472f81d73f184c40aac7f9aad8 Mon Sep 17 00:00:00 2001 From: John Chilton Date: Thu, 27 Apr 2017 15:41:12 -0400 Subject: [PATCH] Attempted fix for transiently failing API test_jobs introduced in #3619. A couple things need to occur while the jobs are "running" and it seems that 60 seconds wasn't enough time to sleep for all that to happen on Jenkins. I checked the timing in the raw logs (they are for some reasons being filtered out in the Jenkins display of the XUnit) - and indeed the jobs are properly sleeping the correct amount of time but the client API calls need some more time it seems. My initial thought was maybe the jobs were being interrupted or something - and that does not appear to be the case. --- test/api/test_jobs.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/api/test_jobs.py b/test/api/test_jobs.py index c4bc99f30f6..c3ee2418391 100644 --- a/test/api/test_jobs.py +++ b/test/api/test_jobs.py @@ -131,7 +131,7 @@ class JobsApiTestCase( api.ApiTestCase ): self._assert_has_keys( show_jobs_response.json(), "command_line", "external_id" ) def test_deleting_output_keep_running_until_all_deleted( self ): - history_id, job_state, outputs = self._setup_running_two_output_job( 60 ) + history_id, job_state, outputs = self._setup_running_two_output_job( 120 ) # Delete one of the two outputs and make sure the job is still running. self._raw_update_history_item( history_id, outputs[0]["id"], {"deleted": True} ) @@ -145,7 +145,7 @@ class JobsApiTestCase( api.ApiTestCase ): assert final_state in ["deleted_new", "deleted"], final_state def test_purging_output_keep_running_until_all_purged( self ): - history_id, job_state, outputs = self._setup_running_two_output_job( 60 ) + history_id, job_state, outputs = self._setup_running_two_output_job( 120 ) # Pretty much right away after the job is running, these paths should be populated - # if they are grab them and make sure they are deleted at the end of the job.