From ab2c7c2c079b51ffd4ed7ef00724ef3f8d2636ec Mon Sep 17 00:00:00 2001 From: John Chilton Date: Tue, 1 Dec 2015 12:33:35 +0000 Subject: [PATCH] Tool execution micro optimization... ... Don't create an extra list to reverse, just iterate over in reversed order. --- lib/galaxy/tools/actions/__init__.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/galaxy/tools/actions/__init__.py b/lib/galaxy/tools/actions/__init__.py index 02d6fb9216d..091d7738426 100644 --- a/lib/galaxy/tools/actions/__init__.py +++ b/lib/galaxy/tools/actions/__init__.py @@ -178,9 +178,7 @@ class DefaultToolAction( object ): input_names = [] input_ext = 'data' input_dbkey = incoming.get( "dbkey", "?" ) - inp_items = inp_data.items() - inp_items.reverse() - for name, data in inp_items: + for name, data in reversed(inp_data.items()): if not data: data = NoneDataset( datatypes_registry=trans.app.datatypes_registry ) continue