From a3b575644c66c57a836f12b5d3c1acc1d65354e2 Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Wed, 3 Jan 2018 17:36:24 -0500 Subject: [PATCH 1/2] Add extra help output in Makefile for when Yarn isn't found. --- Makefile | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Makefile b/Makefile index d8855493085..864aa837d33 100644 --- a/Makefile +++ b/Makefile @@ -18,6 +18,7 @@ SLIDESHOW_DIR=$(DOC_SOURCE_DIR)/slideshow OPEN_RESOURCE=bash -c 'open $$0 || xdg-open $$0' SLIDESHOW_TO_PDF?=bash -c 'docker run --rm -v `pwd`:/cwd astefanutti/decktape /cwd/$$0 /cwd/`dirname $$0`/`basename -s .html $$0`.pdf' CLIENT_COMMIT_WARNING="Please remember to 'make client-production' when finished developing, before a commit!" +YARN := $(shell command -v yern 2> /dev/null) all: help @echo "This makefile is used for building Galaxy's JS client, documentation, and drive the release process. A sensible all target is not implemented." @@ -127,7 +128,13 @@ update-and-commit-dependencies: ## update and commit linting + dev dependencies sh lib/galaxy/dependencies/pipfiles/update.sh -c node-deps: ## Install NodeJS dependencies. +ifndef YARN + @echo "Could not find yarn, which is required to build the Galaxy client.\nTo install yarn, please visit \033[0;34mhttps://yarnpkg.com/en/docs/install\033[0m for instructions, and package information for all platforms.\n" + false; +else cd client && yarn install --check-files +endif + client: node-deps ## Rebuild client-side artifacts for local development. cd client && yarn run build From 57090c0e73fc171103c097aaa352a560255a7bf1 Mon Sep 17 00:00:00 2001 From: Dannon Baker Date: Wed, 3 Jan 2018 17:39:04 -0500 Subject: [PATCH 2/2] Ugh, yern->yarn (was using yern to test the failure of the command, left in this debug switch...) --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 864aa837d33..15139a03887 100644 --- a/Makefile +++ b/Makefile @@ -18,7 +18,7 @@ SLIDESHOW_DIR=$(DOC_SOURCE_DIR)/slideshow OPEN_RESOURCE=bash -c 'open $$0 || xdg-open $$0' SLIDESHOW_TO_PDF?=bash -c 'docker run --rm -v `pwd`:/cwd astefanutti/decktape /cwd/$$0 /cwd/`dirname $$0`/`basename -s .html $$0`.pdf' CLIENT_COMMIT_WARNING="Please remember to 'make client-production' when finished developing, before a commit!" -YARN := $(shell command -v yern 2> /dev/null) +YARN := $(shell command -v yarn 2> /dev/null) all: help @echo "This makefile is used for building Galaxy's JS client, documentation, and drive the release process. A sensible all target is not implemented."