From 4cd41fbfb95cb10a4ee92836d40aab781c95c644 Mon Sep 17 00:00:00 2001 From: John Chilton Date: Tue, 27 Aug 2019 14:14:09 -0400 Subject: [PATCH] Fix Pulsar version checking logic. --- lib/galaxy/jobs/runners/pulsar.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/galaxy/jobs/runners/pulsar.py b/lib/galaxy/jobs/runners/pulsar.py index 0ee2655a57e..5bae761e019 100644 --- a/lib/galaxy/jobs/runners/pulsar.py +++ b/lib/galaxy/jobs/runners/pulsar.py @@ -628,7 +628,9 @@ class PulsarJobRunner(AsynchronousJobRunner): pulsar_version = packaging.version.parse(remote_job_config.get('pulsar_version', "0.6.0")) needed_version = packaging.version.parse("0.0.0") log.info("pulsar_version is %s" % pulsar_version) - for feature in list(check_features.keys()) + ['_default_']: + for feature, needed in list(check_features.items()) + [('_default_', True)]: + if not needed: + continue if pulsar_version < MINIMUM_PULSAR_VERSIONS[feature]: needed_version = max(needed_version, MINIMUM_PULSAR_VERSIONS[feature]) if pulsar_version < needed_version: