From a1c2a77ef311590f63ec948bf3750338b397c0f3 Mon Sep 17 00:00:00 2001 From: davelopez <46503462+davelopez@users.noreply.github.com> Date: Fri, 19 Feb 2021 13:00:14 +0100 Subject: [PATCH] Add type annotations to controller --- lib/galaxy/webapps/galaxy/api/group_roles.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/galaxy/webapps/galaxy/api/group_roles.py b/lib/galaxy/webapps/galaxy/api/group_roles.py index d7361b5ec5c..3be7ed95880 100644 --- a/lib/galaxy/webapps/galaxy/api/group_roles.py +++ b/lib/galaxy/webapps/galaxy/api/group_roles.py @@ -3,7 +3,9 @@ API operations on Group objects. """ import logging +from galaxy.managers.context import ProvidesAppContext from galaxy.managers.group_roles import GroupRolesManager +from galaxy.schema.fields import EncodedDatabaseIdField from galaxy.web import ( expose_api, require_admin, @@ -21,7 +23,7 @@ class GroupRolesAPIController(BaseAPIController): @require_admin @expose_api - def index(self, trans, group_id, **kwd): + def index(self, trans: ProvidesAppContext, group_id: EncodedDatabaseIdField, **kwd): """ GET /api/groups/{encoded_group_id}/roles Displays a collection (list) of groups. @@ -30,7 +32,7 @@ class GroupRolesAPIController(BaseAPIController): @require_admin @expose_api - def show(self, trans, id, group_id, **kwd): + def show(self, trans: ProvidesAppContext, id: EncodedDatabaseIdField, group_id: EncodedDatabaseIdField, **kwd): """ GET /api/groups/{encoded_group_id}/roles/{encoded_role_id} Displays information about a group role. @@ -39,7 +41,7 @@ class GroupRolesAPIController(BaseAPIController): @require_admin @expose_api - def update(self, trans, id, group_id, **kwd): + def update(self, trans: ProvidesAppContext, id: EncodedDatabaseIdField, group_id: EncodedDatabaseIdField, **kwd): """ PUT /api/groups/{encoded_group_id}/roles/{encoded_role_id} Adds a role to a group @@ -48,7 +50,7 @@ class GroupRolesAPIController(BaseAPIController): @require_admin @expose_api - def delete(self, trans, id, group_id, **kwd): + def delete(self, trans: ProvidesAppContext, id: EncodedDatabaseIdField, group_id: EncodedDatabaseIdField, **kwd): """ DELETE /api/groups/{encoded_group_id}/roles/{encoded_role_id} Removes a role from a group