From 98a189ceff8e0fd329acfbb4fdec585d85317e95 Mon Sep 17 00:00:00 2001 From: mvdbeek Date: Mon, 11 Mar 2019 13:23:37 +0100 Subject: [PATCH] Fix warning message formatting in sharing controller Reported by @erasche in https://github.com/galaxyproject/galaxy/issues/7503#issuecomment-471496500, broken in https://github.com/galaxyproject/galaxy/commit/e4399021520440a8f58e33dbae161f031f8da9eb --- lib/galaxy/web/base/controller.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/galaxy/web/base/controller.py b/lib/galaxy/web/base/controller.py index 628406e4312..811c67251c8 100644 --- a/lib/galaxy/web/base/controller.py +++ b/lib/galaxy/web/base/controller.py @@ -1459,10 +1459,10 @@ class SharableMixin(object): try: trans.app.security_agent.make_dataset_public(hda.dataset) except Exception: - log.warning("Unable to make dataset with id: %s public.").format(dataset.id) + log.warning("Unable to make dataset with id: %s public", dataset.id) skipped = True else: - log.warning("User without permissions tried to make dataset with id: %s public.").format(dataset.id) + log.warning("User without permissions tried to make dataset with id: %s public", dataset.id) skipped = True return item, skipped