diff --git a/.gitignore b/.gitignore index 55dd4d05c14..91f6c027723 100644 --- a/.gitignore +++ b/.gitignore @@ -153,7 +153,7 @@ static/plugins static/scripts node_modules bower_components -client/galaxy/scripts/libs/* +client/src/libs/* client/galaxy/style/less/* # Documentation build files. diff --git a/client/.eslintignore b/client/.eslintignore index 5dc007acedc..b913d99c342 100644 --- a/client/.eslintignore +++ b/client/.eslintignore @@ -1,6 +1,6 @@ *.test.js -galaxy/scripts/qunit -galaxy/scripts/mocha -galaxy/scripts/libs -galaxy/scripts/nls -galaxy/scripts/legacy +src/qunit +src/mocha +src/libs +src/nls +src/legacy diff --git a/client/README.md b/client/README.md index 46ae25f4a65..4a81854af4d 100644 --- a/client/README.md +++ b/client/README.md @@ -175,7 +175,7 @@ following commands. ## Writing a test file The karma configs are setup to look at any file ending in "*.test.js". Please -place your test files inside client/galaxy/scripts folders right next to +place your test files inside client/src folders right next to whatever files that they are testing. ```javascript @@ -301,13 +301,13 @@ broken up into easily testable chunks. ## Specific test scenarios & examples -[Mocking an imported dependency](https://github.com/galaxyproject/galaxy/blob/dev/client/galaxy/scripts/components/Tags/tagService.test.js) +[Mocking an imported dependency](https://github.com/galaxyproject/galaxy/blob/dev/client/src/components/Tags/tagService.test.js) -[Testing async operations](https://github.com/galaxyproject/galaxy/blob/dev/client/galaxy/scripts/components/Tags/tagService.test.js) +[Testing async operations](https://github.com/galaxyproject/galaxy/blob/dev/client/src/components/Tags/tagService.test.js) -[Testing a Vue component for expected rendering output](https://github.com/galaxyproject/galaxy/blob/dev/client/galaxy/scripts/components/Tags/StatelessTags.test.js) +[Testing a Vue component for expected rendering output](https://github.com/galaxyproject/galaxy/blob/dev/client/src/components/Tags/StatelessTags.test.js) -[Firing an event against a shallow mounted vue component](https://github.com/galaxyproject/galaxy/blob/dev/client/galaxy/scripts/components/Tags/StatelessTags.test.js) +[Firing an event against a shallow mounted vue component](https://github.com/galaxyproject/galaxy/blob/dev/client/src/components/Tags/StatelessTags.test.js) ## The dirty secret about testing diff --git a/client/gulpfile.js b/client/gulpfile.js index 2796429de4b..fe752b522d8 100644 --- a/client/gulpfile.js +++ b/client/gulpfile.js @@ -35,13 +35,13 @@ const paths = { requirejs: ["require.js", "require.js"], underscore: ["underscore.js", "underscore.js"], }, - libs: ["galaxy/scripts/libs/**/*.js"], + libs: ["src/libs/**/*.js"], }; function stageLibs(callback) { Object.keys(paths.lib_locs).forEach((lib) => { var p1 = path.resolve(path.join(paths.node_modules, lib, paths.lib_locs[lib][0])); - var p2 = path.resolve(path.join("galaxy", "scripts", "libs", paths.lib_locs[lib][1])); + var p2 = path.resolve(path.join("src", "libs", paths.lib_locs[lib][1])); if (fs.existsSync(p1)) { del.sync(p2); fs.createReadStream(p1).pipe(fs.createWriteStream(p2)); diff --git a/client/karma/karma.config.base.js b/client/karma/karma.config.base.js index 0b77a81245b..368a6551446 100644 --- a/client/karma/karma.config.base.js +++ b/client/karma/karma.config.base.js @@ -12,7 +12,7 @@ module.exports = config => { }); return { - basePath: "../galaxy/scripts", + basePath: "../src", browsers: ["ChromeHeadlessNoSandbox"], client: { captureConsole: true diff --git a/client/package.json b/client/package.json index 844c8b33cbe..0da185fd18b 100644 --- a/client/package.json +++ b/client/package.json @@ -75,15 +75,15 @@ "webpack-production-maps": "GXY_BUILD_SOURCEMAPS=1 webpack -p", "gulp": "gulp", "save-build-hash": "(git rev-parse HEAD 2>/dev/null || echo '') >../static/client_build_hash.txt", - "prettier": "prettier --write 'galaxy/style/scss/**/*.scss' 'galaxy/scripts/**/{*.js,*.vue}' '!galaxy/scripts/libs/**'", - "prettier-check": "prettier --check 'galaxy/style/scss/**/*.scss' 'galaxy/scripts/**/{*.js,*.vue}' '!galaxy/scripts/libs/**'", + "prettier": "prettier --write 'galaxy/style/scss/**/*.scss' 'src/**/{*.js,*.vue}' '!src/libs/**'", + "prettier-check": "prettier --check 'galaxy/style/scss/**/*.scss' 'src/**/{*.js,*.vue}' '!src/libs/**'", "styleguide": "vue-styleguidist server", "styleguide:build": "vue-styleguidist build", "test": "yarn run test-mocha && yarn run test-qunit", "test-watch": "yarn run test-mocha --no-single-run", "test-qunit": "karma start karma/karma.config.qunit.js", "test-mocha": "karma start karma/karma.config.mocha.js", - "eslint": "eslint -c .eslintrc.js galaxy/scripts --ext .js,.vue" + "eslint": "eslint -c .eslintrc.js src --ext .js,.vue" }, "devDependencies": { "@babel/core": "^7.10.1", diff --git a/client/src/components/RuleCollectionBuilder.vue b/client/src/components/RuleCollectionBuilder.vue index fc90ace0352..59dc8e56cb7 100644 --- a/client/src/components/RuleCollectionBuilder.vue +++ b/client/src/components/RuleCollectionBuilder.vue @@ -1690,7 +1690,7 @@ export default { }; - +