diff --git a/lib/galaxy_test/driver/integration_util.py b/lib/galaxy_test/driver/integration_util.py index 732fe16b52e..376e20274af 100644 --- a/lib/galaxy_test/driver/integration_util.py +++ b/lib/galaxy_test/driver/integration_util.py @@ -184,9 +184,9 @@ def integration_module_instance(clazz): return pytest.fixture(scope='module')(_instance) -def integration_tool_runner(tool_ids, tool_version=None): +def integration_tool_runner(tool_ids): def test_tools(instance, tool_id): - instance._run_tool_test(tool_id, tool_version=tool_version) + instance._run_tool_test(tool_id) return pytest.mark.parametrize("tool_id", tool_ids)(test_tools) diff --git a/test/functional/tools/multiple_versions_v01.xml b/test/functional/tools/multiple_versions_v01.xml index 215ca72ed9b..fa72fd5f65e 100644 --- a/test/functional/tools/multiple_versions_v01.xml +++ b/test/functional/tools/multiple_versions_v01.xml @@ -1,7 +1,7 @@ - - echo "Version 0.1" > $out_file1 - + '$out_file1' + ]]> diff --git a/test/functional/tools/multiple_versions_v02.xml b/test/functional/tools/multiple_versions_v02.xml index 28c16fe25ec..5eb00f8718d 100644 --- a/test/functional/tools/multiple_versions_v02.xml +++ b/test/functional/tools/multiple_versions_v02.xml @@ -1,7 +1,7 @@ - - echo "Version 0.2" > $out_file1 - + '$out_file1' + ]]> diff --git a/lib/galaxy_test/api/test_galaxy_interactor.py b/test/integration/test_galaxy_interactor.py similarity index 77% rename from lib/galaxy_test/api/test_galaxy_interactor.py rename to test/integration/test_galaxy_interactor.py index 0e3613ce6e4..950b6c64db6 100644 --- a/lib/galaxy_test/api/test_galaxy_interactor.py +++ b/test/integration/test_galaxy_interactor.py @@ -1,22 +1,22 @@ -# Test galaxy interactor +"""Integration tests for GalaxyInteractor.""" from packaging.version import Version -from galaxy_test.base.populators import skip_without_tool -from ._framework import ApiTestCase +from galaxy_test.driver import integration_util -class GalaxyInteractorBackwardCompatTestCase(ApiTestCase): +class GalaxyInteractorTestCase(integration_util.IntegrationTestCase): + + framework_tool_and_types = True def test_local_test_data_download(self): self.galaxy_interactor._target_galaxy_version = Version("18.09") assert self.galaxy_interactor.supports_test_data_download is False assert self.galaxy_interactor.test_data_download(tool_id='cat1', filename='1.bed').startswith(b'chr1\t147962192\t147962580') + def test_run_test_select_version(self): + self._run_tool_test(tool_id='multiple_versions', tool_version="0.1") -class GalaxyInteractorTestCase(ApiTestCase): - - @skip_without_tool("multiple_versions") def test_get_tool_tests(self): # test that get_tool_tests will return the right tests when the tool_version has a '+' in it test_data = self.galaxy_interactor.get_tool_tests(tool_id="multiple_versions", tool_version="0.1+galaxy6") diff --git a/test/integration/test_galaxy_interactor_verify.py b/test/integration/test_galaxy_interactor_verify.py deleted file mode 100644 index eb26cea0c87..00000000000 --- a/test/integration/test_galaxy_interactor_verify.py +++ /dev/null @@ -1,13 +0,0 @@ -"""Integration tests for the Pulsar embedded runner.""" - -from galaxy_test.driver import integration_util - - -class ToolTestIntegrationInstance(integration_util.IntegrationInstance): - """Describe a Galaxy test instance with embedded pulsar configured.""" - - framework_tool_and_types = True - -instance = integration_util.integration_module_instance(ToolTestIntegrationInstance) - -test_tools = integration_util.integration_tool_runner(['multiple_versions'], tool_version='0.1')