From 976f9487b0e2f9cb5db98f2c91f10ac487512ec3 Mon Sep 17 00:00:00 2001
From: guerler <aysam.guerler@gmail.com>
Date: Tue, 20 Sep 2022 10:44:04 -0400
Subject: [PATCH] Expand usage of writable prop in history panel to allow read
 only histories

---
 client/src/components/History/Content/ContentItem.vue    | 5 ++++-
 client/src/components/History/Content/ContentOptions.vue | 9 +++++----
 .../History/Content/Dataset/DatasetActions.vue           | 3 ++-
 .../History/Content/Dataset/DatasetDetails.vue           | 2 ++
 .../components/History/CurrentHistory/HistoryPanel.vue   | 7 ++++++-
 client/src/components/History/HistoryView.vue            | 1 +
 client/src/components/History/Layout/DetailsLayout.vue   | 2 +-
 7 files changed, 21 insertions(+), 8 deletions(-)

diff --git a/client/src/components/History/Content/ContentItem.vue b/client/src/components/History/Content/ContentItem.vue
index 3711c7a9f03..785ab82fa70 100644
--- a/client/src/components/History/Content/ContentItem.vue
+++ b/client/src/components/History/Content/ContentItem.vue
@@ -52,6 +52,7 @@
                 </span>
                 <ContentOptions
                     v-else
+                    :writable="writable"
                     :is-dataset="isDataset"
                     :is-deleted="item.deleted"
                     :is-history-item="isHistoryItem"
@@ -85,6 +86,7 @@
             <DatasetDetails
                 v-if="expandDataset"
                 :dataset="item"
+                :writable="writable"
                 :show-highlight="isHistoryItem"
                 :item-urls="itemUrls"
                 @edit="onEdit"
@@ -117,6 +119,7 @@ export default {
         FontAwesomeIcon,
     },
     props: {
+        writable: { type: Boolean, default: true },
         expandDataset: { type: Boolean, required: true },
         highlight: { type: String, default: null },
         id: { type: Number, required: true },
@@ -169,7 +172,7 @@ export default {
             return this.item.tags;
         },
         tagsDisabled() {
-            return !this.expandDataset || !this.isHistoryItem;
+            return !this.writable || !this.expandDataset || !this.isHistoryItem;
         },
         isCollection() {
             return "collection_type" in this.item;
diff --git a/client/src/components/History/Content/ContentOptions.vue b/client/src/components/History/Content/ContentOptions.vue
index 7b67a6b0dee..b9bf32ed725 100644
--- a/client/src/components/History/Content/ContentOptions.vue
+++ b/client/src/components/History/Content/ContentOptions.vue
@@ -12,7 +12,7 @@
             <icon icon="eye" />
         </b-button>
         <b-button
-            v-if="isHistoryItem"
+            v-if="writable && isHistoryItem"
             :disabled="editDisabled"
             :title="editButtonTitle"
             class="edit-btn px-1"
@@ -23,7 +23,7 @@
             <icon icon="pen" />
         </b-button>
         <b-button
-            v-if="isHistoryItem && !isDeleted"
+            v-if="writable && isHistoryItem && !isDeleted"
             class="delete-btn px-1"
             title="Delete"
             size="sm"
@@ -32,7 +32,7 @@
             <icon icon="trash" />
         </b-button>
         <b-button
-            v-if="isHistoryItem && isDeleted"
+            v-if="writable && isHistoryItem && isDeleted"
             class="undelete-btn px-1"
             title="Undelete"
             size="sm"
@@ -41,7 +41,7 @@
             <icon icon="trash-restore" />
         </b-button>
         <b-button
-            v-if="isHistoryItem && !isVisible"
+            v-if="writable && isHistoryItem && !isVisible"
             class="unhide-btn px-1"
             title="Unhide"
             size="sm"
@@ -56,6 +56,7 @@
 import { prependPath } from "utils/redirect.js";
 export default {
     props: {
+        writable: { type: Boolean, default: true },
         isDataset: { type: Boolean, required: true },
         isDeleted: { type: Boolean, default: false },
         isHistoryItem: { type: Boolean, required: true },
diff --git a/client/src/components/History/Content/Dataset/DatasetActions.vue b/client/src/components/History/Content/Dataset/DatasetActions.vue
index 1d8ca26805d..23cfdf6c2ad 100644
--- a/client/src/components/History/Content/Dataset/DatasetActions.vue
+++ b/client/src/components/History/Content/Dataset/DatasetActions.vue
@@ -33,7 +33,7 @@
                     <span class="fa fa-info-circle" />
                 </b-button>
                 <b-button
-                    v-if="showRerun"
+                    v-if="writable && showRerun"
                     class="rerun-btn px-1"
                     title="Run Job Again"
                     size="sm"
@@ -83,6 +83,7 @@ export default {
     mixins: [downloadUrlMixin],
     props: {
         item: { type: Object, required: true },
+        writable: { type: Boolean, default: true },
         showHighlight: { type: Boolean, default: false },
         itemUrls: { type: Object, required: true },
     },
diff --git a/client/src/components/History/Content/Dataset/DatasetDetails.vue b/client/src/components/History/Content/Dataset/DatasetDetails.vue
index c84e194ff17..6492e7e1c8d 100644
--- a/client/src/components/History/Content/Dataset/DatasetDetails.vue
+++ b/client/src/components/History/Content/Dataset/DatasetDetails.vue
@@ -23,6 +23,7 @@
                 </div>
                 <DatasetActions
                     :item="result"
+                    :writable="writable"
                     :show-highlight="showHighlight"
                     :item-urls="itemUrls"
                     @toggleHighlights="toggleHighlights" />
@@ -97,6 +98,7 @@ export default {
     },
     props: {
         dataset: { type: Object, required: true },
+        writable: { type: Boolean, default: true },
         showHighlight: { type: Boolean, default: false },
         itemUrls: { type: Object, required: true },
     },
diff --git a/client/src/components/History/CurrentHistory/HistoryPanel.vue b/client/src/components/History/CurrentHistory/HistoryPanel.vue
index ded6ad9d475..d924aa70d63 100644
--- a/client/src/components/History/CurrentHistory/HistoryPanel.vue
+++ b/client/src/components/History/CurrentHistory/HistoryPanel.vue
@@ -35,7 +35,10 @@
                         :filter-text.sync="filterText"
                         :show-advanced.sync="showAdvanced" />
                     <section v-if="!showAdvanced">
-                        <HistoryDetails :history="history" @update:history="$emit('updateHistory', $event)" />
+                        <HistoryDetails
+                            :history="history"
+                            :writeable="writable"
+                            @update:history="$emit('updateHistory', $event)" />
                         <HistoryMessages :history="history" />
                         <HistoryCounter
                             v-if="showControls"
@@ -108,6 +111,7 @@
                                         is-history-item
                                         :item="item"
                                         :name="item.name"
+                                        :writable="writable"
                                         :expand-dataset="isExpanded(item)"
                                         :is-dataset="isDataset(item)"
                                         :highlight="getHighlight(item)"
@@ -177,6 +181,7 @@ export default {
         listOffset: { type: Number, default: 0 },
         history: { type: Object, required: true },
         filter: { type: String, default: "" },
+        writable: { type: Boolean, default: true },
         showControls: { type: Boolean, default: true },
     },
     data() {
diff --git a/client/src/components/History/HistoryView.vue b/client/src/components/History/HistoryView.vue
index cfadfe598ad..23df927c3e1 100644
--- a/client/src/components/History/HistoryView.vue
+++ b/client/src/components/History/HistoryView.vue
@@ -31,6 +31,7 @@
                     v-else
                     v-on="handlers"
                     :history="history"
+                    :writable="user.id == history.user_id"
                     :show-controls="false"
                     @view-collection="onViewCollection" />
                 <CopyModal id="copy-history-modal" :history="history" />
diff --git a/client/src/components/History/Layout/DetailsLayout.vue b/client/src/components/History/Layout/DetailsLayout.vue
index 629388419b3..91640105ada 100644
--- a/client/src/components/History/Layout/DetailsLayout.vue
+++ b/client/src/components/History/Layout/DetailsLayout.vue
@@ -1,7 +1,7 @@
 <template>
     <section class="m-3 details" data-description="edit details">
         <b-button
-            :disabled="currentUser.isAnonymous || !writeable"
+            v-if="writeable && !currentUser.isAnonymous"
             class="edit-button ml-1 float-right"
             data-description="editor toggle"
             size="sm"