From 907bd53776eccec0e8d3fadfb69223dadcc48600 Mon Sep 17 00:00:00 2001
From: Devon Ryan <dpryan79@gmail.com>
Date: Tue, 27 Jun 2017 11:11:19 +0200
Subject: [PATCH] Make the phred range stricter and more explicit.

---
 lib/galaxy/datatypes/sequence.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/galaxy/datatypes/sequence.py b/lib/galaxy/datatypes/sequence.py
index 4ca9b919a6c..016e7309294 100644
--- a/lib/galaxy/datatypes/sequence.py
+++ b/lib/galaxy/datatypes/sequence.py
@@ -705,8 +705,7 @@ class BaseFastq ( Sequence ):
     def sangerQualities( lines ):
         """Presuming lines are lines from a fastq file, return True if the qualities are compatible with sanger encoding"""
         for line in lines[3::4]:
-            _ = [ord( c ) for c in line[0]]
-            if max( _ ) > ord( 'M' ):
+            if not all(_ >= '!' and _ <= 'M' for _ in line[0]):
                 return False
         return True